Skip to contentSkip to conversation

skge: remove redundunt free_irq under spinlock

PATCH Applied Stephen Hemminger 2 participants 2 messages Dec 12, 2017 – Dec 13, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 skge: remove redundunt free_irq under spinlock

The code to handle multi-port SKGE boards was freeing IRQ twice. The first one was under lock and might sleep.

---
Given that multi-port SKGE devices are very old and unlikely to still be in use. This patch does not need to go to stable.

 drivers/net/ethernet/marvell/skge.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/ethernet/marvell/skge.c +0 -1
index 6e423f098a60..31efc47c847e 100644
@@ -4081,7 +4081,6 @@ static void skge_remove(struct pci_dev *pdev)
 	if (hw->ports > 1) {
 		skge_write32(hw, B0_IMSK, 0);
 		skge_read32(hw, B0_IMSK);
-		free_irq(pdev->irq, hw);
 	}
 	spin_unlock_irq(&hw->hw_lock);
 
Signature · 1 line
2.11.0
maintainer Applied
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Tue, 12 Dec 2017 10:30:29 -0800

Quoted 7 lines

The code to handle multi-port SKGE boards was freeing IRQ twice. The first one was under lock and might sleep.

---
Given that multi-port SKGE devices are very old and unlikely to still be in use. This patch does not need to go to stable.

Applied, thanks Stephen.