skge: remove redundunt free_irq under spinlock
PATCH 1/1 skge: remove redundunt free_irq under spinlock
The code to handle multi-port SKGE boards was freeing IRQ twice. The first one was under lock and might sleep.
Signed-off-by Stephen Hemminger <[email protected]>
---
Given that multi-port SKGE devices are very old and unlikely to still be in use. This patch does not need to go to stable.
drivers/net/ethernet/marvell/skge.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/ethernet/marvell/skge.c +0 -1
@@ -4081,7 +4081,6 @@ static void skge_remove(struct pci_dev *pdev)if (hw->ports >1 ) {skge_write32 (hw,B0_IMSK ,0 );skge_read32 (hw,B0_IMSK ); -free_irq (pdev->irq, hw); }spin_unlock_irq (&hw->hw_lock);
Signature · 1 line
2.11.0
From: Stephen Hemminger <[email protected]>
Date: Tue, 12 Dec 2017 10:30:29 -0800
Quoted 7 lines
The code to handle multi-port SKGE boards was freeing IRQ twice. The first one was under lock and might sleep.
Signed-off-by Stephen Hemminger <[email protected]>---
Given that multi-port SKGE devices are very old and unlikely to still be in use. This patch does not need to go to stable.
Applied, thanks Stephen.