Skip to contentSkip to conversation

sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

PATCH New Andre Heider 3 participants 5 messages Dec 13, 2017 – Dec 19, 2017 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

fdt overlay support is useful for all sunxi boards, enable per default and remove it from sunxi defconfigs.

---

Hi,

there're way too many sunxi boards so I'm not 100% sure this is the best approach...

Are there boards where enabling this is definitely not desired?

Thanks,
Andre

 arch/arm/Kconfig           | 1 +
 configs/CHIP_defconfig     | 1 -
 configs/CHIP_pro_defconfig | 1 -
 3 files changed, 1 insertion(+), 2 deletions(-)
arch/arm/Kconfig +1 -0
index 73909952d0..25847b3aa1 100644
@@ -715,6 +715,7 @@ config ARCH_SUNXI
 	select USE_TINY_PRINTF
 	imply CMD_GPT
 	imply FAT_WRITE
+	imply OF_LIBFDT_OVERLAY
 	imply PRE_CONSOLE_BUFFER
 	imply SPL_GPIO_SUPPORT
 	imply SPL_LIBCOMMON_SUPPORT
configs/CHIP_defconfig +0 -1
index d057bee172..8b38ba450e 100644
@@ -21,4 +21,3 @@ CONFIG_AXP_ALDO4_VOLT=3300
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
-CONFIG_OF_LIBFDT_OVERLAY=y
configs/CHIP_pro_defconfig +0 -1
index fa572eac57..089152e9ff 100644
@@ -26,4 +26,3 @@ CONFIG_AXP_ALDO4_VOLT=3300
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
-CONFIG_OF_LIBFDT_OVERLAY=y
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/1 sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

Quoted 4 lines · Andre Heider

fdt overlay support is useful for all sunxi boards, enable per default and remove it from sunxi defconfigs.

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171213/a06cf8ca/attachment.sig>
#2 lore raw

PATCH 1/1 sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

In reply to Andre Heider
Quoted 26 lines · Andre Heider

fdt overlay support is useful for all sunxi boards, enable per default and remove it from sunxi defconfigs.

---

Hi,

there're way too many sunxi boards so I'm not 100% sure this is the best approach...

Are there boards where enabling this is definitely not desired?

Thanks,
Andre

 arch/arm/Kconfig           | 1 +
 configs/CHIP_defconfig     | 1 -
 configs/CHIP_pro_defconfig | 1 -
 3 files changed, 1 insertion(+), 2 deletions(-)
arch/arm/Kconfig +0 -0
index 73909952d0..25847b3aa1 100644

arch/arm/Kconfig config ARCH_SUNXI · line 718

Quoted 4 lines
arch/arm/Kconfig +1 -0
@@ -715,6 +715,7 @@ config ARCH_SUNXI
        select USE_TINY_PRINTF
        imply CMD_GPT
        imply FAT_WRITE
+       imply OF_LIBFDT_OVERLAY

It's increasing u-boot.itb size to 512KB (which is 508K earlier) and in either case the size moves on env side where env start 0x88000 (504KB)

#3 lore raw

PATCH 1/1 sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

Quoted 22 lines · Jagan Teki
Quoted 21 lines · Andre Heider

fdt overlay support is useful for all sunxi boards, enable per default and remove it from sunxi defconfigs.

---

Hi,

there're way too many sunxi boards so I'm not 100% sure this is the best approach...

Are there boards where enabling this is definitely not desired?

Thanks,
Andre

 arch/arm/Kconfig           | 1 +
 configs/CHIP_defconfig     | 1 -
 configs/CHIP_pro_defconfig | 1 -
 3 files changed, 1 insertion(+), 2 deletions(-)
Quoted 13 lines

arch/arm/Kconfig config ARCH_SUNXI · line 718

Quoted 9 lines
arch/arm/Kconfig +1 -0
index 73909952d0..25847b3aa1 100644
@@ -715,6 +715,7 @@ config ARCH_SUNXI
        select USE_TINY_PRINTF
        imply CMD_GPT
        imply FAT_WRITE
+       imply OF_LIBFDT_OVERLAY

It's increasing u-boot.itb size to 512KB (which is 508K earlier) and in either case the size moves on env side where env start 0x88000 (504KB)

Right, so maybe we can make that conditional to ARM?

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171219/9555daca/attachment.sig>
#4 lore raw

PATCH 1/1 sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

Quoted 37 lines · Maxime Ripard
Quoted 22 lines · Jagan Teki
Quoted 21 lines · Andre Heider

fdt overlay support is useful for all sunxi boards, enable per default and remove it from sunxi defconfigs.

---

Hi,

there're way too many sunxi boards so I'm not 100% sure this is the best approach...

Are there boards where enabling this is definitely not desired?

Thanks,
Andre

  arch/arm/Kconfig           | 1 +
  configs/CHIP_defconfig     | 1 -
  configs/CHIP_pro_defconfig | 1 -
  3 files changed, 1 insertion(+), 2 deletions(-)
Quoted 13 lines

arch/arm/Kconfig config ARCH_SUNXI · line 718

Quoted 9 lines
arch/arm/Kconfig +1 -0
index 73909952d0..25847b3aa1 100644
@@ -715,6 +715,7 @@ config ARCH_SUNXI
         select USE_TINY_PRINTF
         imply CMD_GPT
         imply FAT_WRITE
+       imply OF_LIBFDT_OVERLAY

It's increasing u-boot.itb size to 512KB (which is 508K earlier) and in either case the size moves on env side where env start 0x88000 (504KB)

Quoted 4 lines

Right, so maybe we can make that conditional to ARM?

Maxime

From the 'we're out of space' thread:
...

Quoted 4 lines

So, with FIT_ENABLE_SHA256_SUPPORT, LZMADEC, ISO_PARTITION and the overlay support, we're at 500kB.

Again, tight, but under the limit.

...

If I understood correctly the issue will be solved without any requiring changes to this patch.
Let me know if that is not the case.

Thanks,
Andre