Skip to contentSkip to conversation

am335x_evm: Fix DFU for eMMC

PATCH In review Sam Protsenko 4 participants 4 messages Dec 12, 2017 – Dec 18, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 am335x_evm: Fix DFU for eMMC

Use dfu_alt_info_emmc variable from include/environment/ti/dfu.h file. It was probably overlooked when extracting DFU variables to mentioned file.

This patch fixes DFU on BeagleBone Black, so that we can use commands like ones below to upgrade various images on eMMC:

=> setenv dfu_alt_info $dfu_alt_info_emmc
=> dfu 0 mmc 1

$ dfu-util -D MLO -a MLO.raw
$ dfu-util -D u-boot.img -a u-boot.img.raw

Without this patch, the user is forced to assign the value to dfu_alt_info_emmc manually, which contradicts with instructions [1].

[1] http://processors.wiki.ti.com/index.php/Linux_Core_U-Boot_User%27s_Guide

---
 include/configs/am335x_evm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/am335x_evm.h +1 -1
index 5ad0366730..856c546fc1 100644
@@ -255,7 +255,7 @@
 /* USB Device Firmware Update support */
 #ifndef CONFIG_SPL_BUILD
 #define DFUARGS \
-	"dfu_alt_info_emmc=rawemmc raw 0 3751936\0" \
+	DFU_ALT_INFO_EMMC \
 	DFU_ALT_INFO_MMC \
 	DFU_ALT_INFO_RAM \
 	DFU_ALT_INFO_NAND
Signature · 1 line
2.15.0
#1 lore raw

PATCH 1/1 am335x_evm: Fix DFU for eMMC

Quoted 13 lines · Sam Protsenko

Use dfu_alt_info_emmc variable from include/environment/ti/dfu.h file. It was probably overlooked when extracting DFU variables to mentioned file.

This patch fixes DFU on BeagleBone Black, so that we can use commands like ones below to upgrade various images on eMMC:

=> setenv dfu_alt_info $dfu_alt_info_emmc
=> dfu 0 mmc 1

$ dfu-util -D MLO -a MLO.raw
$ dfu-util -D u-boot.img -a u-boot.img.raw

Quoted 6 lines

Without this patch, the user is forced to assign the value to dfu_alt_info_emmc manually, which contradicts with instructions [1].

[1] http://processors.wiki.ti.com/index.php/Linux_Core_U-Boot_User%27s_Guide

Thanks and regards,
Lokesh

#2 lore raw

PATCH 1/1 am335x_evm: Fix DFU for eMMC

In reply to Sam Protsenko
Quoted 29 lines · On Tue, 12 Dec 2017 20:07:41 +0200 Sam Protsenko <[email protected]>…

Use dfu_alt_info_emmc variable from include/environment/ti/dfu.h file. It was probably overlooked when extracting DFU variables to mentioned file.

This patch fixes DFU on BeagleBone Black, so that we can use commands like ones below to upgrade various images on eMMC:

=> setenv dfu_alt_info $dfu_alt_info_emmc
=> dfu 0 mmc 1

$ dfu-util -D MLO -a MLO.raw
$ dfu-util -D u-boot.img -a u-boot.img.raw

Without this patch, the user is forced to assign the value to dfu_alt_info_emmc manually, which contradicts with instructions [1].

[1]
http://processors.wiki.ti.com/index.php/Linux_Core_U-Boot_User%27s_Guide

---
 include/configs/am335x_evm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/include/configs/am335x_evm.h index 5ad0366730..856c546fc1 100644

include/configs/am335x_evm.h line 261

Quoted 8 lines
include/configs/am335x_evm.h +1 -1
@@ -255,7 +255,7 @@
 /* USB Device Firmware Update support */
 #ifndef CONFIG_SPL_BUILD
 #define DFUARGS \
-	"dfu_alt_info_emmc=rawemmc raw 0 3751936\0" \
+	DFU_ALT_INFO_EMMC \
 	DFU_ALT_INFO_MMC \
 	DFU_ALT_INFO_RAM \
 	DFU_ALT_INFO_NAND

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171213/cc3c5d42/attachment.sig>

#3 lore raw
In reply to Sam Protsenko
Quoted 13 lines · Sam Protsenko

Use dfu_alt_info_emmc variable from include/environment/ti/dfu.h file. It was probably overlooked when extracting DFU variables to mentioned file.

This patch fixes DFU on BeagleBone Black, so that we can use commands like ones below to upgrade various images on eMMC:

=> setenv dfu_alt_info $dfu_alt_info_emmc
=> dfu 0 mmc 1

$ dfu-util -D MLO -a MLO.raw
$ dfu-util -D u-boot.img -a u-boot.img.raw

Quoted 8 lines

Without this patch, the user is forced to assign the value to dfu_alt_info_emmc manually, which contradicts with instructions [1].

[1] http://processors.wiki.ti.com/index.php/Linux_Core_U-Boot_User%27s_Guide

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171218/6bd50ace/attachment.sig>