more build failures

DISCUSSION Vincent McIntyre 3 participants 5 messages Dec 15, 2017 – Dec 17, 2017 Media (V4L/DVB)

lore

Share & tools

lore

Vincent McIntyre

author

2017-12-15 12:41 UTC #0 lore raw

Hi,

Don't get me wrong, I appreciate the vast amount of work going on here. Just letting you know what I'm seeing.

+ date
Friday 15 December 23:28:52 AEDT 2017
+ uname -a
Linux ubuntu 4.4.0-103-generic #126-Ubuntu SMP Mon Dec 4 16:23:28 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
+ cat /proc/version_signature
Ubuntu 4.4.0-103.126-generic 4.4.98

...

+ git --no-pager log -1
commit 4058fea6b2507661d66af5298c048d7c55338f42

Author: Jasmin Jessich <[email protected]>
Date:   Tue Dec 12 12:49:01 2017 -0500

fixup v3.13_ddbridge_pcimsi.patch

Required after the ddbridge 0.9.32 bump in media_tree.

Signed-off-by Jasmin Jessich <[email protected]>

Signed-off-by Daniel Scheller <[email protected]>

...

+ git --no-pager log -1
commit 0393e735649dc41358adb7b603bd57dad1ed3260

Author: Laurent Pinchart <[email protected]>
Date:   Tue Oct 17 13:15:54 2017 -0400

media: uvcvideo: Stream error events carry no data

According to the UVC specification, stream error events carry no data. Fix a buffer overflow (that should be harmless given data alignment) when reporting the stream error event by removing the data byte from the message.

Signed-off-by Laurent Pinchart <[email protected]>

Signed-off-by Mauro Carvalho Chehab <[email protected]>

...

$ make allyesconfig
make -C /home/me/git/clones/media_build/v4l allyesconfig
make[1]: Entering directory '/home/me/git/clones/media_build/v4l'
No version yet, using 4.4.0-103-generic
make[2]: Entering directory '/home/me/git/clones/media_build/linux'
Syncing with dir ../media/
Applying patches for kernel 4.4.0-103-generic
patch -s -f -N -p1 -i ../backports/api_version.patch
patch -s -f -N -p1 -i ../backports/pr_fmt.patch
patch -s -f -N -p1 -i ../backports/debug.patch
patch -s -f -N -p1 -i ../backports/drx39xxj.patch
patch -s -f -N -p1 -i ../backports/v4.14_compiler_h.patch
patch -s -f -N -p1 -i ../backports/v4.14_saa7146_timer_cast.patch
patch -s -f -N -p1 -i ../backports/v4.14_module_param_call.patch
patch -s -f -N -p1 -i ../backports/v4.12_revert_solo6x10_copykerneluser.patch
patch -s -f -N -p1 -i ../backports/v4.10_sched_signal.patch
1 out of 1 hunk FAILED
The text leading up to this was:
--------------------------
|diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
|index 015e41bd036e..fd61081b47d9 100644
|--- a/drivers/staging/media/lirc/lirc_zilog.c
|+++ b/drivers/staging/media/lirc/lirc_zilog.c
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Makefile:130: recipe for target 'apply_patches' failed
make[2]: *** [apply_patches] Error 1
make[2]: Leaving directory '/home/me/git/clones/media_build/linux'
Makefile:374: recipe for target 'allyesconfig' failed
make[1]: *** [allyesconfig] Error 2
make[1]: Leaving directory '/home/me/git/clones/media_build/v4l'
Makefile:26: recipe for target 'allyesconfig' failed
make: *** [allyesconfig] Error 2
can't select all drivers at ./build line 525
+ status=29
+ date
Friday 15 December  23:29:17 AEDT 2017
+ [ 0 = 29 ]

Vincent McIntyre

author

2017-12-16 03:49 UTC #1 lore raw

Quoted 34 lines · Vincent McIntyre

...

$ make allyesconfig
make -C /home/me/git/clones/media_build/v4l allyesconfig
make[1]: Entering directory '/home/me/git/clones/media_build/v4l'
No version yet, using 4.4.0-103-generic
make[2]: Entering directory '/home/me/git/clones/media_build/linux'
Syncing with dir ../media/
Applying patches for kernel 4.4.0-103-generic
patch -s -f -N -p1 -i ../backports/api_version.patch
patch -s -f -N -p1 -i ../backports/pr_fmt.patch
patch -s -f -N -p1 -i ../backports/debug.patch
patch -s -f -N -p1 -i ../backports/drx39xxj.patch
patch -s -f -N -p1 -i ../backports/v4.14_compiler_h.patch
patch -s -f -N -p1 -i ../backports/v4.14_saa7146_timer_cast.patch
patch -s -f -N -p1 -i ../backports/v4.14_module_param_call.patch
patch -s -f -N -p1 -i ../backports/v4.12_revert_solo6x10_copykerneluser.patch
patch -s -f -N -p1 -i ../backports/v4.10_sched_signal.patch
1 out of 1 hunk FAILED
The text leading up to this was:
--------------------------
|diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
|index 015e41bd036e..fd61081b47d9 100644
|--- a/drivers/staging/media/lirc/lirc_zilog.c
|+++ b/drivers/staging/media/lirc/lirc_zilog.c
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Makefile:130: recipe for target 'apply_patches' failed
make[2]: *** [apply_patches] Error 1
make[2]: Leaving directory '/home/me/git/clones/media_build/linux'
Makefile:374: recipe for target 'allyesconfig' failed
make[1]: *** [allyesconfig] Error 2

Quoted 8 lines

make[1]: Leaving directory '/home/me/git/clones/media_build/v4l'
Makefile:26: recipe for target 'allyesconfig' failed
make: *** [allyesconfig] Error 2
can't select all drivers at ./build line 525
+ status=29
+ date
Friday 15 December  23:29:17 AEDT 2017
+ [ 0 = 29 ]

I managed to get past the failure above with this change

- media: rc: move ir-lirc-codec.c contents into lirc_dev.c
media: lirc: remove last remnants of lirc kapi
- Sean removed lirc_zilog.c, so it no longer needs patching

backports/v4.10_sched_signal.patch +0 ~~-26~~

@@ -195,19 +195,6 @@ index 0e8025b7b4dd..8c59d4f53200 100644
  #include <linux/delay.h>
  #include <linux/videodev2.h>
  #include <linux/v4l2-dv-timings.h>
-diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
-index db1e7b70c998..fc03068e22b5 100644
---- a/drivers/media/rc/lirc_dev.c
-+++ b/drivers/media/rc/lirc_dev.c
-@@ -18,7 +18,7 @@
- #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
- 
- #include <linux/module.h>
--#include <linux/sched/signal.h>
-+#include <linux/sched.h>
- #include <linux/ioctl.h>
- #include <linux/poll.h>
- #include <linux/mutex.h>
 diff --git a/drivers/media/usb/cpia2/cpia2_core.c b/drivers/media/usb/cpia2/cpia2_core.c
 index 0efba0da0a45..5d8aa65ab40b 100644
 --- a/drivers/media/usb/cpia2/cpia2_core.c

@@ -246,19 +233,6 @@ index 0b5c43f7e020..36bd904946bd 100644
  #include <linux/slab.h>
  #include <linux/interrupt.h>
  
-diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
-index 015e41bd036e..fd61081b47d9 100644
---- a/drivers/staging/media/lirc/lirc_zilog.c
-+++ b/drivers/staging/media/lirc/lirc_zilog.c
-@@ -42,7 +42,7 @@
- #include <linux/module.h>
- #include <linux/kmod.h>
- #include <linux/kernel.h>
--#include <linux/sched/signal.h>
-+#include <linux/sched.h>
- #include <linux/fs.h>
- #include <linux/poll.h>
- #include <linux/string.h>

However it falls over later in a way I don't think I can help with.

...

  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-i2c-core.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-audio.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-encoder.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-video-v4l.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-eeprom.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-main.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-hdw.o
/home/me/git/clones/media_build/v4l/pvrusb2-hdw.c: In function 'pvr2_send_request_ex':
/home/me/git/clones/media_build/v4l/pvrusb2-hdw.c:3651:7: error: implicit declaration of function 'usb_urb_ep_type_check' [-Werror=implicit-function-declaration]
   if (usb_urb_ep_type_check(hdw->ctl_write_urb)) {
       ^

cc1: some warnings being treated as errors
scripts/Makefile.build:258: recipe for target '/home/me/git/clones/media_build/v4l/pvrusb2-hdw.o' failed make[3]: *** [/home/me/git/clones/media_build/v4l/pvrusb2-hdw.o] Error 1
Makefile:1423: recipe for target '_module_/home/me/git/clones/media_build/v4l' failed make[2]: *** [_module_/home/me/git/clones/media_build/v4l] Error 2
make[2]: Leaving directory '/usr/src/linux-headers-4.4.0-103-generic'
Makefile:51: recipe for target 'default' failed
make[1]: *** [default] Error 2
make[1]: Leaving directory '/home/me/git/clones/media_build/v4l'
Makefile:26: recipe for target 'all' failed
make: *** [all] Error 2

Cheers
Vince

Hans Verkuil

2017-12-16 10:02 UTC #2 lore raw

Hi Vincent,

A lot of code has been merged this week and more is in the pipeline for next week. I'd rather wait until that's in before looking at build failures.

Regards,

Hans

Quoted 120 lines · Vincent McIntyre

Quoted 34 lines · Vincent McIntyre

...

$ make allyesconfig
make -C /home/me/git/clones/media_build/v4l allyesconfig
make[1]: Entering directory '/home/me/git/clones/media_build/v4l'
No version yet, using 4.4.0-103-generic
make[2]: Entering directory '/home/me/git/clones/media_build/linux'
Syncing with dir ../media/
Applying patches for kernel 4.4.0-103-generic
patch -s -f -N -p1 -i ../backports/api_version.patch
patch -s -f -N -p1 -i ../backports/pr_fmt.patch
patch -s -f -N -p1 -i ../backports/debug.patch
patch -s -f -N -p1 -i ../backports/drx39xxj.patch
patch -s -f -N -p1 -i ../backports/v4.14_compiler_h.patch
patch -s -f -N -p1 -i ../backports/v4.14_saa7146_timer_cast.patch
patch -s -f -N -p1 -i ../backports/v4.14_module_param_call.patch
patch -s -f -N -p1 -i ../backports/v4.12_revert_solo6x10_copykerneluser.patch
patch -s -f -N -p1 -i ../backports/v4.10_sched_signal.patch
1 out of 1 hunk FAILED
The text leading up to this was:
--------------------------
|diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
|index 015e41bd036e..fd61081b47d9 100644
|--- a/drivers/staging/media/lirc/lirc_zilog.c
|+++ b/drivers/staging/media/lirc/lirc_zilog.c
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Makefile:130: recipe for target 'apply_patches' failed
make[2]: *** [apply_patches] Error 1
make[2]: Leaving directory '/home/me/git/clones/media_build/linux'
Makefile:374: recipe for target 'allyesconfig' failed
make[1]: *** [allyesconfig] Error 2

Quoted 8 lines

make[1]: Leaving directory '/home/me/git/clones/media_build/v4l'
Makefile:26: recipe for target 'allyesconfig' failed
make: *** [allyesconfig] Error 2
can't select all drivers at ./build line 525
+ status=29
+ date
Friday 15 December  23:29:17 AEDT 2017
+ [ 0 = 29 ]

I managed to get past the failure above with this change

- media: rc: move ir-lirc-codec.c contents into lirc_dev.c
media: lirc: remove last remnants of lirc kapi
- Sean removed lirc_zilog.c, so it no longer needs patching

backports/v4.10_sched_signal.patch +0 ~~-26~~

@@ -195,19 +195,6 @@ index 0e8025b7b4dd..8c59d4f53200 100644
  #include <linux/delay.h>
  #include <linux/videodev2.h>
  #include <linux/v4l2-dv-timings.h>
-diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
-index db1e7b70c998..fc03068e22b5 100644
---- a/drivers/media/rc/lirc_dev.c
-+++ b/drivers/media/rc/lirc_dev.c
-@@ -18,7 +18,7 @@
- #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
- 
- #include <linux/module.h>
--#include <linux/sched/signal.h>
-+#include <linux/sched.h>
- #include <linux/ioctl.h>
- #include <linux/poll.h>
- #include <linux/mutex.h>
 diff --git a/drivers/media/usb/cpia2/cpia2_core.c b/drivers/media/usb/cpia2/cpia2_core.c
 index 0efba0da0a45..5d8aa65ab40b 100644
 --- a/drivers/media/usb/cpia2/cpia2_core.c

@@ -246,19 +233,6 @@ index 0b5c43f7e020..36bd904946bd 100644
  #include <linux/slab.h>
  #include <linux/interrupt.h>
 
-diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
-index 015e41bd036e..fd61081b47d9 100644
---- a/drivers/staging/media/lirc/lirc_zilog.c
-+++ b/drivers/staging/media/lirc/lirc_zilog.c
-@@ -42,7 +42,7 @@
- #include <linux/module.h>
- #include <linux/kmod.h>
- #include <linux/kernel.h>
--#include <linux/sched/signal.h>
-+#include <linux/sched.h>
- #include <linux/fs.h>
- #include <linux/poll.h>
- #include <linux/string.h>

However it falls over later in a way I don't think I can help with.

...

  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-i2c-core.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-audio.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-encoder.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-video-v4l.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-eeprom.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-main.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-hdw.o
/home/me/git/clones/media_build/v4l/pvrusb2-hdw.c: In function 'pvr2_send_request_ex':
/home/me/git/clones/media_build/v4l/pvrusb2-hdw.c:3651:7: error: implicit declaration of function 'usb_urb_ep_type_check' [-Werror=implicit-function-declaration]
   if (usb_urb_ep_type_check(hdw->ctl_write_urb)) {
       ^

Cheers
Vince

Mauro Carvalho Chehab

2017-12-16 11:30 UTC #3 lore raw

In reply to Vincent McIntyre

Em Sat, 16 Dec 2017 14:49:41 +1100
Vincent McIntyre <[email protected]> escreveu:

Quoted 105 lines · Vincent McIntyre

Quoted 34 lines

...

$ make allyesconfig
make -C /home/me/git/clones/media_build/v4l allyesconfig
make[1]: Entering directory '/home/me/git/clones/media_build/v4l'
No version yet, using 4.4.0-103-generic
make[2]: Entering directory '/home/me/git/clones/media_build/linux'
Syncing with dir ../media/
Applying patches for kernel 4.4.0-103-generic
patch -s -f -N -p1 -i ../backports/api_version.patch
patch -s -f -N -p1 -i ../backports/pr_fmt.patch
patch -s -f -N -p1 -i ../backports/debug.patch
patch -s -f -N -p1 -i ../backports/drx39xxj.patch
patch -s -f -N -p1 -i ../backports/v4.14_compiler_h.patch
patch -s -f -N -p1 -i ../backports/v4.14_saa7146_timer_cast.patch
patch -s -f -N -p1 -i ../backports/v4.14_module_param_call.patch
patch -s -f -N -p1 -i ../backports/v4.12_revert_solo6x10_copykerneluser.patch
patch -s -f -N -p1 -i ../backports/v4.10_sched_signal.patch
1 out of 1 hunk FAILED
The text leading up to this was:
--------------------------
|diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
|index 015e41bd036e..fd61081b47d9 100644
|--- a/drivers/staging/media/lirc/lirc_zilog.c
|+++ b/drivers/staging/media/lirc/lirc_zilog.c
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Makefile:130: recipe for target 'apply_patches' failed
make[2]: *** [apply_patches] Error 1
make[2]: Leaving directory '/home/me/git/clones/media_build/linux'
Makefile:374: recipe for target 'allyesconfig' failed
make[1]: *** [allyesconfig] Error 2

Quoted 8 lines

make[1]: Leaving directory '/home/me/git/clones/media_build/v4l'
Makefile:26: recipe for target 'allyesconfig' failed
make: *** [allyesconfig] Error 2
can't select all drivers at ./build line 525
+ status=29
+ date
Friday 15 December  23:29:17 AEDT 2017
+ [ 0 = 29 ]

I managed to get past the failure above with this change

- media: rc: move ir-lirc-codec.c contents into lirc_dev.c
media: lirc: remove last remnants of lirc kapi
- Sean removed lirc_zilog.c, so it no longer needs patching

backports/v4.10_sched_signal.patch +0 ~~-26~~

@@ -195,19 +195,6 @@ index 0e8025b7b4dd..8c59d4f53200 100644
  #include <linux/delay.h>
  #include <linux/videodev2.h>
  #include <linux/v4l2-dv-timings.h>
-diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
-index db1e7b70c998..fc03068e22b5 100644
---- a/drivers/media/rc/lirc_dev.c
-+++ b/drivers/media/rc/lirc_dev.c
-@@ -18,7 +18,7 @@
- #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
- 
- #include <linux/module.h>
--#include <linux/sched/signal.h>
-+#include <linux/sched.h>
- #include <linux/ioctl.h>
- #include <linux/poll.h>
- #include <linux/mutex.h>
 diff --git a/drivers/media/usb/cpia2/cpia2_core.c b/drivers/media/usb/cpia2/cpia2_core.c
 index 0efba0da0a45..5d8aa65ab40b 100644
 --- a/drivers/media/usb/cpia2/cpia2_core.c

@@ -246,19 +233,6 @@ index 0b5c43f7e020..36bd904946bd 100644
  #include <linux/slab.h>
  #include <linux/interrupt.h>
 
-diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
-index 015e41bd036e..fd61081b47d9 100644
---- a/drivers/staging/media/lirc/lirc_zilog.c
-+++ b/drivers/staging/media/lirc/lirc_zilog.c
-@@ -42,7 +42,7 @@
- #include <linux/module.h>
- #include <linux/kmod.h>
- #include <linux/kernel.h>
--#include <linux/sched/signal.h>
-+#include <linux/sched.h>
- #include <linux/fs.h>
- #include <linux/poll.h>
- #include <linux/string.h>

However it falls over later in a way I don't think I can help with.

...

  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-i2c-core.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-audio.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-encoder.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-video-v4l.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-eeprom.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-main.o
  CC [M]  /home/me/git/clones/media_build/v4l/pvrusb2-hdw.o
/home/me/git/clones/media_build/v4l/pvrusb2-hdw.c: In function 'pvr2_send_request_ex':
/home/me/git/clones/media_build/v4l/pvrusb2-hdw.c:3651:7: error: implicit declaration of function 'usb_urb_ep_type_check' [-Werror=implicit-function-declaration]
   if (usb_urb_ep_type_check(hdw->ctl_write_urb)) {
       ^

Quoted 11 lines

cc1: some warnings being treated as errors
scripts/Makefile.build:258: recipe for target '/home/me/git/clones/media_build/v4l/pvrusb2-hdw.o' failed make[3]: *** [/home/me/git/clones/media_build/v4l/pvrusb2-hdw.o] Error 1
Makefile:1423: recipe for target '_module_/home/me/git/clones/media_build/v4l' failed make[2]: *** [_module_/home/me/git/clones/media_build/v4l] Error 2
make[2]: Leaving directory '/usr/src/linux-headers-4.4.0-103-generic'
Makefile:51: recipe for target 'default' failed
make[1]: *** [default] Error 2
make[1]: Leaving directory '/home/me/git/clones/media_build/v4l'
Makefile:26: recipe for target 'all' failed
make: *** [all] Error 2

Just pushed two patches to media build, in order to address those issues. Here, it is now compiling fine with Kernel 4.4.59.

Thanks,
Mauro

Vincent McIntyre

author

2017-12-17 10:20 UTC #4 lore raw

Quoted 4 lines · Mauro Carvalho Chehab

Just pushed two patches to media build, in order to address those issues. Here, it is now compiling fine with Kernel 4.4.59.

Yep, working again. Thank you for taking the time to sort this out.

Regards
Vince