arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by David Daney <[email protected]>

Suggested-by Rob Herring <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

Signed-off-by Mathieu Malaterre <[email protected]>

---
 arch/arm/boot/dts/exynos3250.dtsi             | 34 ++++++------
 arch/arm/boot/dts/exynos4.dtsi                | 56 +++++++++----------
 arch/arm/boot/dts/exynos4210.dtsi             |  8 +--
 arch/arm/boot/dts/exynos4412-pinctrl.dtsi     |  2 +-
 arch/arm/boot/dts/exynos4412.dtsi             | 22 ++++----
 arch/arm/boot/dts/exynos5.dtsi                | 22 ++++----
 arch/arm/boot/dts/exynos5250.dtsi             | 64 +++++++++++-----------
 arch/arm/boot/dts/exynos5260.dtsi             | 26 ++++-----
 arch/arm/boot/dts/exynos5420.dtsi             | 78 +++++++++++++--------------
 arch/arm/boot/dts/exynos5422-odroid-core.dtsi |  2 +-
 arch/arm/boot/dts/exynos5440.dtsi             | 14 ++---
 arch/arm/boot/dts/s3c2416.dtsi                |  8 +--
 12 files changed, 168 insertions(+), 168 deletions(-)

arch/arm/boot/dts/exynos3250.dtsi +0 -0

index 2bd3872221a1..8d47571b3984 100644

Quoted 25 lines · Mathieu Malaterre

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

Quoted 5 lines

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by David Daney <[email protected]>

Suggested-by Rob Herring <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

Ack was for different patchset, touching only three files...

Quoted 21 lines

Signed-off-by Mathieu Malaterre <[email protected]>

---
 arch/arm/boot/dts/exynos3250.dtsi             | 34 ++++++------
 arch/arm/boot/dts/exynos4.dtsi                | 56 +++++++++----------
 arch/arm/boot/dts/exynos4210.dtsi             |  8 +--
 arch/arm/boot/dts/exynos4412-pinctrl.dtsi     |  2 +-
 arch/arm/boot/dts/exynos4412.dtsi             | 22 ++++----
 arch/arm/boot/dts/exynos5.dtsi                | 22 ++++----
 arch/arm/boot/dts/exynos5250.dtsi             | 64 +++++++++++-----------
 arch/arm/boot/dts/exynos5260.dtsi             | 26 ++++-----
 arch/arm/boot/dts/exynos5420.dtsi             | 78 +++++++++++++--------------
 arch/arm/boot/dts/exynos5422-odroid-core.dtsi |  2 +-
 arch/arm/boot/dts/exynos5440.dtsi             | 14 ++---
 arch/arm/boot/dts/s3c2416.dtsi                |  8 +--
 12 files changed, 168 insertions(+), 168 deletions(-)

arch/arm/boot/dts/exynos3250.dtsi +0 -0

index 2bd3872221a1..8d47571b3984 100644

arch/arm/boot/dts/exynos3250.dtsi line 167

Quoted 5 lines

arch/arm/boot/dts/exynos3250.dtsi +1 -1

@@ -164,31 +164,31 @@
                        syscon = <&pmu_system_controller>;
                };
 
-               pd_cam: cam-power-domain at 10023C00 {
+               pd_cam: cam-power-domain at 10023c00 {

This is not related to this patch and it was not present in the version I acked. I also already fixed this here:
https://patchwork.kernel.org/patch/10113323/

There is no changelog explaining the difference in patches. Original patch was okay, why changing it?

Quoted 26 lines · Krzysztof Kozlowski

Quoted 25 lines · Mathieu Malaterre

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

Quoted 7 lines

Quoted 5 lines

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by David Daney <[email protected]>

Suggested-by Rob Herring <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

Ack was for different patchset, touching only three files...

So sorry, when I read your email:

https://lkml.org/lkml/2017/12/15/152

I assumed you meant for all the Exynos* and S3C* DTS files, but I did not check carefully which files were touched originally.

Quoted 31 lines

Quoted 21 lines

Signed-off-by Mathieu Malaterre <[email protected]>

---
 arch/arm/boot/dts/exynos3250.dtsi             | 34 ++++++------
 arch/arm/boot/dts/exynos4.dtsi                | 56 +++++++++----------
 arch/arm/boot/dts/exynos4210.dtsi             |  8 +--
 arch/arm/boot/dts/exynos4412-pinctrl.dtsi     |  2 +-
 arch/arm/boot/dts/exynos4412.dtsi             | 22 ++++----
 arch/arm/boot/dts/exynos5.dtsi                | 22 ++++----
 arch/arm/boot/dts/exynos5250.dtsi             | 64 +++++++++++-----------
 arch/arm/boot/dts/exynos5260.dtsi             | 26 ++++-----
 arch/arm/boot/dts/exynos5420.dtsi             | 78 +++++++++++++--------------
 arch/arm/boot/dts/exynos5422-odroid-core.dtsi |  2 +-
 arch/arm/boot/dts/exynos5440.dtsi             | 14 ++---
 arch/arm/boot/dts/s3c2416.dtsi                |  8 +--
 12 files changed, 168 insertions(+), 168 deletions(-)

arch/arm/boot/dts/exynos3250.dtsi +0 -0

index 2bd3872221a1..8d47571b3984 100644

arch/arm/boot/dts/exynos3250.dtsi line 167

Quoted 5 lines

arch/arm/boot/dts/exynos3250.dtsi +1 -1

@@ -164,31 +164,31 @@
                        syscon = <&pmu_system_controller>;
                };
 
-               pd_cam: cam-power-domain at 10023C00 {
+               pd_cam: cam-power-domain at 10023c00 {

This is not related to this patch and it was not present in the version I acked. I also already fixed this here:
https://patchwork.kernel.org/patch/10113323/

Quoted 2 lines

There is no changelog explaining the difference in patches. Original patch was okay, why changing it?

Accept my sincere apologizes I really messed this series. I discover my original ARM patch did not apply lower case to all unit-address equally, so I added at last minute a sed expression to make all unit-address lower case.

I guess you can just drop this one for now.

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.*\) {/@0\1 {/g" {} +

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by David Daney <[email protected]>

Suggested-by Rob Herring <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

Signed-off-by Mathieu Malaterre <[email protected]>

---
v2: intermediate patch contained unrelated changes. restrict to S3 and Exynos*

 arch/arm/boot/dts/exynos5420.dtsi | 36 ++++++++++++++++++------------------
 arch/arm/boot/dts/s3c2416.dtsi    |  8 ++++----
 2 files changed, 22 insertions(+), 22 deletions(-)

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.*\) {/@0\1 {/g" {} +

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by David Daney <[email protected]>

Suggested-by Rob Herring <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

Signed-off-by Mathieu Malaterre <[email protected]>

---
v2: intermediate patch contained unrelated changes. restrict to S3 and Exynos*

 arch/arm/boot/dts/exynos5420.dtsi | 36 ++++++++++++++++++------------------
 arch/arm/boot/dts/s3c2416.dtsi    |  8 ++++----
 2 files changed, 22 insertions(+), 22 deletions(-)

arch/arm/boot/dts/exynos5420.dtsi +18 -18

index 2f3cb2a97f71..633952a96427 100644
@@ -761,7 +761,7 @@
 			#include "exynos5420-tmu-sensor-conf.dtsi"
 		};
 
-		sysmmu_g2dr: sysmmu at 0x10A60000 {
+		sysmmu_g2dr: sysmmu at 10a60000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x10A60000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -771,7 +771,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_g2dw: sysmmu at 0x10A70000 {
+		sysmmu_g2dw: sysmmu at 10a70000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x10A70000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -781,7 +781,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_tv: sysmmu at 0x14650000 {
+		sysmmu_tv: sysmmu at 14650000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x14650000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -792,7 +792,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_gscl0: sysmmu at 0x13E80000 {
+		sysmmu_gscl0: sysmmu at 13e80000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x13E80000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -803,7 +803,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_gscl1: sysmmu at 0x13E90000 {
+		sysmmu_gscl1: sysmmu at 13e90000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x13E90000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -814,7 +814,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_scaler0r: sysmmu at 0x12880000 {
+		sysmmu_scaler0r: sysmmu at 12880000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x12880000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -824,7 +824,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_scaler1r: sysmmu at 0x12890000 {
+		sysmmu_scaler1r: sysmmu at 12890000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x12890000 0x1000>;
 			interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;

@@ -833,7 +833,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_scaler2r: sysmmu at 0x128A0000 {
+		sysmmu_scaler2r: sysmmu at 128a0000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x128A0000 0x1000>;
 			interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;

@@ -842,7 +842,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_scaler0w: sysmmu at 0x128C0000 {
+		sysmmu_scaler0w: sysmmu at 128c0000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x128C0000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -852,7 +852,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_scaler1w: sysmmu at 0x128D0000 {
+		sysmmu_scaler1w: sysmmu at 128d0000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x128D0000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -862,7 +862,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_scaler2w: sysmmu at 0x128E0000 {
+		sysmmu_scaler2w: sysmmu at 128e0000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x128E0000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -872,7 +872,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_rotator: sysmmu at 0x11D40000 {
+		sysmmu_rotator: sysmmu at 11d40000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x11D40000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -882,7 +882,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_jpeg0: sysmmu at 0x11F10000 {
+		sysmmu_jpeg0: sysmmu at 11f10000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x11F10000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -892,7 +892,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_jpeg1: sysmmu at 0x11F20000 {
+		sysmmu_jpeg1: sysmmu at 11f20000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x11F20000 0x1000>;
 			interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;

@@ -901,7 +901,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_mfc_l: sysmmu at 0x11200000 {
+		sysmmu_mfc_l: sysmmu at 11200000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x11200000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -912,7 +912,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_mfc_r: sysmmu at 0x11210000 {
+		sysmmu_mfc_r: sysmmu at 11210000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x11210000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -923,7 +923,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_fimd1_0: sysmmu at 0x14640000 {
+		sysmmu_fimd1_0: sysmmu at 14640000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x14640000 0x1000>;
 			interrupt-parent = <&combiner>;

@@ -934,7 +934,7 @@
 			#iommu-cells = <0>;
 		};
 
-		sysmmu_fimd1_1: sysmmu at 0x14680000 {
+		sysmmu_fimd1_1: sysmmu at 14680000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x14680000 0x1000>;
 			interrupt-parent = <&combiner>;

arch/arm/boot/dts/s3c2416.dtsi +4 -4

index 3c7385cab248..46cf85f3c18b 100644
@@ -30,7 +30,7 @@
 		compatible = "samsung,s3c2416-irq";
 	};
 
-	clocks: clock-controller at 0x4c000000 {
+	clocks: clock-controller at 4c000000 {
 		compatible = "samsung,s3c2416-clock";
 		reg = <0x4c000000 0x40>;
 		#clock-cells = <1>;

@@ -69,7 +69,7 @@
 				<&clocks SCLK_UART>;
 	};
 
-	uart_3: serial at 5000C000 {
+	uart_3: serial at 5000c000 {
 		compatible = "samsung,s3c2440-uart";
 		reg = <0x5000C000 0x4000>;
 		interrupts = <1 18 24 4>, <1 18 25 4>;

@@ -80,7 +80,7 @@
 		status = "disabled";
 	};
 
-	sdhci_1: sdhci at 4AC00000 {
+	sdhci_1: sdhci at 4ac00000 {
 		compatible = "samsung,s3c6410-sdhci";
 		reg = <0x4AC00000 0x100>;
 		interrupts = <0 0 21 3>;

@@ -91,7 +91,7 @@
 		status = "disabled";
 	};
 
-	sdhci_0: sdhci at 4A800000 {
+	sdhci_0: sdhci at 4a800000 {
 		compatible = "samsung,s3c6410-sdhci";
 		reg = <0x4A800000 0x100>;
 		interrupts = <0 0 20 3>;

Signature · 1 line

2.11.0

Quoted 7 lines · Mathieu Malaterre

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Quoted 1 line

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

... and dropped because apparently it does not work in all cases:

arch/arm/boot/dts/exynos5422-odroidhc1.dtb: Warning (unit_address_format): /firmware at 02073000: unit name should not have leading 0s

Can you check why these were not fixed?

Best regards,
Krzysztof

Quoted 239 lines

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.*\) {/@0\1 {/g" {} +

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by David Daney <[email protected]>

Suggested-by Rob Herring <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

Signed-off-by Mathieu Malaterre <[email protected]>

---
v2: intermediate patch contained unrelated changes. restrict to S3 and Exynos*

 arch/arm/boot/dts/exynos5420.dtsi | 36 ++++++++++++++++++------------------
 arch/arm/boot/dts/s3c2416.dtsi    |  8 ++++----
 2 files changed, 22 insertions(+), 22 deletions(-)

arch/arm/boot/dts/exynos5420.dtsi +18 -18

index 2f3cb2a97f71..633952a96427 100644
@@ -761,7 +761,7 @@
                      #include "exynos5420-tmu-sensor-conf.dtsi"
              };
 
-             sysmmu_g2dr: sysmmu at 0x10A60000 {
+             sysmmu_g2dr: sysmmu at 10a60000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x10A60000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -771,7 +771,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_g2dw: sysmmu at 0x10A70000 {
+             sysmmu_g2dw: sysmmu at 10a70000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x10A70000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -781,7 +781,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_tv: sysmmu at 0x14650000 {
+             sysmmu_tv: sysmmu at 14650000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x14650000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -792,7 +792,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_gscl0: sysmmu at 0x13E80000 {
+             sysmmu_gscl0: sysmmu at 13e80000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x13E80000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -803,7 +803,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_gscl1: sysmmu at 0x13E90000 {
+             sysmmu_gscl1: sysmmu at 13e90000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x13E90000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -814,7 +814,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_scaler0r: sysmmu at 0x12880000 {
+             sysmmu_scaler0r: sysmmu at 12880000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x12880000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -824,7 +824,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_scaler1r: sysmmu at 0x12890000 {
+             sysmmu_scaler1r: sysmmu at 12890000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x12890000 0x1000>;
                      interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;

@@ -833,7 +833,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_scaler2r: sysmmu at 0x128A0000 {
+             sysmmu_scaler2r: sysmmu at 128a0000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x128A0000 0x1000>;
                      interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;

@@ -842,7 +842,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_scaler0w: sysmmu at 0x128C0000 {
+             sysmmu_scaler0w: sysmmu at 128c0000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x128C0000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -852,7 +852,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_scaler1w: sysmmu at 0x128D0000 {
+             sysmmu_scaler1w: sysmmu at 128d0000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x128D0000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -862,7 +862,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_scaler2w: sysmmu at 0x128E0000 {
+             sysmmu_scaler2w: sysmmu at 128e0000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x128E0000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -872,7 +872,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_rotator: sysmmu at 0x11D40000 {
+             sysmmu_rotator: sysmmu at 11d40000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x11D40000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -882,7 +882,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_jpeg0: sysmmu at 0x11F10000 {
+             sysmmu_jpeg0: sysmmu at 11f10000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x11F10000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -892,7 +892,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_jpeg1: sysmmu at 0x11F20000 {
+             sysmmu_jpeg1: sysmmu at 11f20000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x11F20000 0x1000>;
                      interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;

@@ -901,7 +901,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_mfc_l: sysmmu at 0x11200000 {
+             sysmmu_mfc_l: sysmmu at 11200000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x11200000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -912,7 +912,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_mfc_r: sysmmu at 0x11210000 {
+             sysmmu_mfc_r: sysmmu at 11210000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x11210000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -923,7 +923,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_fimd1_0: sysmmu at 0x14640000 {
+             sysmmu_fimd1_0: sysmmu at 14640000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x14640000 0x1000>;
                      interrupt-parent = <&combiner>;

@@ -934,7 +934,7 @@
                      #iommu-cells = <0>;
              };
 
-             sysmmu_fimd1_1: sysmmu at 0x14680000 {
+             sysmmu_fimd1_1: sysmmu at 14680000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x14680000 0x1000>;
                      interrupt-parent = <&combiner>;

arch/arm/boot/dts/s3c2416.dtsi +4 -5

index 3c7385cab248..46cf85f3c18b 100644
@@ -30,7 +30,7 @@
              compatible = "samsung,s3c2416-irq";
      };
 
-     clocks: clock-controller at 0x4c000000 {
+     clocks: clock-controller at 4c000000 {
              compatible = "samsung,s3c2416-clock";
              reg = <0x4c000000 0x40>;
              #clock-cells = <1>;

@@ -69,7 +69,7 @@
                              <&clocks SCLK_UART>;
      };
 
-     uart_3: serial at 5000C000 {
+     uart_3: serial at 5000c000 {
              compatible = "samsung,s3c2440-uart";
              reg = <0x5000C000 0x4000>;
              interrupts = <1 18 24 4>, <1 18 25 4>;

@@ -80,7 +80,7 @@
              status = "disabled";
      };
 
-     sdhci_1: sdhci at 4AC00000 {
+     sdhci_1: sdhci at 4ac00000 {
              compatible = "samsung,s3c6410-sdhci";
              reg = <0x4AC00000 0x100>;
              interrupts = <0 0 21 3>;

@@ -91,7 +91,7 @@
              status = "disabled";
      };
 
-     sdhci_0: sdhci at 4A800000 {
+     sdhci_0: sdhci at 4a800000 {
              compatible = "samsung,s3c6410-sdhci";
              reg = <0x4A800000 0x100>;
              interrupts = <0 0 20 3>;
--

2.11.0

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.*\) {/@\1 {/g" {} +

Quoted 7 lines · Mathieu Malaterre

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Quoted 5 lines

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.*\) {/@\1 {/g" {} +

The firmware node is fixed but in my case the command is doing much more:

(quoted diff) +2 -2

-                       smp-sysram at 0 {
+                       smp-sysram@ {
 
-                       port at 0 {
+                       port@ {

Best regards,
Krzysztof

Quoted 14 lines · Krzysztof Kozlowski

Quoted 12 lines · Mathieu Malaterre

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.*\) {/@\1 {/g" {} +

Quoted 2 lines

The firmware node is fixed but in my case the command is doing much more:

Looks like I cannot copy/paste correctly, meant to say:

find . -type f \( -iname "*.dts" -o -iname "*.dtsi" \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.\+\) {/@\1 {/g" {} +

Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.*\) {/@\1 {/g" {} +

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by David Daney <[email protected]>

Suggested-by Rob Herring <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

Signed-off-by Mathieu Malaterre <[email protected]>

---
v3: remove extra 0 preventing correct fixup
v2: intermediate patch contained unrelated changes. restrict to S3 and Exynos*

 arch/arm/boot/dts/exynos5420.dtsi             | 36 +++++++++++++--------------
 arch/arm/boot/dts/exynos5422-odroid-core.dtsi |  2 +-
 arch/arm/boot/dts/s3c2416.dtsi                |  8 +++---
 3 files changed, 23 insertions(+), 23 deletions(-)