Skip to contentSkip to conversation

rpcbind.service: Not pulling the rpcbind.target

PATCH In review Steve Dickson 2 participants 3 messages Dec 15, 2017

Subsystems (2)
NFS client NFS server
lore
Share & tools
lore

Steve Dickson

author
#0 lore raw

PATCH v2 1/1 rpcbind.service: Not pulling the rpcbind.target

According to systemd.special(7) manpage:

rpcbind.target
The portmapper/rpcbind pulls in this target and orders itself before it, to indicate its availability. systemd automatically adds dependencies of type After= for this target unit to all SysV init script service units with an LSB header referring to the "$portmap" facility.

Signed-off-by Steve Dickson <[email protected]>
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1431574
---
 systemd/rpcbind.service.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
systemd/rpcbind.service.in +2 -2
index f8cfa9f..9dbc82c 100644
@@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
 
 # Make sure we use the IP addresses listed for
 # rpcbind.socket, no matter how this unit is started.
-Wants=rpcbind.socket
-After=rpcbind.socket
+Requires=rpcbind.socket
+Before=rpcbind.target
 
 [Service]
 Type=notify
Signature · 1 line
2.14.3
#1 lore raw
Quoted 20 lines · Steve Dickson

According to systemd.special(7) manpage:

rpcbind.target
The portmapper/rpcbind pulls in this target and orders itself before it, to indicate its availability. systemd automatically adds dependencies of type After= for this target unit to all SysV init script service units with an LSB header referring to the "$portmap" facility.

Signed-off-by Steve Dickson <[email protected]>
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1431574
---
 systemd/rpcbind.service.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
systemd/rpcbind.service.in +0 -0
index f8cfa9f..9dbc82c 100644

systemd/rpcbind.service.in RequiresMountsFor=@statedir@ · line 10

Quoted 7 lines
systemd/rpcbind.service.in +2 -2
@@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
 
 # Make sure we use the IP addresses listed for
 # rpcbind.socket, no matter how this unit is started.
-Wants=rpcbind.socket
-After=rpcbind.socket
+Requires=rpcbind.socket
+Before=rpcbind.target

You should still pull in rpcbind.target as the man page says. i.e. "Wants=rpcbind.target" really should be there.

Lennart

Signature · 1 line
Lennart Poettering, Red Hat
author
#2 lore raw
Quoted 23 lines · Lennart Poettering
Quoted 21 lines · Steve Dickson

According to systemd.special(7) manpage:

rpcbind.target
The portmapper/rpcbind pulls in this target and orders itself before it, to indicate its availability. systemd automatically adds dependencies of type After= for this target unit to all SysV init script service units with an LSB header referring to the "$portmap" facility.

Signed-off-by Steve Dickson <[email protected]>
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1431574
---
 systemd/rpcbind.service.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
systemd/rpcbind.service.in +0 -0
index f8cfa9f..9dbc82c 100644
@@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
Quoted 9 lines

systemd/rpcbind.service.in RequiresMountsFor=@statedir@ · line 10

Quoted 6 lines
systemd/rpcbind.service.in +2 -2
 # Make sure we use the IP addresses listed for
 # rpcbind.socket, no matter how this unit is started.
-Wants=rpcbind.socket
-After=rpcbind.socket
+Requires=rpcbind.socket
+Before=rpcbind.target

You should still pull in rpcbind.target as the man page says. i.e. "Wants=rpcbind.target" really should be there.

Duly noted... and changed!

thanks!

steved.

Quoted 3 lines

Lennart