Skip to contentSkip to conversation

janus-gateway: add libcurl check.

PATCH New Adam Duskett 2 participants 2 messages Dec 15, 2017 – Dec 16, 2017

lore
Share & tools
lore

Adam Duskett

author
#0 lore raw

PATCH 1/1 janus-gateway: add libcurl check.

The streaming protocol works without libcurl via RTP, but if a user wishes to stream via RTSP or use the turn-rest api, libcurl must be built first.

Signed-off-by Adam Duskett <[email protected]>
---
 package/janus-gateway/Config.in        | 6 ++++--
 package/janus-gateway/janus-gateway.mk | 4 ++++
 2 files changed, 8 insertions(+), 2 deletions(-)
package/janus-gateway/Config.in +4 -2
index 5bd4e9586b..130bb9d57a 100644
@@ -35,8 +35,10 @@ config BR2_PACKAGE_JANUS_SIP_GATEWAY
 
 config  BR2_PACKAGE_JANUS_STREAMING
 	bool "streaming"
-	# SO_REUSEPORT
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
+	help
+	  Enable streaming plugin.
+	  Note: For RTSP streaming support, libcurl must be selected.
 
 comment "streaming plugin needs a toolchain w/ headers >= 3.9"
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9

@@ -90,7 +92,7 @@ config BR2_PACKAGE_JANUS_WEBSOCKETS
 	depends on BR2_USE_MMU
 	select BR2_PACKAGE_LIBWEBSOCKETS
 
-endif
+endif #BR2_PACKAGE_JANUS_GATEWAY
 
 comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
 	depends on BR2_USE_MMU
package/janus-gateway/janus-gateway.mk +4 -0
index bf3e590ac5..ea2ff6fa89 100644
@@ -26,6 +26,10 @@ JANUS_GATEWAY_CONF_OPTS = \
 	--disable-data-channels \
 	--disable-sample-event-handler
 
+ifeq ($(BR2_PACKAGE_LIBCURL),y)
+JANUS_GATEWAY_DEPENDENCIES += libcurl
+endif
+
 ifeq ($(BR2_PACKAGE_JANUS_AUDIO_BRIDGE),y)
 JANUS_GATEWAY_DEPENDENCIES += opus
 JANUS_GATEWAY_CONF_OPTS += --enable-plugin-audiobridge
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 janus-gateway: add libcurl check.

Hello,

package/janus-gateway/Config.in config BR2_PACKAGE_JANUS_SIP_GATEWAY · line 38

Quoted 3 lines · Adam Duskett

config BR2_PACKAGE_JANUS_STREAMING

package/janus-gateway/Config.in +0 -1
 	bool "streaming"
-	# SO_REUSEPORT

Why is this removed ?

package/janus-gateway/Config.in config BR2_PACKAGE_JANUS_WEBSOCKETS · line 95

Quoted 13 lines
package/janus-gateway/Config.in +4 -1
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
+	help
+	  Enable streaming plugin.
+	  Note: For RTSP streaming support, libcurl must be selected.
 
 comment "streaming plugin needs a toolchain w/ headers >= 3.9"
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9

@@ -90,7 +92,7 @@ config BR2_PACKAGE_JANUS_WEBSOCKETS
 	depends on BR2_USE_MMU
 	select BR2_PACKAGE_LIBWEBSOCKETS
 
-endif
+endif #BR2_PACKAGE_JANUS_GATEWAY

This change is unrelated.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com