ARM: dts: am43xx: Fix inverted DS0_PULL_UP_DOWN_EN macro
Subsystems (2)
PATCH 1/1 ARM: dts: am43xx: Fix inverted DS0_PULL_UP_DOWN_EN macro
Due to a mistake in documentation the DS0_PULL_UP_DOWN_EN macro was mistakenly defined as an active high bit, however setting the bit actually disables the internal pull resistor on the pin, so correct this macro and introduce a new DS0_PULL_UP_DOWN_DIS macro with the proper bit value set now that the documentation has been updated.
Change based on AM437x Techninal Reference Manual SPRUHL7G Revised June 2017 Section 7.2.1.
--- include/dt-bindings/pinctrl/am43xx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/dt-bindings/pinctrl/am43xx.h +2 -1
@@ -25,7 +25,8 @@#define DS0_FORCE_OFF_MODE (1 << 24)#define DS0_INPUT (1 << 25)#define DS0_FORCE_OUT_HIGH (1 << 26) -#define DS0_PULL_UP_DOWN_EN (1 << 27) +#define DS0_PULL_UP_DOWN_EN (0 << 27) +#define DS0_PULL_UP_DOWN_DIS (1 << 27)#define DS0_PULL_UP_SEL (1 << 28)#define WAKEUP_ENABLE (1 << 29)
Signature · 1 line
2.15.1
PATCH 1/1 ARM: dts: am43xx: Fix inverted DS0_PULL_UP_DOWN_EN macro
Quoted 8 lines · Dave Gerlach
Due to a mistake in documentation the
DS0_PULL_UP_DOWN_ENmacro was mistakenly defined as an active high bit, however setting the bit actually disables the internal pull resistor on the pin, so correct this macro and introduce a newDS0_PULL_UP_DOWN_DISmacro with the proper bit value set now that the documentation has been updated.Change based on AM437x Techninal Reference Manual SPRUHL7G Revised June 2017 Section 7.2.1.
Applying into omap-for-v4.16/dt thanks,
Tony