iqvlinux: bump to version 1.2.0.3
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
This package is really annoying since the archive name doesn't contain the version. Use a small trick to save it with a better name. Also add hashes for license files.
---
Changes v1->v2:
- Move comment about the patch, in package/iqvlinux/Config.in, to the next commit.
- Use a small trick to save the source file with a better name.
--- package/iqvlinux/Config.in | 2 +- package/iqvlinux/iqvlinux.hash | 9 +++++---- package/iqvlinux/iqvlinux.mk | 17 ++++++++++++++--- 3 files changed, 20 insertions(+), 8 deletions(-)
package/iqvlinux/Config.in +1 -1
@@ -12,7 +12,7 @@ config BR2_PACKAGE_IQVLINUX Note: This driver requires PCI support to be enabled (i.e. CONFIG_PCI). - http://sourceforge.net/projects/e1000/files/iqvlinux/ + https://sourceforge.net/projects/e1000/files/iqvlinux/ comment "iqvlinux needs a Linux kernel to be built" depends on !BR2_LINUX_KERNEL
package/iqvlinux/iqvlinux.hash +5 -4
@@ -1,5 +1,6 @@ -# From http://sourceforge.net/projects/e1000/files/iqvlinux/1.1.5.3/ -sha1 bd94416e4364015dbbd78a22e51080bf7ea81fac iqvlinux.tar.gz -md5 fb6a2a4dc122d39070fcb06985c97a05 iqvlinux.tar.gz # locally computed -sha256 8cb19f3bfe040100a13bb2d05cb2b54f2b259e55cef23f8cc5aa6f2f31e98bec iqvlinux.tar.gz +sha256 4020a661940ba6d50f24654b90a41280eb8eccf00061fe6d105c654d3d97d551 iqvlinux-1.2.0.3.tar.gz +sha256 386086e232db4708770f717595d4f83188f776aa6e7313cd12fb039e869f494b COPYING +sha256 beded926a8f18aad5d911daf581759e2b25697588034d2b29033ae1a929506ff src/linux/driver/files.txt +sha256 ecf93b9b739fc82f7b87b34f8c6411dfdd271234af2fe45212293d9df2b654b3 inc/linux/files.txt +sha256 0a309350c1b32be72479e8fe08f7f6bbbad2e8c3d9a1cbcad3d482ea48a236ad inc/files.txt
package/iqvlinux/iqvlinux.mk +14 -3
@@ -4,9 +4,8 @@ # ################################################################################ -IQVLINUX_VERSION = 1.1.5.3 -IQVLINUX_SITE = http://sourceforge.net/projects/e1000/files/iqvlinux/$(IQVLINUX_VERSION) -IQVLINUX_SOURCE = iqvlinux.tar.gz +IQVLINUX_VERSION = 1.2.0.3 +IQVLINUX_SITE = https://downloads.sourceforge.net/project/e1000/iqvlinux/$(IQVLINUX_VERSION) IQVLINUX_LICENSE = GPL-2.0, BSD-3-Clause IQVLINUX_LICENSE_FILES = \
@@ -17,5 +16,17 @@ IQVLINUX_MODULE_MAKE_OPTS = NALDIR=$(@D) KSRC=$(LINUX_DIR) CC=$(TARGET_CC) IQVLINUX_MODULE_SUBDIRS = src/linux/driver +# This package is really annoying since the archive name doesn't contain the +# version. Use a small trick to save it with a better name. +define IQVLINUX_DOWNLOAD + $(EXTRA_ENV) $(DL_WRAPPER) -b wget \ + -o $(DL_DIR)/$(IQVLINUX_SOURCE) \ + -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + -- \ + $(IQVLINUX_SITE)/iqvlinux.tar.gz +endef + +IQVLINUX_PRE_DOWNLOAD_HOOKS = IQVLINUX_DOWNLOAD + $(eval $(kernel-module)) $(eval $(generic-package))
Signature · 1 line
2.14.3
PATCH v2 2/2 iqvlinux: add patch to support Linux kernel 4.12 and later
Tested on machines with four NIC models:
- Intel(R) Ethernet Connection X553 10 GbE SFP+
- Intel(R) Ethernet Connection X553 1 GbE
- Intel(R) Ethernet Connection I354
- Intel(R) I210 Gigabit Network Connection
---
Changes v1->v2
- Move comment about the patch, in package/iqvlinux/Config.in, to the this commit.
--- .../0001-Support-Linux-kernel-4.12-and-later.patch | 66 ++++++++++++++++++++++ package/iqvlinux/Config.in | 7 ++- 2 files changed, 71 insertions(+), 2 deletions(-) create mode 100644 package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patch
package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patch new file +66 -0
@@ -0,0 +1,66 @@ +From 517d70780b903caa41ee93adbbb9bb985da23a29 Mon Sep 17 00:00:00 2001 +From: Carlos Santos <[email protected]> +Date: Tue, 12 Dec 2017 13:40:44 -0200 +Subject: [PATCH] Support Linux kernel 4.12 and later + +Signed-off-by: Carlos Santos <[email protected]> +--- + src/linux/driver/linuxdrivermemory_i.c | 5 +++++ + src/linux/driver/linuxdriveros_i.c | 5 +++++ + src/linux/driver/linuxnaldriver.c | 5 +++++ + 3 files changed, 15 insertions(+) + +diff --git a/src/linux/driver/linuxdrivermemory_i.c b/src/linux/driver/linuxdrivermemory_i.c +index bdf1d42..53366d7 100644 +--- a/src/linux/driver/linuxdrivermemory_i.c ++++ b/src/linux/driver/linuxdrivermemory_i.c +@@ -49,7 +49,12 @@ + #include <linux/errno.h> + #include <linux/fs.h> + #include <linux/mm.h> ++#include <linux/version.h> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0) ++#include <linux/uaccess.h> ++#else + #include <asm/uaccess.h> ++#endif + #include <linux/pci.h> + #include <linux/delay.h> + +diff --git a/src/linux/driver/linuxdriveros_i.c b/src/linux/driver/linuxdriveros_i.c +index 653bec9..43df25e 100644 +--- a/src/linux/driver/linuxdriveros_i.c ++++ b/src/linux/driver/linuxdriveros_i.c +@@ -49,7 +49,12 @@ + #include <linux/errno.h> + #include <linux/fs.h> + #include <linux/mm.h> ++#include <linux/version.h> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0) ++#include <linux/uaccess.h> ++#else + #include <asm/uaccess.h> ++#endif + #include <linux/pci.h> + #include <linux/delay.h> + +diff --git a/src/linux/driver/linuxnaldriver.c b/src/linux/driver/linuxnaldriver.c +index 93c2f80..c1ddbcf 100644 +--- a/src/linux/driver/linuxnaldriver.c ++++ b/src/linux/driver/linuxnaldriver.c +@@ -39,7 +39,12 @@ + #include <linux/fs.h> + #include <linux/mm.h> + #include <linux/version.h> ++#include <linux/version.h> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0) ++#include <linux/uaccess.h> ++#else + #include <asm/uaccess.h> ++#endif + #include "naltypes.h" + #include "nalioctl.h" + #include "linuxnaldriver.h" +-- +2.14.3 +
package/iqvlinux/Config.in +5 -2
@@ -2,8 +2,11 @@ config BR2_PACKAGE_IQVLINUX bool "iqvlinux" depends on BR2_LINUX_KERNEL help - Intel Ethernet Adapter Debug Driver for Linux (iqvlinux), - which supports kernel versions 2.6.x up through 4.0.x. + Intel Ethernet Adapter Debug Driver for Linux (iqvlinux). + + Officially supports kernel versions 2.6.x up through 4.0.x but + the Buildroot package contains a patch to allow it to be built + on newer kernel versions. This debug driver supports all Intel's networking Tools based on the SDK version 2.19.36.0 or higher which support Intel
Signature · 1 line
2.14.3
PATCH v2 2/2 iqvlinux: add patch to support Linux kernel 4.12 and later
________________________________________
Van: buildrootNamensCarlos Santos
Verzonden: vrijdag 15 december 2017 16:38:30 (UTC+01:00) Amsterdam, Berlijn, Bern, Rome, Stockholm, Wenen
Aan: buildroot at buildroot.org
CC: Romain Naour
Onderwerp: [Buildroot] [PATCH v2 2/2] iqvlinux: add patch to support Linux kernel 4.12 and later
Tested on machines with four NIC models:
- Intel(R) Ethernet Connection X553 10 GbE SFP+
- Intel(R) Ethernet Connection X553 1 GbE
- Intel(R) Ethernet Connection I354
- Intel(R) I210 Gigabit Network Connection
---
Changes v1->v2
- Move comment about the patch, in package/iqvlinux/Config.in, to the this commit.
--- .../0001-Support-Linux-kernel-4.12-and-later.patch | 66 ++++++++++++++++++++++ package/iqvlinux/Config.in | 7 ++- 2 files changed, 71 insertions(+), 2 deletions(-) create mode 100644 package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patch
package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patch new file +66 -0
@@ -0,0 +1,66 @@ +From 517d70780b903caa41ee93adbbb9bb985da23a29 Mon Sep 17 00:00:00 2001 +From: Carlos Santos <[email protected]> +Date: Tue, 12 Dec 2017 13:40:44 -0200 +Subject: [PATCH] Support Linux kernel 4.12 and later + +Signed-off-by: Carlos Santos <[email protected]> +--- + src/linux/driver/linuxdrivermemory_i.c | 5 +++++ + src/linux/driver/linuxdriveros_i.c | 5 +++++ + src/linux/driver/linuxnaldriver.c | 5 +++++ + 3 files changed, 15 insertions(+) + +diff --git a/src/linux/driver/linuxdrivermemory_i.c b/src/linux/driver/linuxdrivermemory_i.c +index bdf1d42..53366d7 100644 +--- a/src/linux/driver/linuxdrivermemory_i.c ++++ b/src/linux/driver/linuxdrivermemory_i.c +@@ -49,7 +49,12 @@ + #include <linux/errno.h> + #include <linux/fs.h> + #include <linux/mm.h> ++#include <linux/version.h> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0) ++#include <linux/uaccess.h> ++#else + #include <asm/uaccess.h> ++#endif + #include <linux/pci.h> + #include <linux/delay.h> + +diff --git a/src/linux/driver/linuxdriveros_i.c b/src/linux/driver/linuxdriveros_i.c +index 653bec9..43df25e 100644 +--- a/src/linux/driver/linuxdriveros_i.c ++++ b/src/linux/driver/linuxdriveros_i.c +@@ -49,7 +49,12 @@ + #include <linux/errno.h> + #include <linux/fs.h> + #include <linux/mm.h> ++#include <linux/version.h> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0) ++#include <linux/uaccess.h> ++#else + #include <asm/uaccess.h> ++#endif + #include <linux/pci.h> + #include <linux/delay.h> + +diff --git a/src/linux/driver/linuxnaldriver.c b/src/linux/driver/linuxnaldriver.c +index 93c2f80..c1ddbcf 100644 +--- a/src/linux/driver/linuxnaldriver.c ++++ b/src/linux/driver/linuxnaldriver.c +@@ -39,7 +39,12 @@ + #include <linux/fs.h> + #include <linux/mm.h> + #include <linux/version.h> ++#include <linux/version.h> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0) ++#include <linux/uaccess.h> ++#else + #include <asm/uaccess.h> ++#endif + #include "naltypes.h" + #include "nalioctl.h" + #include "linuxnaldriver.h" +-- +2.14.3 +
package/iqvlinux/Config.in +5 -2
@@ -2,8 +2,11 @@ config BR2_PACKAGE_IQVLINUX bool "iqvlinux" depends on BR2_LINUX_KERNEL help - Intel Ethernet Adapter Debug Driver for Linux (iqvlinux), - which supports kernel versions 2.6.x up through 4.0.x. + Intel Ethernet Adapter Debug Driver for Linux (iqvlinux). + + Officially supports kernel versions 2.6.x up through 4.0.x but + the Buildroot package contains a patch to allow it to be built + on newer kernel versions. This debug driver supports all Intel's networking Tools based on the SDK version 2.19.36.0 or higher which support Intel
--
2.14.3
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
In reply to Carlos Santos________________________________________
Van: buildrootNamensCarlos Santos
Verzonden: vrijdag 15 december 2017 16:38:29 (UTC+01:00) Amsterdam, Berlijn, Bern, Rome, Stockholm, Wenen
Aan: buildroot at buildroot.org
CC: Romain Naour
Onderwerp: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3
This package is really annoying since the archive name doesn't contain the version. Use a small trick to save it with a better name. Also add hashes for license files.
---
Changes v1->v2:
- Move comment about the patch, in package/iqvlinux/Config.in, to the next commit.
- Use a small trick to save the source file with a better name.
--- package/iqvlinux/Config.in | 2 +- package/iqvlinux/iqvlinux.hash | 9 +++++---- package/iqvlinux/iqvlinux.mk | 17 ++++++++++++++--- 3 files changed, 20 insertions(+), 8 deletions(-)
package/iqvlinux/Config.in +1 -1
@@ -12,7 +12,7 @@ config BR2_PACKAGE_IQVLINUX Note: This driver requires PCI support to be enabled (i.e. CONFIG_PCI). - http://sourceforge.net/projects/e1000/files/iqvlinux/ + https://sourceforge.net/projects/e1000/files/iqvlinux/ comment "iqvlinux needs a Linux kernel to be built" depends on !BR2_LINUX_KERNEL
package/iqvlinux/iqvlinux.hash +5 -4
@@ -1,5 +1,6 @@ -# From http://sourceforge.net/projects/e1000/files/iqvlinux/1.1.5.3/ -sha1 bd94416e4364015dbbd78a22e51080bf7ea81fac iqvlinux.tar.gz -md5 fb6a2a4dc122d39070fcb06985c97a05 iqvlinux.tar.gz # locally computed -sha256 8cb19f3bfe040100a13bb2d05cb2b54f2b259e55cef23f8cc5aa6f2f31e98bec iqvlinux.tar.gz +sha256 4020a661940ba6d50f24654b90a41280eb8eccf00061fe6d105c654d3d97d551 iqvlinux-1.2.0.3.tar.gz +sha256 386086e232db4708770f717595d4f83188f776aa6e7313cd12fb039e869f494b COPYING +sha256 beded926a8f18aad5d911daf581759e2b25697588034d2b29033ae1a929506ff src/linux/driver/files.txt +sha256 ecf93b9b739fc82f7b87b34f8c6411dfdd271234af2fe45212293d9df2b654b3 inc/linux/files.txt +sha256 0a309350c1b32be72479e8fe08f7f6bbbad2e8c3d9a1cbcad3d482ea48a236ad inc/files.txt
package/iqvlinux/iqvlinux.mk +14 -3
@@ -4,9 +4,8 @@ # ################################################################################ -IQVLINUX_VERSION = 1.1.5.3 -IQVLINUX_SITE = http://sourceforge.net/projects/e1000/files/iqvlinux/$(IQVLINUX_VERSION) -IQVLINUX_SOURCE = iqvlinux.tar.gz +IQVLINUX_VERSION = 1.2.0.3 +IQVLINUX_SITE = https://downloads.sourceforge.net/project/e1000/iqvlinux/$(IQVLINUX_VERSION) IQVLINUX_LICENSE = GPL-2.0, BSD-3-Clause IQVLINUX_LICENSE_FILES = \
@@ -17,5 +16,17 @@ IQVLINUX_MODULE_MAKE_OPTS = NALDIR=$(@D) KSRC=$(LINUX_DIR) CC=$(TARGET_CC) IQVLINUX_MODULE_SUBDIRS = src/linux/driver +# This package is really annoying since the archive name doesn't contain the +# version. Use a small trick to save it with a better name. +define IQVLINUX_DOWNLOAD + $(EXTRA_ENV) $(DL_WRAPPER) -b wget \ + -o $(DL_DIR)/$(IQVLINUX_SOURCE) \ + -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + -- \ + $(IQVLINUX_SITE)/iqvlinux.tar.gz +endef + +IQVLINUX_PRE_DOWNLOAD_HOOKS = IQVLINUX_DOWNLOAD + $(eval $(kernel-module)) $(eval $(generic-package))
--
2.14.3
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
In reply to Carlos SantosHello,
Quoted 3 lines · Carlos Santos
This package is really annoying since the archive name doesn't contain the version. Use a small trick to save it with a better name. Also add hashes for license files.
Have you tried contacting upstreaming to see if they would be willing to use a more regular tarball naming scheme ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Quoted 9 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: buildroot at buildroot.org, "Romain Naour" <[email protected]>
Sent: Saturday, December 16, 2017 12:50:53 PM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Hello,
Quoted 7 lines
Quoted 3 lines · Carlos Santos
This package is really annoying since the archive name doesn't contain the version. Use a small trick to save it with a better name. Also add hashes for license files.
Have you tried contacting upstreaming to see if they would be willing to use a more regular tarball naming scheme ?
I will try it. Meanwhile we need a temporary solution.
Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D ?The greatest triumph that modern PR can offer is the transcendent success of having your words and actions judged by your reputation, rather than the other way about.? ? Christopher Hitchens
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Quoted 15 lines
From: "Carlos Santos" <[email protected]>
To: "Thomas Petazzoni" <[email protected]>
Cc: "Romain Naour" <[email protected]>, buildroot at buildroot.org
Sent: Saturday, December 16, 2017 5:03:08 PM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Quoted 9 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: buildroot at buildroot.org, "Romain Naour" <[email protected]>
Sent: Saturday, December 16, 2017 12:50:53 PM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Hello,
On Fri, 15 Dec 2017 13:38:29 -0200, Carlos Santos wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
This package is really annoying since the archive name doesn't contain the version. Use a small trick to save it with a better name. Also add hashes for license files.
Have you tried contacting upstreaming to see if they would be willing to use a more regular tarball naming scheme ?
I will try it. Meanwhile we need a temporary solution.
BTW, I their current naming scheme is already reasonable, since each release use a separate path. Those who download the file can save it with a different name. That's not rocket science.
Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D ?The greatest triumph that modern PR can offer is the transcendent success of having your words and actions judged by your reputation, rather than the other way about.? ? Christopher Hitchens
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Hello,
Quoted 5 lines · Carlos Santos
Quoted 1 line
I will try it. Meanwhile we need a temporary solution.
BTW, I their current naming scheme is already reasonable, since each release use a separate path. Those who download the file can save it with a different name. That's not rocket science.
Except it's totally uncommon, and many people save tarballs in a single folder. What they do is contrary to the practice of pretty much every other open-source project.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Hello Carlos,
Quoted 11 lines · Thomas Petazzoni
Quoted 5 lines · Carlos Santos
Quoted 1 line
I will try it. Meanwhile we need a temporary solution.
BTW, I their current naming scheme is already reasonable, since each release use a separate path. Those who download the file can save it with a different name. That's not rocket science.
Except it's totally uncommon, and many people save tarballs in a single folder. What they do is contrary to the practice of pretty much every other open-source project.
In the end, did you get the chance to raise the issue of the tarball name with the upstream developers ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Quoted 17 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: "Romain Naour" <[email protected]>, buildroot at buildroot.org
Sent: Tuesday, January 9, 2018 7:56:28 AM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Hello Carlos,
Quoted 8 lines · Thomas Petazzoni
Quoted 5 lines · Carlos Santos
Quoted 1 line
I will try it. Meanwhile we need a temporary solution.
BTW, I their current naming scheme is already reasonable, since each release use a separate path. Those who download the file can save it with a different name. That's not rocket science.
Quoted 6 lines
Quoted 3 lines
Except it's totally uncommon, and many people save tarballs in a single folder. What they do is contrary to the practice of pretty much every other open-source project.
In the end, did you get the chance to raise the issue of the tarball name with the upstream developers ?
Thanks for reminding me of this issue. I just submitted a ticket:
https://sourceforge.net/p/e1000/bugs/589/
Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D ?The greatest triumph that modern PR can offer is the transcendent success of having your words and actions judged by your reputation, rather than the other way about.? ? Christopher Hitchens
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Quoted 27 lines
From: "Carlos Santos" <[email protected]>
To: "Thomas Petazzoni" <[email protected]>
Cc: "Romain Naour" <[email protected]>, "buildroot" <[email protected]>
Sent: Tuesday, January 9, 2018 11:56:10 PM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Quoted 21 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: "Romain Naour" <[email protected]>, buildroot at buildroot.org
Sent: Tuesday, January 9, 2018 7:56:28 AM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Hello Carlos,
Quoted 11 lines · Thomas Petazzoni
Quoted 5 lines · Carlos Santos
Quoted 1 line
I will try it. Meanwhile we need a temporary solution.
BTW, I their current naming scheme is already reasonable, since each release use a separate path. Those who download the file can save it with a different name. That's not rocket science.
Except it's totally uncommon, and many people save tarballs in a single folder. What they do is contrary to the practice of pretty much every other open-source project.
Quoted 7 lines
Quoted 2 lines
In the end, did you get the chance to raise the issue of the tarball name with the upstream developers ?
Thanks for reminding me of this issue. I just submitted a ticket:
https://sourceforge.net/p/e1000/bugs/589/
No love, so far. :-(
Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D ?The greatest triumph that modern PR can offer is the transcendent success of having your words and actions judged by your reputation, rather than the other way about.? ? Christopher Hitchens
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Hello,
Quoted 8 lines · Carlos Santos
Quoted 6 lines
Quoted 2 lines
In the end, did you get the chance to raise the issue of the tarball name with the upstream developers ?
Thanks for reminding me of this issue. I just submitted a ticket:
https://sourceforge.net/p/e1000/bugs/589/No love, so far. :-(
I pinged on the bug report, just in case, but indeed, there isn't much hope.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Quoted 14 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: "Thomas Petazzoni" <[email protected]>, "Romain Naour" <[email protected]>, "buildroot" <[email protected]>
Sent: Wednesday, February 14, 2018 10:38:56 AM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Hello,
Quoted 3 lines · Carlos Santos
Quoted 3 lines
Quoted 2 lines
In the end, did you get the chance to raise the issue of the tarball name with the upstream developers ?
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Thanks for reminding me of this issue. I just submitted a ticket:
https://sourceforge.net/p/e1000/bugs/589/No love, so far. :-(
I pinged on the bug report, just in case, but indeed, there isn't much hope.
So we cannot upgrade the package without some hack to like the one in
https://patchwork.ozlabs.org/patch/849230/
It works, but uses $(DL_WRAPPER), which should be opaque to recipes.
Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D ?The greatest triumph that modern PR can offer is the transcendent success of having your words and actions judged by your reputation, rather than the other way about.? ? Christopher Hitchens
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Hello,
+Yann in Cc.
Quoted 20 lines · Carlos Santos
Quoted 20 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: "Thomas Petazzoni" <[email protected]>, "Romain Naour" <[email protected]>, "buildroot" <[email protected]>
Sent: Wednesday, February 14, 2018 10:38:56 AM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Hello,
Quoted 8 lines · Carlos Santos
Quoted 6 lines
Quoted 2 lines
In the end, did you get the chance to raise the issue of the tarball name with the upstream developers ?
Thanks for reminding me of this issue. I just submitted a ticket:
https://sourceforge.net/p/e1000/bugs/589/No love, so far. :-(
Quoted 8 lines
Quoted 2 lines
I pinged on the bug report, just in case, but indeed, there isn't much hope.
So we cannot upgrade the package without some hack to like the one in
https://patchwork.ozlabs.org/patch/849230/It works, but uses $(DL_WRAPPER), which should be opaque to recipes.
Either that, or we add explicit support for this in the package infrastructure, but it's a bit annoying. Indeed, if you have several files to download (in <pkg>_SOURCE, <pkg>_EXTRA_DOWNLOADS and <pkg>_PATCH), specifying what destination file name should be used is a bit tricky.
Yann, your thoughts ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
In reply to Carlos SantosHello,
Quoted 5 lines · Carlos Santos
This package is really annoying since the archive name doesn't contain the version. Use a small trick to save it with a better name. Also add hashes for license files.
Signed-off-by Carlos Santos <[email protected]>
So back on this driver. We looked at it with Arnout and Peter, and actually had a lot of fun reading the code. It is ugly as hell, uses copy_from/to_user inside spinlocks, and does lots of horrible things.
But more importantly, this driver does nothing, except provide a weird custom ioctl() interface, with no user-space program to use them.
How is this kernel driver meant to be used? Is it used with some non-public, closed-source, Intel utilities ?
Also, in the bug tracker at https://sourceforge.net/p/e1000/bugs/589/,
the person from Intel said: "I'm not really sure why you're trying to build this as it's only published here to conform with GPLv2. There's really no use for it.". So why are you using it ? Why do we have it in Buildroot ?
Romain, since you originally contributed this driver, perhaps you can give some details about how you used it ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Quoted 19 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: "buildroot" <[email protected]>, "Romain Naour" <[email protected]>
Sent: Sunday, April 1, 2018 7:37:02 PM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Hello,
Quoted 5 lines · Carlos Santos
This package is really annoying since the archive name doesn't contain the version. Use a small trick to save it with a better name. Also add hashes for license files.
Signed-off-by Carlos Santos <[email protected]>So back on this driver. We looked at it with Arnout and Peter, and actually had a lot of fun reading the code. It is ugly as hell, uses copy_from/to_user inside spinlocks, and does lots of horrible things.
Quoted 5 lines
But more importantly, this driver does nothing, except provide a weird custom
ioctl()interface, with no user-space program to use them.How is this kernel driver meant to be used? Is it used with some non-public, closed-source, Intel utilities ?
It is used for testing/debug purposes by some closed-source binaries that Intel distributes in its Quartzville Tools, under NDA.
Quoted 5 lines
Also, in the bug tracker at https://sourceforge.net/p/e1000/bugs/589/,
the person from Intel said: "I'm not really sure why you're trying to build this as it's only published here to conform with GPLv2. There's really no use for it.". So why are you using it ? Why do we have it in Buildroot ?
The code is distributed in a tarball along with Quartzville Tools so anyone who signs the required NDA have access to it. I don't know why the package exists in Buildroot but I'm glad it's there. I used it as the base for the package we have in our br2_external to build the driver and install the binaries provided by Intel. After doing that I felt it would be fair to make a small contribution in return.
Quoted 2 lines
Romain, since you originally contributed this driver, perhaps you can give some details about how you used it ?
Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D ?The greatest triumph that modern PR can offer is the transcendent success of having your words and actions judged by your reputation, rather than the other way about.? ? Christopher Hitchens
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
In reply to Carlos SantosHello,
package/iqvlinux/iqvlinux.mk IQVLINUX_MODULE_MAKE_OPTS = NALDIR=$(@D) KSRC=$(LINUX_DIR) CC=$(TARGET_CC) · line 29
Quoted 11 lines · Carlos Santos
package/iqvlinux/iqvlinux.mk +11
-0+# This package is really annoying since the archive name doesn't contain the +# version. Use a small trick to save it with a better name. +define IQVLINUX_DOWNLOAD + $(EXTRA_ENV) $(DL_WRAPPER) -b wget \ + -o $(DL_DIR)/$(IQVLINUX_SOURCE) \ + -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + -- \ + $(IQVLINUX_SITE)/iqvlinux.tar.gz +endef + +IQVLINUX_PRE_DOWNLOAD_HOOKS = IQVLINUX_DOWNLOAD
So instead of this, I've added an iqvlinux-1.2.0.3.tar.gz tarball on sources.buildroot.net, and just kept iqvlinux download first from SourceForge (which fails with a 404), and then fall back to sources.buildroot.net.
Accessing directly the download helper is not a good idea. The download helpers are internal, and they are being changed by Maxime/Yann patch series introducing Git caching, so we really don't want packages to mess up with the download internals.
It would be good if you could reply on the bug report upstream, explain why and how you use iqvlinux, and convince them to fix their tarball name.
I've applied both patches to master, after doing the change explained above. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/2 iqvlinux: bump to version 1.2.0.3
Quoted 27 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: "buildroot" <[email protected]>, "Romain Naour" <[email protected]>
Sent: Monday, April 2, 2018 6:26:50 AM
Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3Hello,
package/iqvlinux/iqvlinux.mk IQVLINUX_MODULE_MAKE_OPTS = NALDIR=$(@D) KSRC=$(LINUX_DIR) CC=$(TARGET_CC) · line 29
Quoted 11 lines · Carlos Santos
package/iqvlinux/iqvlinux.mk +11
-0+# This package is really annoying since the archive name doesn't contain the +# version. Use a small trick to save it with a better name. +define IQVLINUX_DOWNLOAD + $(EXTRA_ENV) $(DL_WRAPPER) -b wget \ + -o $(DL_DIR)/$(IQVLINUX_SOURCE) \ + -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + -- \ + $(IQVLINUX_SITE)/iqvlinux.tar.gz +endef + +IQVLINUX_PRE_DOWNLOAD_HOOKS = IQVLINUX_DOWNLOADSo instead of this, I've added an iqvlinux-1.2.0.3.tar.gz tarball on sources.buildroot.net, and just kept iqvlinux download first from SourceForge (which fails with a 404), and then fall back to sources.buildroot.net.
Quoted 8 lines
Accessing directly the download helper is not a good idea. The download helpers are internal, and they are being changed by Maxime/Yann patch series introducing Git caching, so we really don't want packages to mess up with the download internals.
It would be good if you could reply on the bug report upstream, explain why and how you use iqvlinux, and convince them to fix their tarball name.
I posted a reply there. Meanwhile they released version 1.2.0.8 and named it "iqvlinux.tar.gz". :-(
Quoted 2 lines
I've applied both patches to master, after doing the change explained above. Thanks!
Thanks
Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D ?The greatest triumph that modern PR can offer is the transcendent success of having your words and actions judged by your reputation, rather than the other way about.? ? Christopher Hitchens