Skip to contentSkip to conversation

package: remove the default value of the $(PKG)_SOURCE variable

PATCH New Jerzy Grzegorek 2 participants 3 messages Dec 17, 2017

lore
Share & tools
lore

Jerzy Grzegorek

author
#0 lore raw

PATCH 1/1 package: remove the default value of the $(PKG)_SOURCE variable

Signed-off-by Jerzy Grzegorek <[email protected]>
---
 package/pimd/pimd.mk                                   | 1 -
 package/proj/proj.mk                                   | 1 -
 package/traceroute/traceroute.mk                       | 1 -
 3 files changed, 3 deletions(-)
package/pimd/pimd.mk +0 -1
index 21b5e10..7a12f8f 100644
@@ -5,7 +5,6 @@
 ################################################################################
 
 PIMD_VERSION = 2.3.2
-PIMD_SOURCE = pimd-$(PIMD_VERSION).tar.gz
 PIMD_SITE = https://github.com/troglobit/pimd/releases/download/$(PIMD_VERSION)
 
 PIMD_LICENSE = BSD-3-Clause
package/proj/proj.mk +0 -1
index 5607dc0..6d029bb 100644
@@ -5,7 +5,6 @@
 ################################################################################
 
 PROJ_VERSION = 4.9.3
-PROJ_SOURCE = proj-$(PROJ_VERSION).tar.gz
 PROJ_SITE = http://download.osgeo.org/proj
 PROJ_LICENSE = MIT
 PROJ_LICENSE_FILES = COPYING
package/traceroute/traceroute.mk +0 -1
index 9d74b8f..d01c62d 100644
@@ -5,7 +5,6 @@
 ################################################################################
 
 TRACEROUTE_VERSION = 2.1.0
-TRACEROUTE_SOURCE = traceroute-$(TRACEROUTE_VERSION).tar.gz
 TRACEROUTE_SITE = http://downloads.sourceforge.net/traceroute/traceroute/traceroute-$(TRACEROUTE_VERSION)
 
 TRACEROUTE_LICENSE = GPL-2.0+, LGPL-2.1+
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package: remove the default value of the $(PKG)_SOURCE variable

Hello,

Quoted 6 lines · Jerzy Grzegorek
Signed-off-by Jerzy Grzegorek <[email protected]>
---
 package/pimd/pimd.mk                                   | 1 -
 package/proj/proj.mk                                   | 1 -
 package/traceroute/traceroute.mk                       | 1 -
 3 files changed, 3 deletions(-)

Applied to master, thanks. In order to avoid such mistakes in the future, would you be willing to contribute an addition to the check-package script that detects usage of the default <pkg>_SOURCE value ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 package: remove the default value of the $(PKG)_SOURCE variable

Hi Thomas,

Quoted 9 lines

Hello,

Quoted 6 lines · Jerzy Grzegorek
Signed-off-by Jerzy Grzegorek <[email protected]>
---
  package/pimd/pimd.mk                                   | 1 -
  package/proj/proj.mk                                   | 1 -
  package/traceroute/traceroute.mk                       | 1 -
  3 files changed, 3 deletions(-)
Quoted 4 lines

Applied to master, thanks. In order to avoid such mistakes in the future, would you be willing to contribute an addition to the check-package script that detects usage of the default <pkg>_SOURCE value ?

Sure, I'll try to do it.

Regards,
Jerzy

Quoted 4 lines

Thanks!

Thomas