pinctrl: single: Remove invalid message

Pinctrl single should just show how many pins were found, the physical address is already in the dev information. So let's remove the wrong information that claims to show the physical address but really prints a virtual address that is now hashed.

Signed-off-by Tony Lindgren <[email protected]>

---
  drivers/pinctrl/pinctrl-single.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

Quoted 14 lines · Tony Lindgren

Pinctrl single should just show how many pins were found, the physical address is already in the dev information. So let's remove the wrong information that claims to show the physical address but really prints a virtual address that is now hashed.

Signed-off-by Tony Lindgren <[email protected]>

---
  drivers/pinctrl/pinctrl-single.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

drivers/pinctrl/pinctrl-single.c static int pcs_probe(struct platform_device *pdev) · line 1778

Quoted 7 lines

drivers/pinctrl/pinctrl-single.c +1 -2

@@ -1774,8 +1774,7 @@ static int pcs_probe(struct platform_device *pdev)
  			dev_warn(pcs->dev, "initialized with no interrupts\n");
  	}
-	dev_info(pcs->dev, "%i pins at pa %p size %u\n",
-		 pcs->desc.npins, pcs->base, pcs->size);
+	dev_info(pcs->dev, "%i pins, size %u\n", pcs->desc.npins, pcs->size);
  	return pinctrl_enable(pcs->pctl);
 

Hi Tony,

If there's only one pinctrl region in SoC, it's fine to remove the pa part. But there're always multiple pinctrl regions in Hisilicon SoCs. It causes multiple pinctrl register bases are used. Will it cause debug information harder to read when pa parts are removed?

Quoted 24 lines · Haojian Zhuang

Quoted 14 lines · Tony Lindgren

Pinctrl single should just show how many pins were found, the physical address is already in the dev information. So let's remove the wrong information that claims to show the physical address but really prints a virtual address that is now hashed.

Signed-off-by Tony Lindgren <[email protected]>

---
   drivers/pinctrl/pinctrl-single.c | 3 +--
   1 file changed, 1 insertion(+), 2 deletions(-)

drivers/pinctrl/pinctrl-single.c static int pcs_probe(struct platform_device *pdev) · line 1778

Quoted 7 lines

drivers/pinctrl/pinctrl-single.c +1 -2

@@ -1774,8 +1774,7 @@ static int pcs_probe(struct platform_device *pdev)
   			dev_warn(pcs->dev, "initialized with no interrupts\n");
   	}
-	dev_info(pcs->dev, "%i pins at pa %p size %u\n",
-		 pcs->desc.npins, pcs->base, pcs->size);
+	dev_info(pcs->dev, "%i pins, size %u\n", pcs->desc.npins, pcs->size);
   	return pinctrl_enable(pcs->pctl);
 

Hi Tony,

Quoted 4 lines

If there's only one pinctrl region in SoC, it's fine to remove the pa part. But there're always multiple pinctrl regions in Hisilicon SoCs. It causes multiple pinctrl register bases are used. Will it cause debug information harder to read when pa parts are removed?

I doubt as for years now we've been printing out the va instead of pa and so far nobody noticed :) We still get the real device pa with the dev_info, size and number of pins.

Pinctrl single should just show how many pins were found, the physical address is already in the dev information. So let's remove the wrong information that claims to show the physical address but really prints a virtual address that is now hashed.

Signed-off-by Tony Lindgren <[email protected]>