i40e: avoid divide by zero
Subsystems (2)
PATCH 2/9 i40e: avoid divide by zero
From: Mitch Williams <[email protected]>
In some weird circumstances with DCB enabled, the firmware can fail to configure the VSI, leaving us with zero traffic classes. Check for this state when we configure RSS to avoid a panic.
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +7 -2
@@ -10839,8 +10839,13 @@ static int i40e_pf_config_rss(struct i40e_pf *pf)/* Determine the RSS size of the VSI */ if (!vsi->rss_size) {u16 qcount; - - qcount = vsi->num_queue_pairs / vsi->tc_config.numtc; +/* If the firmware does something weird during VSI init, we +* could end up with zero TCs. Check for that to avoid +* divide-by-zero. It probably won't pass traffic, but it also +* won't panic. +*/ + qcount = vsi->num_queue_pairs / + (vsi->tc_config.numtc ? vsi->tc_config.numtc :1 ); vsi->rss_size =min_t (int, pf->alloc_rss_size, qcount); }if (!vsi->rss_size)
Signature · 1 line
2.9.5
Bowers
PATCH 2/9 i40e: avoid divide by zero
Quoted 10 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Monday, December 18, 2017 2:15 AM
To: Michael, Alice <[email protected]>; intel-wired-
lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S83-V5 2/9] i40e: avoid divide by zeroFrom: Mitch Williams <[email protected]>
Quoted 8 lines
In some weird circumstances with DCB enabled, the firmware can fail to configure the VSI, leaving us with zero traffic classes. Check for this state when we configure RSS to avoid a panic.
Signed-off-by Mitch Williams <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)