Skip to contentSkip to conversation

i40evf: remove flush_scheduled_work call in i40evf_remove

PATCH New Alice Michael 2 participants 2 messages Dec 18, 2017 – Dec 22, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/9 i40evf: remove flush_scheduled_work call in i40evf_remove

From: Sudheer Mogilappagari <[email protected]>

flush_schedule_work blocks until completion of all scheduled work items in global work-queue. This can cause deadlock in some cases. i40evf_remove() cleans up necessary work items with cancel_delayed_work_sync and cancel_work_sync. This fix removes flush_schedule_work call inside i40evf_remove().

---
 drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/intel/i40evf/i40evf_main.c +0 -2
index f92587a..6472116 100644
@@ -3088,8 +3088,6 @@ static void i40evf_remove(struct pci_dev *pdev)
 	if (adapter->watchdog_timer.function)
 		del_timer_sync(&adapter->watchdog_timer);
 
-	flush_scheduled_work();
-
 	i40evf_free_rss(adapter);
 
 	if (hw->aq.asq.count)
Signature · 1 line
2.9.5
#1 lore raw

PATCH 3/9 i40evf: remove flush_scheduled_work call in i40evf_remove

Quoted 17 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Monday, December 18, 2017 2:16 AM
To: Michael, Alice <[email protected]>; intel-wired- lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S83-V5 3/9] i40evf: remove flush_scheduled_work call in i40evf_remove

From: Sudheer Mogilappagari <[email protected]>

flush_schedule_work blocks until completion of all scheduled work items in global work-queue. This can cause deadlock in some cases. i40evf_remove() cleans up necessary work items with cancel_delayed_work_sync and cancel_work_sync. This fix removes flush_schedule_work call inside i40evf_remove().

Quoted 4 lines
---
 drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 --
 1 file changed, 2 deletions(-)