i40e: Fix for blinking activity instead of link LEDs
Subsystems (2)
PATCH 5/9 i40e: Fix for blinking activity instead of link LEDs
From: Michal Kuchta <[email protected]>
This fix solves an issue occurring while calling i40e_led_set function from the driver with "blink" parameter set as TRUE. This call resulted in Activity LED blinking instead of Link LED, which may lead to errors in physically identyfying the port, since Activity LED may be blinking for different reasons aswell.
--- drivers/net/ethernet/intel/i40e/i40e_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_common.c +2 -3
@@ -1486,6 +1486,7 @@ u32 i40e_led_get(struct i40e_hw *hw)case I40E_COMBINED_ACTIVITY :case I40E_FILTER_ACTIVITY :case I40E_MAC_ACTIVITY : +case I40E_LINK_ACTIVITY :continue ;default :break ;
@@ -1534,6 +1535,7 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)case I40E_COMBINED_ACTIVITY :case I40E_FILTER_ACTIVITY :case I40E_MAC_ACTIVITY : +case I40E_LINK_ACTIVITY :continue ;default :break ;
@@ -1544,9 +1546,6 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink) gpio_val |= ((mode <<I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT ) &I40E_GLGEN_GPIO_CTL_LED_MODE_MASK ); -if (mode ==I40E_LINK_ACTIVITY ) - blink = false; -if (blink) gpio_val |=BIT (I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT );else
Signature · 1 line
2.9.5
Bowers
PATCH 5/9 i40e: Fix for blinking activity instead of link LEDs
Quoted 17 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Monday, December 18, 2017 2:17 AM
To: Michael, Alice <[email protected]>; intel-wired- lan at lists.osuosl.org
Cc: Kuchta, Michal <[email protected]>
Subject: [Intel-wired-lan] [next PATCH S83-V5 5/9] i40e: Fix for blinking activity instead of link LEDsFrom: Michal Kuchta <[email protected]>
This fix solves an issue occurring while calling
i40e_led_setfunction from the driver with "blink" parameter set as TRUE. This call resulted in Activity LED blinking instead of Link LED, which may lead to errors in physically identyfying the port, since Activity LED may be blinking for different reasons aswell.
Quoted 4 lines
Signed-off-by Michal Kuchta <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)