Skip to contentSkip to conversation

Add Exynos4412-based midas boards support

PATCH Superseded Simon Shields 6 participants 17 messages Dec 18, 2017 – Dec 26, 2017 4 messages not in the archive

Subsystems (5)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add Exynos4412-based midas boards support

Hi,

This patch series adds support for a new set of boards, codenamed "midas". These are the Galaxy S3 (m0/m3, GT-I9300/GT-I9305) and the Galaxy Note 2 (t0, GT-N7100/GT-N7105).

These boards are closely related to trats2 - m0 is a trats2 but with a bootloader geared towards booting Android rather than a traditional Linux distribution - and because of this, the dts files are largely based off what is already in-place for trats2. Trats2 is modified to use the dts files added by this series.

Patch #1 adds documentation for the bindings used by the boards. Patch #2 splits the existing trats2 DTS into the common midas, m0/m3/trats2-specific, and trats2-specific parts. Patch #3 adds the device-tree files for the other boards. Patch #4 enables cpuidle support for all added boards.

Changes since v1:
* Include trats2 in inheritance
* Add the new dtbs to the makefile
* Cleanup style per Krzysztof's comments

Changes since v2:
* Rebase on linux-next 20171218 (adds some fixes yet to land in mainline)
* Leave any changes to the DTS out of patch #2
* Minimise diff of exynos4412-midas.dtsi, using format-patch -B30% (thanks for the suggestion, Krzysztof)
* Leave original trats2 copyrights on midas and galaxy-s3 DTS files
* Preserve ABI for the cpuidle compatability check
* Explain the m0/m3/t0 -> GT-I9300/GT-I9305/GT-N7100/GT-N7105 relationship in the DT binding docs.

Cheers,
Simon

Simon Shields (4):
dt-bindings: samsung: document bindings for Midas family boards
ARM: dts: split trats2 DTS in preparation for midas boards
ARM: dts: add Samsung's exynos4412-based midas boards
ARM: exynos: extend cpuidle support to midas boards

 .../bindings/arm/samsung/samsung-boards.txt        |    4 +
 arch/arm/boot/dts/Makefile                         |    3 +
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi        |  145 ++
 arch/arm/boot/dts/exynos4412-m0.dts                |   27 +
 arch/arm/boot/dts/exynos4412-m3.dts                |   14 +
 ...exynos4412-trats2.dts => exynos4412-midas.dtsi} |  117 +-
 arch/arm/boot/dts/exynos4412-t0.dts                |   40 +
 arch/arm/boot/dts/exynos4412-trats2.dts            | 1446 +-------------------
 arch/arm/mach-exynos/exynos.c                      |    3 +-
 9 files changed, 274 insertions(+), 1525 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts
 copy arch/arm/boot/dts/{exynos4412-trats2.dts => exynos4412-midas.dtsi} (92%)
 create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts

rewrite arch/arm/boot/dts/exynos4412-trats2.dts (97%)

Signature · 6 lines
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20171218123805.26345-1-simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org

#2 lore raw

PATCH v3 1/4 dt-bindings: samsung: document bindings for Midas family boards

Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along with the shared "midas" binding.

---
 Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +4 -0
index e13459618581..9457c1dcb1e6 100644
@@ -9,7 +9,11 @@ Required root node properties:
 	- "samsung,smdkv310"	- for Exynos4210-based Samsung SMDKV310 eval board.
 	- "samsung,trats"	- for Exynos4210-based Tizen Reference board.
 	- "samsung,universal_c210" - for Exynos4210-based Samsung board.
+	- "samsung,m0"          - for Exynos4412-based Samsung GT-I9300 board, codenamed M0.
+	- "samsung,m3"          - for Exynos4412-based Samsung GT-I9305 board, codenamed M3.
+	- "samsung,midas"       - for Exynos4412-based Samsung Midas board.
 	- "samsung,smdk4412",	- for Exynos4412-based Samsung SMDK4412 eval board.
+	- "samsung,t0"          - for Exynos4412-based Samsung GT-N7100/GT-N7105 board, codenamed T0.
 	- "samsung,trats2"	- for Exynos4412-based Tizen Reference board.
 	- "samsung,smdk5250"	- for Exynos5250-based Samsung SMDK5250 eval board.
 	- "samsung,xyref5260"	- for Exynos5260-based Samsung board.
Signature · 6 lines
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#3 lore raw

Re: [PATCH v3 1/4] dt-bindings: samsung: document bindings for Midas family boards

Quoted 7 lines · Simon Shields

Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along with the shared "midas" binding.

---
 Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++
 1 file changed, 4 insertions(+)

My comment on v2 remains.

#4 lore raw

Re: [PATCH v3 1/4] dt-bindings: samsung: document bindings for Midas family boards

Hi Rob,

Thanks for the review.

Quoted 10 lines · Rob Herring
Quoted 7 lines · Simon Shields

Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along with the shared "midas" binding.

---
 Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++
 1 file changed, 4 insertions(+)

My comment on v2 remains.

Do you have any example of a better description? All the other ARM board descriptions seem similarly terse.

Alternatively, maybe changing the compatible strings is a better solution? "samsung,n710x" for t0, "samsung,i9300" for m0, and "samsung,i9305" for m3?

Cheers,
Simon

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

Re: [PATCH v3 1/4] dt-bindings: samsung: document bindings for Midas family boards

Quoted 14 lines · Simon Shields

Hi Rob,

Thanks for the review.

Quoted 9 lines · Rob Herring
Quoted 7 lines · Simon Shields

Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along with the shared "midas" binding.

---
 Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 8 lines
Quoted 1 line

My comment on v2 remains.

Do you have any example of a better description? All the other ARM board descriptions seem similarly terse.

Alternatively, maybe changing the compatible strings is a better solution? "samsung,n710x" for t0, "samsung,i9300" for m0, and "samsung,i9305" for m3?

Yes, it was the compatible string I was commenting on. I don't really care about the description because for most boards I have no idea what they are.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#7 lore raw

PATCH v3 3/4 ARM: dts: add Samsung's exynos4412-based midas boards

In reply to a message not in the archive

"midas" is the codename for a family of smartphones released by Samsung Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy Note 2 (GT-N7100/N7105). The boards largely have the same peripherals:
the main differences are touchscreen, display panel and cellular modem.

---
 arch/arm/boot/dts/Makefile          |  3 +++
 arch/arm/boot/dts/exynos4412-m0.dts | 27 +++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4412-m3.dts | 14 +++++++++++++
 arch/arm/boot/dts/exynos4412-t0.dts | 40 +++++++++++++++++++++++++++++++++++++
 4 files changed, 84 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts
arch/arm/boot/dts/Makefile +3 -0
index 66e28af289da..035abd66b472 100644
@@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
 	exynos4210-trats.dtb \
 	exynos4210-universal_c210.dtb \
 	exynos4412-itop-elite.dtb \
+	exynos4412-m0.dtb \
+	exynos4412-m3.dtb \
 	exynos4412-odroidu3.dtb \
 	exynos4412-odroidx.dtb \
 	exynos4412-odroidx2.dtb \
 	exynos4412-origen.dtb \
 	exynos4412-smdk4412.dtb \
+	exynos4412-t0.dtb \
 	exynos4412-tiny4412.dtb \
 	exynos4412-trats2.dtb
 dtb-$(CONFIG_ARCH_EXYNOS5) += \
arch/arm/boot/dts/exynos4412-m0.dts new file +27 -0
new file mode 100644
index 000000000000..56c1ea6b5695
@@ -0,0 +1,27 @@
+/*
+ * Samsung's Exynos4412 based M0 (GT-I9300) board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * Device tree source file for Samsung's M0 board which is based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"
+
+/ {
+	model = "Samsung M0 (GT-I9300) based on Exynos4412";
+	compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg =  <0x40000000 0x40000000>;
+	};
+
+};
arch/arm/boot/dts/exynos4412-m3.dts new file +14 -0
new file mode 100644
index 000000000000..80431044f07a
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"
+
+/ {
+	model = "Samsung M3 (GT-I9305) based on Exynos4412";
+	compatible = "samsung,m3", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg =  <0x40000000 0x80000000>;
+	};
+
+};
arch/arm/boot/dts/exynos4412-t0.dts new file +40 -0
new file mode 100644
index 000000000000..1444e893fb0e
@@ -0,0 +1,40 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-midas.dtsi"
+
+/ {
+	compatible = "samsung,t0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+	model = "Samsung T0 (GT-N7100, GT-N7105) based on Exynos4412";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg =  <0x40000000 0x80000000>;
+	};
+};
+
+&buck9_reg {
+	maxim,ena-gpios = <&gpm1 0 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&cam_io_reg {
+	gpio = <&gpm0 7 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&cam_af_reg {
+	gpio = <&gpm1 1 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&ldo13_reg {
+	regulator-name = "VCC_1.8V_LCD";
+	regulator-always-on;
+};
+
+&ldo25_reg {
+	regulator-name = "VCI_3.0V_LCD";
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	status = "okay";
+};
Signature · 6 lines
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#8 lore raw

Re: [PATCH v3 3/4] ARM: dts: add Samsung's exynos4412-based midas boards

Quoted 55 lines · Simon Shields

"midas" is the codename for a family of smartphones released by Samsung Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy Note 2 (GT-N7100/N7105). The boards largely have the same peripherals:
the main differences are touchscreen, display panel and cellular modem.

---
 arch/arm/boot/dts/Makefile          |  3 +++
 arch/arm/boot/dts/exynos4412-m0.dts | 27 +++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4412-m3.dts | 14 +++++++++++++
 arch/arm/boot/dts/exynos4412-t0.dts | 40 +++++++++++++++++++++++++++++++++++++
 4 files changed, 84 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts
arch/arm/boot/dts/Makefile +3 -0
index 66e28af289da..035abd66b472 100644
@@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
        exynos4210-trats.dtb \
        exynos4210-universal_c210.dtb \
        exynos4412-itop-elite.dtb \
+       exynos4412-m0.dtb \
+       exynos4412-m3.dtb \
        exynos4412-odroidu3.dtb \
        exynos4412-odroidx.dtb \
        exynos4412-odroidx2.dtb \
        exynos4412-origen.dtb \
        exynos4412-smdk4412.dtb \
+       exynos4412-t0.dtb \
        exynos4412-tiny4412.dtb \
        exynos4412-trats2.dtb
 dtb-$(CONFIG_ARCH_EXYNOS5) += \
arch/arm/boot/dts/exynos4412-m0.dts new file +14 -0
new file mode 100644
index 000000000000..56c1ea6b5695
@@ -0,0 +1,27 @@
+/*
+ * Samsung's Exynos4412 based M0 (GT-I9300) board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * Device tree source file for Samsung's M0 board which is based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+

arch/arm/boot/dts/exynos4412-m0.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos4412-m0.dts new file +10 -0
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"
+
+/ {
+       model = "Samsung M0 (GT-I9300) based on Exynos4412";
+       compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg =  <0x40000000 0x40000000>;

I think each board has the same memory so maybe this can be made part of midas.dtsi?

arch/arm/boot/dts/exynos4412-m0.dts line 25

Quoted 1 line
arch/arm/boot/dts/exynos4412-m0.dts new file +1 -0
+       };

What about bootargs?

arch/arm/boot/dts/exynos4412-m0.dts line 26

Quoted 1 line
arch/arm/boot/dts/exynos4412-m0.dts new file +1 -0
+

Unneeded new line.

Quoted 10 lines
arch/arm/boot/dts/exynos4412-m0.dts new file +1 -0
+};
arch/arm/boot/dts/exynos4412-m3.dts new file +3 -0
new file mode 100644
index 000000000000..80431044f07a
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"

arch/arm/boot/dts/exynos4412-m3.dts line 13

Quoted 10 lines
arch/arm/boot/dts/exynos4412-m3.dts new file +10 -0
+
+/ {
+       model = "Samsung M3 (GT-I9305) based on Exynos4412";
+       compatible = "samsung,m3", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg =  <0x40000000 0x80000000>;
+       };
+

Ditto

Quoted 25 lines
arch/arm/boot/dts/exynos4412-m3.dts new file +1 -0
+};
arch/arm/boot/dts/exynos4412-t0.dts new file +18 -0
new file mode 100644
index 000000000000..1444e893fb0e
@@ -0,0 +1,40 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-midas.dtsi"
+
+/ {
+       compatible = "samsung,t0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+       model = "Samsung T0 (GT-N7100, GT-N7105) based on Exynos4412";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg =  <0x40000000 0x80000000>;
+       };
+};
+
+&buck9_reg {
+       maxim,ena-gpios = <&gpm1 0 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};

arch/arm/boot/dts/exynos4412-t0.dts line 28

Quoted 10 lines
arch/arm/boot/dts/exynos4412-t0.dts new file +10 -0
+
+&cam_io_reg {
+       gpio = <&gpm0 7 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};
+
+&cam_af_reg {
+       gpio = <&gpm1 1 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};

Please but the cam nodes in alphabetical order.

Quoted 15 lines
arch/arm/boot/dts/exynos4412-t0.dts new file +12 -1
+
+&ldo13_reg {
+       regulator-name = "VCC_1.8V_LCD";
+       regulator-always-on;
+};
+
+&ldo25_reg {
+       regulator-name = "VCI_3.0V_LCD";
+       regulator-min-microvolt = <3000000>;
+       regulator-max-microvolt = <3000000>;
+       status = "okay";
+};
--

2.15.1

#9 lore raw

Re: [PATCH v3 3/4] ARM: dts: add Samsung's exynos4412-based midas boards

Hi Krzysztof,

Quoted 61 lines · Krzysztof Kozlowski
Quoted 60 lines · Simon Shields

"midas" is the codename for a family of smartphones released by Samsung Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy Note 2 (GT-N7100/N7105). The boards largely have the same peripherals:
the main differences are touchscreen, display panel and cellular modem.

---
 arch/arm/boot/dts/Makefile          |  3 +++
 arch/arm/boot/dts/exynos4412-m0.dts | 27 +++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4412-m3.dts | 14 +++++++++++++
 arch/arm/boot/dts/exynos4412-t0.dts | 40 +++++++++++++++++++++++++++++++++++++
 4 files changed, 84 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts
arch/arm/boot/dts/Makefile +3 -0
index 66e28af289da..035abd66b472 100644
@@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
        exynos4210-trats.dtb \
        exynos4210-universal_c210.dtb \
        exynos4412-itop-elite.dtb \
+       exynos4412-m0.dtb \
+       exynos4412-m3.dtb \
        exynos4412-odroidu3.dtb \
        exynos4412-odroidx.dtb \
        exynos4412-odroidx2.dtb \
        exynos4412-origen.dtb \
        exynos4412-smdk4412.dtb \
+       exynos4412-t0.dtb \
        exynos4412-tiny4412.dtb \
        exynos4412-trats2.dtb
 dtb-$(CONFIG_ARCH_EXYNOS5) += \
arch/arm/boot/dts/exynos4412-m0.dts new file +19 -0
new file mode 100644
index 000000000000..56c1ea6b5695
@@ -0,0 +1,27 @@
+/*
+ * Samsung's Exynos4412 based M0 (GT-I9300) board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * Device tree source file for Samsung's M0 board which is based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"
+
+/ {
+       model = "Samsung M0 (GT-I9300) based on Exynos4412";
Quoted 8 lines

arch/arm/boot/dts/exynos4412-m0.dts line 24

Quoted 5 lines
arch/arm/boot/dts/exynos4412-m0.dts new file +5 -0
+       compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg =  <0x40000000 0x40000000>;

I think each board has the same memory so maybe this can be made part of midas.dtsi?

T0 and M3 have 2GB of RAM, trats2/M0 have 1GB.

Quoted 4 lines

arch/arm/boot/dts/exynos4412-m0.dts line 25

Quoted 2 lines
arch/arm/boot/dts/exynos4412-m0.dts new file +1 -0
+       };

What about bootargs?

Handled by the bootloader - to work around the proprietary bootloader not supporting device tree and requiring hacks to successfully boot a mainline kernel, i'm using kexec from a suitably patched kernel to load and boot the "real" kernel. (This also means one image can be used across all boards).

Quoted 66 lines

arch/arm/boot/dts/exynos4412-m0.dts line 26

Quoted 2 lines
arch/arm/boot/dts/exynos4412-m0.dts new file +1 -0
+

Unneeded new line.

Quoted 10 lines
arch/arm/boot/dts/exynos4412-m0.dts new file +1 -0
+};
arch/arm/boot/dts/exynos4412-m3.dts new file +3 -0
new file mode 100644
index 000000000000..80431044f07a
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"

arch/arm/boot/dts/exynos4412-m3.dts line 13

Quoted 10 lines
arch/arm/boot/dts/exynos4412-m3.dts new file +10 -0
+
+/ {
+       model = "Samsung M3 (GT-I9305) based on Exynos4412";
+       compatible = "samsung,m3", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg =  <0x40000000 0x80000000>;
+       };
+

Ditto

Quoted 25 lines
arch/arm/boot/dts/exynos4412-m3.dts new file +1 -0
+};
arch/arm/boot/dts/exynos4412-t0.dts new file +18 -0
new file mode 100644
index 000000000000..1444e893fb0e
@@ -0,0 +1,40 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-midas.dtsi"
+
+/ {
+       compatible = "samsung,t0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+       model = "Samsung T0 (GT-N7100, GT-N7105) based on Exynos4412";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg =  <0x40000000 0x80000000>;
+       };
+};
+
+&buck9_reg {
+       maxim,ena-gpios = <&gpm1 0 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};

arch/arm/boot/dts/exynos4412-t0.dts line 28

Quoted 10 lines
arch/arm/boot/dts/exynos4412-t0.dts new file +10 -0
+
+&cam_io_reg {
+       gpio = <&gpm0 7 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};
+
+&cam_af_reg {
+       gpio = <&gpm1 1 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};

Please but the cam nodes in alphabetical order.

Quoted 15 lines
Quoted 13 lines
arch/arm/boot/dts/exynos4412-t0.dts new file +12 -1
+
+&ldo13_reg {
+       regulator-name = "VCC_1.8V_LCD";
+       regulator-always-on;
+};
+
+&ldo25_reg {
+       regulator-name = "VCI_3.0V_LCD";
+       regulator-min-microvolt = <3000000>;
+       regulator-max-microvolt = <3000000>;
+       status = "okay";
+};
--
Quoted 2 lines

2.15.1

Cheers,
Simon

A message that is not in the archive (sent off-list or not yet received): [email protected]

#11 lore raw

Re: [PATCH v3 3/4] ARM: dts: add Samsung's exynos4412-based midas boards

Quoted 73 lines · Simon Shields

Hi Krzysztof,

Quoted 61 lines · Krzysztof Kozlowski
Quoted 60 lines · Simon Shields

"midas" is the codename for a family of smartphones released by Samsung Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy Note 2 (GT-N7100/N7105). The boards largely have the same peripherals:
the main differences are touchscreen, display panel and cellular modem.

---
 arch/arm/boot/dts/Makefile          |  3 +++
 arch/arm/boot/dts/exynos4412-m0.dts | 27 +++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4412-m3.dts | 14 +++++++++++++
 arch/arm/boot/dts/exynos4412-t0.dts | 40 +++++++++++++++++++++++++++++++++++++
 4 files changed, 84 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts
arch/arm/boot/dts/Makefile +3 -0
index 66e28af289da..035abd66b472 100644
@@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
        exynos4210-trats.dtb \
        exynos4210-universal_c210.dtb \
        exynos4412-itop-elite.dtb \
+       exynos4412-m0.dtb \
+       exynos4412-m3.dtb \
        exynos4412-odroidu3.dtb \
        exynos4412-odroidx.dtb \
        exynos4412-odroidx2.dtb \
        exynos4412-origen.dtb \
        exynos4412-smdk4412.dtb \
+       exynos4412-t0.dtb \
        exynos4412-tiny4412.dtb \
        exynos4412-trats2.dtb
 dtb-$(CONFIG_ARCH_EXYNOS5) += \
arch/arm/boot/dts/exynos4412-m0.dts new file +19 -0
new file mode 100644
index 000000000000..56c1ea6b5695
@@ -0,0 +1,27 @@
+/*
+ * Samsung's Exynos4412 based M0 (GT-I9300) board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * Device tree source file for Samsung's M0 board which is based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"
+
+/ {
+       model = "Samsung M0 (GT-I9300) based on Exynos4412";
Quoted 8 lines

arch/arm/boot/dts/exynos4412-m0.dts line 24

Quoted 5 lines
arch/arm/boot/dts/exynos4412-m0.dts new file +5 -0
+       compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg =  <0x40000000 0x40000000>;

I think each board has the same memory so maybe this can be made part of midas.dtsi?

Quoted 1 line

T0 and M3 have 2GB of RAM, trats2/M0 have 1GB.

Ah, ok.

Quoted 11 lines
Quoted 5 lines

arch/arm/boot/dts/exynos4412-m0.dts line 25

Quoted 3 lines
arch/arm/boot/dts/exynos4412-m0.dts new file +1 -0
+       };

What about bootargs?

Handled by the bootloader - to work around the proprietary bootloader not supporting device tree and requiring hacks to successfully boot a mainline kernel, i'm using kexec from a suitably patched kernel to load and boot the "real" kernel. (This also means one image can be used across all boards).

Could you document it in DTS why bootargs are missing?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#12 lore raw

PATCH v3 2/4 ARM: dts: split trats2 DTS in preparation for midas boards

In reply to Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi        |  145 ++
 ...exynos4412-trats2.dts => exynos4412-midas.dtsi} |  117 +-
 arch/arm/boot/dts/exynos4412-trats2.dts            | 1446 +-------------------
 3 files changed, 184 insertions(+), 1524 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 copy arch/arm/boot/dts/{exynos4412-trats2.dts => exynos4412-midas.dtsi} (92%)

rewrite arch/arm/boot/dts/exynos4412-trats2.dts (97%)

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +145 -0
new file mode 100644
index 000000000000..2806236484a6
@@ -0,0 +1,145 @@
+/*
+ * Samsung's Exynos4412 based Galaxy S3 board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * Device tree source file for Samsung's Galaxy S3 boards which are based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+#include "exynos4412-midas.dtsi"
+
+/ {
+	aliases {
+		i2c9 = &i2c_ak8975;
+		i2c10 = &i2c_cm36651;
+	};
+
+	regulators {
+		lcd_vdd3_reg: voltage-regulator-2 {
+			compatible = "regulator-fixed";
+			regulator-name = "LCD_VDD_2.2V";
+			regulator-min-microvolt = <2200000>;
+			regulator-max-microvolt = <2200000>;
+			gpio = <&gpc0 1 GPIO_ACTIVE_HIGH>;
+			enable-active-high;
+		};
+
+		ps_als_reg: voltage-regulator-5 {
+			compatible = "regulator-fixed";
+			regulator-name = "LED_A_3.0V";
+			regulator-min-microvolt = <3000000>;
+			regulator-max-microvolt = <3000000>;
+			gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
+			enable-active-high;
+		};
+	};
+
+	i2c_ak8975: i2c-gpio-0 {
+		compatible = "i2c-gpio";
+		gpios = <&gpy2 4 GPIO_ACTIVE_HIGH>, <&gpy2 5 GPIO_ACTIVE_HIGH>;
+		i2c-gpio,delay-us = <2>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "okay";
+
+		ak8975@c {
+			compatible = "asahi-kasei,ak8975";
+			reg = <0x0c>;
+			gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
+	i2c_cm36651: i2c-gpio-2 {
+		compatible = "i2c-gpio";
+		gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>;
+		i2c-gpio,delay-us = <2>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cm36651@18 {
+			compatible = "capella,cm36651";
+			reg = <0x18>;
+			interrupt-parent = <&gpx0>;
+			interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
+			vled-supply = <&ps_als_reg>;
+		};
+	};
+};
+
+&buck9_reg {
+	maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>;
+};
+
+&cam_af_reg {
+	gpio = <&gpm0 4 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&cam_io_reg {
+	gpio = <&gpm0 2 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&dsi_0 {
+	status = "okay";
+	panel@0 {
+		compatible = "samsung,s6e8aa0";
+		reg = <0>;
+		vdd3-supply = <&lcd_vdd3_reg>;
+		vci-supply = <&ldo25_reg>;
+		reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
+		power-on-delay= <50>;
+		reset-delay = <100>;
+		init-delay = <100>;
+		flip-horizontal;
+		flip-vertical;
+		panel-width-mm = <58>;
+		panel-height-mm = <103>;
+
+		display-timings {
+			timing-0 {
+				clock-frequency = <57153600>;
+				hactive = <720>;
+				vactive = <1280>;
+				hfront-porch = <5>;
+				hback-porch = <5>;
+				hsync-len = <5>;
+				vfront-porch = <13>;
+				vback-porch = <1>;
+				vsync-len = <2>;
+			};
+		};
+	};
+};
+
+&i2c_0 {
+	status = "okay";
+};
+
+&i2c_3 {
+	status = "okay";
+
+	mms114-touchscreen@48 {
+		compatible = "melfas,mms114";
+		reg = <0x48>;
+		interrupt-parent = <&gpm2>;
+		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+		x-size = <720>;
+		y-size = <1280>;
+		avdd-supply = <&ldo23_reg>;
+		vdd-supply = <&ldo24_reg>;
+	};
+};
+
+&ldo25_reg {
+	regulator-name = "LCD_VCC_3.3V";
+	regulator-min-microvolt = <2800000>;
+	regulator-max-microvolt = <2800000>;
+	status = "okay";
+};
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +8 -109

196 lines not on this page · raw message

arch/arm/boot/dts/exynos4412-trats2.dts +31 -1415

1,446 lines not on this page · raw message

Signature · 1 line
2.15.1
#13 lore raw

Re: [PATCH v3 2/4] ARM: dts: split trats2 DTS in preparation for midas boards

Quoted 22 lines · Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi        |  145 ++
 ...exynos4412-trats2.dts => exynos4412-midas.dtsi} |  117 +-
 arch/arm/boot/dts/exynos4412-trats2.dts            | 1446 +-------------------
 3 files changed, 184 insertions(+), 1524 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 copy arch/arm/boot/dts/{exynos4412-trats2.dts => exynos4412-midas.dtsi} (92%)

rewrite arch/arm/boot/dts/exynos4412-trats2.dts (97%)

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +3 -0
new file mode 100644
index 000000000000..2806236484a6
@@ -0,0 +1,145 @@
+/*
+ * Samsung's Exynos4412 based Galaxy S3 board device tree source
+ *

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi line 13

Quoted 10 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +10 -0
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * Device tree source file for Samsung's Galaxy S3 boards which are based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */

One new line to make it consistent with others.

Quoted 67 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +67 -0
+/dts-v1/;
+#include "exynos4412-midas.dtsi"
+
+/ {
+       aliases {
+               i2c9 = &i2c_ak8975;
+               i2c10 = &i2c_cm36651;
+       };
+
+       regulators {
+               lcd_vdd3_reg: voltage-regulator-2 {
+                       compatible = "regulator-fixed";
+                       regulator-name = "LCD_VDD_2.2V";
+                       regulator-min-microvolt = <2200000>;
+                       regulator-max-microvolt = <2200000>;
+                       gpio = <&gpc0 1 GPIO_ACTIVE_HIGH>;
+                       enable-active-high;
+               };
+
+               ps_als_reg: voltage-regulator-5 {
+                       compatible = "regulator-fixed";
+                       regulator-name = "LED_A_3.0V";
+                       regulator-min-microvolt = <3000000>;
+                       regulator-max-microvolt = <3000000>;
+                       gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
+                       enable-active-high;
+               };
+       };
+
+       i2c_ak8975: i2c-gpio-0 {
+               compatible = "i2c-gpio";
+               gpios = <&gpy2 4 GPIO_ACTIVE_HIGH>, <&gpy2 5 GPIO_ACTIVE_HIGH>;
+               i2c-gpio,delay-us = <2>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+               status = "okay";
+
+               ak8975@c {
+                       compatible = "asahi-kasei,ak8975";
+                       reg = <0x0c>;
+                       gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
+               };
+       };
+
+       i2c_cm36651: i2c-gpio-2 {
+               compatible = "i2c-gpio";
+               gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>;
+               i2c-gpio,delay-us = <2>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               cm36651@18 {
+                       compatible = "capella,cm36651";
+                       reg = <0x18>;
+                       interrupt-parent = <&gpx0>;
+                       interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
+                       vled-supply = <&ps_als_reg>;
+               };
+       };
+};
+
+&buck9_reg {
+       maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>;
+};
+
+&cam_af_reg {
+       gpio = <&gpm0 4 GPIO_ACTIVE_HIGH>;

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi line 90

Quoted 10 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +10 -0
+       status = "okay";
+};
+
+&cam_io_reg {
+       gpio = <&gpm0 2 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};
+
+&dsi_0 {
+       status = "okay";

One new line.

Quoted 72 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +55 -0
+       panel@0 {
+               compatible = "samsung,s6e8aa0";
+               reg = <0>;
+               vdd3-supply = <&lcd_vdd3_reg>;
+               vci-supply = <&ldo25_reg>;
+               reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
+               power-on-delay= <50>;
+               reset-delay = <100>;
+               init-delay = <100>;
+               flip-horizontal;
+               flip-vertical;
+               panel-width-mm = <58>;
+               panel-height-mm = <103>;
+
+               display-timings {
+                       timing-0 {
+                               clock-frequency = <57153600>;
+                               hactive = <720>;
+                               vactive = <1280>;
+                               hfront-porch = <5>;
+                               hback-porch = <5>;
+                               hsync-len = <5>;
+                               vfront-porch = <13>;
+                               vback-porch = <1>;
+                               vsync-len = <2>;
+                       };
+               };
+       };
+};
+
+&i2c_0 {
+       status = "okay";
+};
+
+&i2c_3 {
+       status = "okay";
+
+       mms114-touchscreen@48 {
+               compatible = "melfas,mms114";
+               reg = <0x48>;
+               interrupt-parent = <&gpm2>;
+               interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+               x-size = <720>;
+               y-size = <1280>;
+               avdd-supply = <&ldo23_reg>;
+               vdd-supply = <&ldo24_reg>;
+       };
+};
+
+&ldo25_reg {
+       regulator-name = "LCD_VCC_3.3V";
+       regulator-min-microvolt = <2800000>;
+       regulator-max-microvolt = <2800000>;
+       status = "okay";
+};
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
similarity index 92%
copy from arch/arm/boot/dts/exynos4412-trats2.dts
copy to arch/arm/boot/dts/exynos4412-midas.dtsi
index f285790e8e04..384767a34fa7 100644
@@ -10,7 +10,7 @@
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
-*/
+ */
 
 /dts-v1/;
 #include "exynos4412.dtsi"

arch/arm/boot/dts/exynos4412-midas.dtsi line 25

Quoted 1 line
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -0
@@ -25,19 +25,11 @@
        compatible = "samsung,trats2", "samsung,exynos4412", "samsung,exynos4";

This looks incorrect. Not every midas board is trats2... Unless that was left here for compatibility purpose but then it would be good to see explanation.

Quoted 24 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -10
        aliases {
-               i2c9 = &i2c_ak8975;
-               i2c10 = &i2c_cm36651;
                i2c11 = &i2c_max77693;
                i2c12 = &i2c_max77693_fuel;
        };
 
-       memory@40000000 {
-               device_type = "memory";
-               reg =  <0x40000000 0x40000000>;
-       };
-
        chosen {
-               bootargs = "console=ttySAC2,115200N8 root=/dev/mmcblk0p5 rootwait earlyprintk panic=5";
                stdout-path = &serial_2;
        };
 
@@ -68,17 +60,8 @@
                        regulator-name = "CAM_SENSOR_A";
                        regulator-min-microvolt = <2800000>;
                        regulator-max-microvolt = <2800000>;
-                       gpio = <&gpm0 2 GPIO_ACTIVE_HIGH>;
-                       enable-active-high;

arch/arm/boot/dts/exynos4412-midas.dtsi line 64

Quoted 10 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -8
-               };
-
-               lcd_vdd3_reg: voltage-regulator-2 {
-                       compatible = "regulator-fixed";
-                       regulator-name = "LCD_VDD_2.2V";
-                       regulator-min-microvolt = <2200000>;
-                       regulator-max-microvolt = <2200000>;
-                       gpio = <&gpc0 1 GPIO_ACTIVE_HIGH>;
                        enable-active-high;
+                       status = "disabled";

Why disabled?

Quoted 9 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -2
                };
 
                cam_af_reg: voltage-regulator-3 {
@@ -86,17 +69,8 @@
                        regulator-name = "CAM_AF";
                        regulator-min-microvolt = <2800000>;
                        regulator-max-microvolt = <2800000>;
-                       gpio = <&gpm0 4 GPIO_ACTIVE_HIGH>;
-                       enable-active-high;

arch/arm/boot/dts/exynos4412-midas.dtsi line 73

Quoted 10 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -8
-               };
-
-               ps_als_reg: voltage-regulator-5 {
-                       compatible = "regulator-fixed";
-                       regulator-name = "LED_A_3.0V";
-                       regulator-min-microvolt = <3000000>;
-                       regulator-max-microvolt = <3000000>;
-                       gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
                        enable-active-high;
+                       status = "disabled";

Why disabled?

Quoted 75 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -54
                };
 
                vsil12: voltage-regulator-6 {
@@ -227,37 +201,6 @@
                };
        };
 
-       i2c_ak8975: i2c-gpio-0 {
-               compatible = "i2c-gpio";
-               gpios = <&gpy2 4 GPIO_ACTIVE_HIGH>, <&gpy2 5 GPIO_ACTIVE_HIGH>;
-               i2c-gpio,delay-us = <2>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-               status = "okay";
-
-               ak8975@c {
-                       compatible = "asahi-kasei,ak8975";
-                       reg = <0x0c>;
-                       gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
-               };
-       };
-
-       i2c_cm36651: i2c-gpio-2 {
-               compatible = "i2c-gpio";
-               gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>;
-               i2c-gpio,delay-us = <2>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-
-               cm36651@18 {
-                       compatible = "capella,cm36651";
-                       reg = <0x18>;
-                       interrupt-parent = <&gpx0>;
-                       interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
-                       vled-supply = <&ps_als_reg>;
-               };
-       };
-
        i2c-mhl {
                compatible = "i2c-gpio";
                gpios = <&gpf0 4 GPIO_ACTIVE_HIGH>, <&gpf0 6 GPIO_ACTIVE_HIGH>;
@@ -296,8 +239,6 @@
                                  <&clock CLK_MOUT_CAM1>;
                assigned-clock-parents = <&clock CLK_XUSBXTI>,
                                         <&clock CLK_XUSBXTI>;
-
-
        };
 
        wlan_pwrseq: sdhci3-pwrseq {
@@ -454,36 +395,7 @@
        samsung,burst-clock-frequency = <500000000>;
        samsung,esc-clock-frequency = <20000000>;
        samsung,pll-clock-frequency = <24000000>;
-       status = "okay";
-
-       panel@0 {
-               compatible = "samsung,s6e8aa0";
-               reg = <0>;
-               vdd3-supply = <&lcd_vdd3_reg>;
-               vci-supply = <&ldo25_reg>;
-               reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
-               power-on-delay= <50>;
-               reset-delay = <100>;
-               init-delay = <100>;
-               flip-horizontal;
-               flip-vertical;
-               panel-width-mm = <58>;
-               panel-height-mm = <103>;
-
-               display-timings {
-                       timing-0 {
-                               clock-frequency = <57153600>;
-                               hactive = <720>;
-                               vactive = <1280>;

arch/arm/boot/dts/exynos4412-midas.dtsi line 398

Quoted 10 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -9
-                               hfront-porch = <5>;
-                               hback-porch = <5>;
-                               hsync-len = <5>;
-                               vfront-porch = <13>;
-                               vback-porch = <1>;
-                               vsync-len = <2>;
-                       };
-               };
-       };
+       status = "disabled";

It is already disabled by exynos4.dtsi, no need to duplicate properties.

arch/arm/boot/dts/exynos4412-midas.dtsi line 518

Quoted 9 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
 };
 
 &exynos_usbphy {
@@ -603,7 +515,7 @@
        samsung,i2c-max-bus-freq = <400000>;
        pinctrl-0 = <&i2c0_bus>;
        pinctrl-names = "default";
-       status = "okay";
+       status = "disabled";

I do not get this node. It sits in midas.dtsi and s3.dtsi just enables it. Why not enabling it here?

Quoted 23 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -12
        s5c73m3@3c {
                compatible = "samsung,s5c73m3";
@@ -635,18 +547,7 @@
        samsung,i2c-max-bus-freq = <400000>;
        pinctrl-0 = <&i2c3_bus>;
        pinctrl-names = "default";
-       status = "okay";
-
-       mms114-touchscreen@48 {
-               compatible = "melfas,mms114";
-               reg = <0x48>;
-               interrupt-parent = <&gpm2>;
-               interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
-               x-size = <720>;
-               y-size = <1280>;
-               avdd-supply = <&ldo23_reg>;
-               vdd-supply = <&ldo24_reg>;
-       };
+       status = "disabled";
 };
 
 &i2c_4 {

arch/arm/boot/dts/exynos4412-midas.dtsi line 731

Quoted 4 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -0
@@ -827,6 +728,7 @@
                                regulator-name = "CAM_SENSOR_CORE_1.2V";
                                regulator-min-microvolt = <1200000>;
                                regulator-max-microvolt = <1200000>;
+                               status = "okay";

Regulator should not be disabled or enabled. It is not a device. I do not get the logic behind...

The ''status = disabled" usually is added in DTSI files to nodes which are not fully configured at this point, e.g. they require external resources (clocks, regulators). These external resources will be provided when extending in DTS (or further DTSI) while enabling it. However regulator has always all necessary resources.

arch/arm/boot/dts/exynos4412-midas.dtsi line 779

Quoted 11 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -3
                        };
 
                        ldo18_reg: LDO18 {
@@ -874,9 +776,7 @@
                        };
 
                        ldo25_reg: LDO25 {
-                               regulator-name = "LCD_VCC_3.3V";
-                               regulator-min-microvolt = <2800000>;
-                               regulator-max-microvolt = <2800000>;
+                               status = "disabled";

Ditto.

Best regards,
Krzysztof

#14 lore raw

Re: [PATCH v3 2/4] ARM: dts: split trats2 DTS in preparation for midas boards

Hi Krzysztof,

Thanks for the review.

Quoted 185 lines · Krzysztof Kozlowski
Quoted 22 lines · Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi        |  145 ++
 ...exynos4412-trats2.dts => exynos4412-midas.dtsi} |  117 +-
 arch/arm/boot/dts/exynos4412-trats2.dts            | 1446 +-------------------
 3 files changed, 184 insertions(+), 1524 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 copy arch/arm/boot/dts/{exynos4412-trats2.dts => exynos4412-midas.dtsi} (92%)

rewrite arch/arm/boot/dts/exynos4412-trats2.dts (97%)

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +3 -0
new file mode 100644
index 000000000000..2806236484a6
@@ -0,0 +1,145 @@
+/*
+ * Samsung's Exynos4412 based Galaxy S3 board device tree source
+ *

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi line 13

Quoted 10 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +10 -0
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * Device tree source file for Samsung's Galaxy S3 boards which are based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */

One new line to make it consistent with others.

Quoted 67 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +67 -0
+/dts-v1/;
+#include "exynos4412-midas.dtsi"
+
+/ {
+       aliases {
+               i2c9 = &i2c_ak8975;
+               i2c10 = &i2c_cm36651;
+       };
+
+       regulators {
+               lcd_vdd3_reg: voltage-regulator-2 {
+                       compatible = "regulator-fixed";
+                       regulator-name = "LCD_VDD_2.2V";
+                       regulator-min-microvolt = <2200000>;
+                       regulator-max-microvolt = <2200000>;
+                       gpio = <&gpc0 1 GPIO_ACTIVE_HIGH>;
+                       enable-active-high;
+               };
+
+               ps_als_reg: voltage-regulator-5 {
+                       compatible = "regulator-fixed";
+                       regulator-name = "LED_A_3.0V";
+                       regulator-min-microvolt = <3000000>;
+                       regulator-max-microvolt = <3000000>;
+                       gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
+                       enable-active-high;
+               };
+       };
+
+       i2c_ak8975: i2c-gpio-0 {
+               compatible = "i2c-gpio";
+               gpios = <&gpy2 4 GPIO_ACTIVE_HIGH>, <&gpy2 5 GPIO_ACTIVE_HIGH>;
+               i2c-gpio,delay-us = <2>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+               status = "okay";
+
+               ak8975@c {
+                       compatible = "asahi-kasei,ak8975";
+                       reg = <0x0c>;
+                       gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
+               };
+       };
+
+       i2c_cm36651: i2c-gpio-2 {
+               compatible = "i2c-gpio";
+               gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>;
+               i2c-gpio,delay-us = <2>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               cm36651@18 {
+                       compatible = "capella,cm36651";
+                       reg = <0x18>;
+                       interrupt-parent = <&gpx0>;
+                       interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
+                       vled-supply = <&ps_als_reg>;
+               };
+       };
+};
+
+&buck9_reg {
+       maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>;
+};
+
+&cam_af_reg {
+       gpio = <&gpm0 4 GPIO_ACTIVE_HIGH>;

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi line 90

Quoted 10 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +10 -0
+       status = "okay";
+};
+
+&cam_io_reg {
+       gpio = <&gpm0 2 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};
+
+&dsi_0 {
+       status = "okay";

One new line.

Quoted 69 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +55 -0
+       panel@0 {
+               compatible = "samsung,s6e8aa0";
+               reg = <0>;
+               vdd3-supply = <&lcd_vdd3_reg>;
+               vci-supply = <&ldo25_reg>;
+               reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
+               power-on-delay= <50>;
+               reset-delay = <100>;
+               init-delay = <100>;
+               flip-horizontal;
+               flip-vertical;
+               panel-width-mm = <58>;
+               panel-height-mm = <103>;
+
+               display-timings {
+                       timing-0 {
+                               clock-frequency = <57153600>;
+                               hactive = <720>;
+                               vactive = <1280>;
+                               hfront-porch = <5>;
+                               hback-porch = <5>;
+                               hsync-len = <5>;
+                               vfront-porch = <13>;
+                               vback-porch = <1>;
+                               vsync-len = <2>;
+                       };
+               };
+       };
+};
+
+&i2c_0 {
+       status = "okay";
+};
+
+&i2c_3 {
+       status = "okay";
+
+       mms114-touchscreen@48 {
+               compatible = "melfas,mms114";
+               reg = <0x48>;
+               interrupt-parent = <&gpm2>;
+               interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+               x-size = <720>;
+               y-size = <1280>;
+               avdd-supply = <&ldo23_reg>;
+               vdd-supply = <&ldo24_reg>;
+       };
+};
+
+&ldo25_reg {
+       regulator-name = "LCD_VCC_3.3V";
+       regulator-min-microvolt = <2800000>;
+       regulator-max-microvolt = <2800000>;
+       status = "okay";
+};
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
similarity index 92%
copy from arch/arm/boot/dts/exynos4412-trats2.dts
copy to arch/arm/boot/dts/exynos4412-midas.dtsi
index f285790e8e04..384767a34fa7 100644
@@ -10,7 +10,7 @@
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
-*/
+ */
 
Quoted 9 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 25

Quoted 4 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -0
 /dts-v1/;
 #include "exynos4412.dtsi"
@@ -25,19 +25,11 @@
        compatible = "samsung,trats2", "samsung,exynos4412", "samsung,exynos4";

This looks incorrect. Not every midas board is trats2... Unless that was left here for compatibility purpose but then it would be good to see explanation.

Yes, this was my mistake. Will fix in v3.

Quoted 28 lines
Quoted 28 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -14
        aliases {
-               i2c9 = &i2c_ak8975;
-               i2c10 = &i2c_cm36651;
                i2c11 = &i2c_max77693;
                i2c12 = &i2c_max77693_fuel;
        };
 
-       memory@40000000 {
-               device_type = "memory";
-               reg =  <0x40000000 0x40000000>;
-       };
-
        chosen {
-               bootargs = "console=ttySAC2,115200N8 root=/dev/mmcblk0p5 rootwait earlyprintk panic=5";
                stdout-path = &serial_2;
        };
 
@@ -68,17 +60,8 @@
                        regulator-name = "CAM_SENSOR_A";
                        regulator-min-microvolt = <2800000>;
                        regulator-max-microvolt = <2800000>;
-                       gpio = <&gpm0 2 GPIO_ACTIVE_HIGH>;
-                       enable-active-high;
-               };
-
-               lcd_vdd3_reg: voltage-regulator-2 {
-                       compatible = "regulator-fixed";
Quoted 8 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 64

Quoted 6 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -4
-                       regulator-name = "LCD_VDD_2.2V";
-                       regulator-min-microvolt = <2200000>;
-                       regulator-max-microvolt = <2200000>;
-                       gpio = <&gpc0 1 GPIO_ACTIVE_HIGH>;
                        enable-active-high;
+                       status = "disabled";

Why disabled?

The GPIO which controls CAM_SENSOR_A differs between boards (gpm0-2 on s3, gpm0-7 on t0).

Quoted 14 lines
Quoted 14 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -6
                };
 
                cam_af_reg: voltage-regulator-3 {
@@ -86,17 +69,8 @@
                        regulator-name = "CAM_AF";
                        regulator-min-microvolt = <2800000>;
                        regulator-max-microvolt = <2800000>;
-                       gpio = <&gpm0 4 GPIO_ACTIVE_HIGH>;
-                       enable-active-high;
-               };
-
-               ps_als_reg: voltage-regulator-5 {
-                       compatible = "regulator-fixed";
Quoted 8 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 73

Quoted 6 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -4
-                       regulator-name = "LED_A_3.0V";
-                       regulator-min-microvolt = <3000000>;
-                       regulator-max-microvolt = <3000000>;
-                       gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
                        enable-active-high;
+                       status = "disabled";

Why disabled?

Same as above. gpm0-4 on s3, gpm1-1 on t0.

Quoted 91 lines
Quoted 76 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -54
                };
 
                vsil12: voltage-regulator-6 {
@@ -227,37 +201,6 @@
                };
        };
 
-       i2c_ak8975: i2c-gpio-0 {
-               compatible = "i2c-gpio";
-               gpios = <&gpy2 4 GPIO_ACTIVE_HIGH>, <&gpy2 5 GPIO_ACTIVE_HIGH>;
-               i2c-gpio,delay-us = <2>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-               status = "okay";
-
-               ak8975@c {
-                       compatible = "asahi-kasei,ak8975";
-                       reg = <0x0c>;
-                       gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
-               };
-       };
-
-       i2c_cm36651: i2c-gpio-2 {
-               compatible = "i2c-gpio";
-               gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>;
-               i2c-gpio,delay-us = <2>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-
-               cm36651@18 {
-                       compatible = "capella,cm36651";
-                       reg = <0x18>;
-                       interrupt-parent = <&gpx0>;
-                       interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
-                       vled-supply = <&ps_als_reg>;
-               };
-       };
-
        i2c-mhl {
                compatible = "i2c-gpio";
                gpios = <&gpf0 4 GPIO_ACTIVE_HIGH>, <&gpf0 6 GPIO_ACTIVE_HIGH>;
@@ -296,8 +239,6 @@
                                  <&clock CLK_MOUT_CAM1>;
                assigned-clock-parents = <&clock CLK_XUSBXTI>,
                                         <&clock CLK_XUSBXTI>;
-
-
        };
 
        wlan_pwrseq: sdhci3-pwrseq {
@@ -454,36 +395,7 @@
        samsung,burst-clock-frequency = <500000000>;
        samsung,esc-clock-frequency = <20000000>;
        samsung,pll-clock-frequency = <24000000>;
-       status = "okay";
-
-       panel@0 {
-               compatible = "samsung,s6e8aa0";
-               reg = <0>;
-               vdd3-supply = <&lcd_vdd3_reg>;
-               vci-supply = <&ldo25_reg>;
-               reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
-               power-on-delay= <50>;
-               reset-delay = <100>;
-               init-delay = <100>;
-               flip-horizontal;
-               flip-vertical;
-               panel-width-mm = <58>;
-               panel-height-mm = <103>;
-
-               display-timings {
-                       timing-0 {
-                               clock-frequency = <57153600>;
-                               hactive = <720>;
-                               vactive = <1280>;

arch/arm/boot/dts/exynos4412-midas.dtsi line 398

Quoted 10 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -9
-                               hfront-porch = <5>;
-                               hback-porch = <5>;
-                               hsync-len = <5>;
-                               vfront-porch = <13>;
-                               vback-porch = <1>;
-                               vsync-len = <2>;
-                       };
-               };
-       };
+       status = "disabled";

It is already disabled by exynos4.dtsi, no need to duplicate properties.

Quoted 2 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -0
 };
 
Quoted 10 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 518

Quoted 7 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
 &exynos_usbphy {
@@ -603,7 +515,7 @@
        samsung,i2c-max-bus-freq = <400000>;
        pinctrl-0 = <&i2c0_bus>;
        pinctrl-names = "default";
-       status = "okay";
+       status = "disabled";

I do not get this node. It sits in midas.dtsi and s3.dtsi just enables it. Why not enabling it here?

Initially, I thought that T0 had some extra regulator that needed to be enabled, but in reality it's just a different vdda supply - so vdda should be moved down to galaxy-s3

Quoted 32 lines
Quoted 24 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -12
        s5c73m3@3c {
                compatible = "samsung,s5c73m3";
@@ -635,18 +547,7 @@
        samsung,i2c-max-bus-freq = <400000>;
        pinctrl-0 = <&i2c3_bus>;
        pinctrl-names = "default";
-       status = "okay";
-
-       mms114-touchscreen@48 {
-               compatible = "melfas,mms114";
-               reg = <0x48>;
-               interrupt-parent = <&gpm2>;
-               interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
-               x-size = <720>;
-               y-size = <1280>;
-               avdd-supply = <&ldo23_reg>;
-               vdd-supply = <&ldo24_reg>;
-       };
+       status = "disabled";
 };
 
 &i2c_4 {

arch/arm/boot/dts/exynos4412-midas.dtsi line 731

Quoted 4 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -0
@@ -827,6 +728,7 @@
                                regulator-name = "CAM_SENSOR_CORE_1.2V";
                                regulator-min-microvolt = <1200000>;
                                regulator-max-microvolt = <1200000>;
+                               status = "okay";

Regulator should not be disabled or enabled. It is not a device. I do not get the logic behind...

Quoted 6 lines

The ''status = disabled" usually is added in DTSI files to nodes which are not fully configured at this point, e.g. they require external resources (clocks, regulators). These external resources will be provided when extending in DTS (or further DTSI) while enabling it. However regulator has always all necessary resources.

Ack. This one shouldn't be here.

Quoted 6 lines
Quoted 6 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -0
                        };
 
                        ldo18_reg: LDO18 {
@@ -874,9 +776,7 @@
                        };
 
Quoted 7 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 779

Quoted 5 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -3
                        ldo25_reg: LDO25 {
-                               regulator-name = "LCD_VCC_3.3V";
-                               regulator-min-microvolt = <2800000>;
-                               regulator-max-microvolt = <2800000>;
+                               status = "disabled";

Ditto.

In this case, s3 and t0 have different regulator voltages/names (3.0V vs 2.8V), but it doesn't really seem to make sense to me to leave ldo25 out of the common dts altogether, since it's there on all boards. If you would prefer, I can remove ldo25 and leave it completely in the t0/s3 config files

Quoted 3 lines

Best regards,
Krzysztof

Cheers,
Simon

#15 lore raw

Re: [PATCH v3 2/4] ARM: dts: split trats2 DTS in preparation for midas boards

On Wed, Dec 20, 2017 at 4:27 PM, Simon Shields <[email protected]> wrote:

(...)

Quoted 19 lines
Quoted 10 lines
Quoted 10 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -6
@@ -68,17 +60,8 @@
                        regulator-name = "CAM_SENSOR_A";
                        regulator-min-microvolt = <2800000>;
                        regulator-max-microvolt = <2800000>;
-                       gpio = <&gpm0 2 GPIO_ACTIVE_HIGH>;
-                       enable-active-high;
-               };
-
-               lcd_vdd3_reg: voltage-regulator-2 {
-                       compatible = "regulator-fixed";
Quoted 8 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 64

Quoted 6 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -4
-                       regulator-name = "LCD_VDD_2.2V";
-                       regulator-min-microvolt = <2200000>;
-                       regulator-max-microvolt = <2200000>;
-                       gpio = <&gpc0 1 GPIO_ACTIVE_HIGH>;
                        enable-active-high;
+                       status = "disabled";

Why disabled?

Quoted 2 lines

The GPIO which controls CAM_SENSOR_A differs between boards (gpm0-2 on s3, gpm0-7 on t0).

Hmm, okay, makes sense then.

Quoted 126 lines
Quoted 15 lines
Quoted 15 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -6
                };
 
                cam_af_reg: voltage-regulator-3 {
@@ -86,17 +69,8 @@
                        regulator-name = "CAM_AF";
                        regulator-min-microvolt = <2800000>;
                        regulator-max-microvolt = <2800000>;
-                       gpio = <&gpm0 4 GPIO_ACTIVE_HIGH>;
-                       enable-active-high;
-               };
-
-               ps_als_reg: voltage-regulator-5 {
-                       compatible = "regulator-fixed";
Quoted 8 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 73

Quoted 6 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -4
-                       regulator-name = "LED_A_3.0V";
-                       regulator-min-microvolt = <3000000>;
-                       regulator-max-microvolt = <3000000>;
-                       gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
                        enable-active-high;
+                       status = "disabled";

Why disabled?

Same as above. gpm0-4 on s3, gpm1-1 on t0.

Quoted 91 lines
Quoted 76 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -54
                };
 
                vsil12: voltage-regulator-6 {
@@ -227,37 +201,6 @@
                };
        };
 
-       i2c_ak8975: i2c-gpio-0 {
-               compatible = "i2c-gpio";
-               gpios = <&gpy2 4 GPIO_ACTIVE_HIGH>, <&gpy2 5 GPIO_ACTIVE_HIGH>;
-               i2c-gpio,delay-us = <2>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-               status = "okay";
-
-               ak8975@c {
-                       compatible = "asahi-kasei,ak8975";
-                       reg = <0x0c>;
-                       gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
-               };
-       };
-
-       i2c_cm36651: i2c-gpio-2 {
-               compatible = "i2c-gpio";
-               gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>;
-               i2c-gpio,delay-us = <2>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-
-               cm36651@18 {
-                       compatible = "capella,cm36651";
-                       reg = <0x18>;
-                       interrupt-parent = <&gpx0>;
-                       interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
-                       vled-supply = <&ps_als_reg>;
-               };
-       };
-
        i2c-mhl {
                compatible = "i2c-gpio";
                gpios = <&gpf0 4 GPIO_ACTIVE_HIGH>, <&gpf0 6 GPIO_ACTIVE_HIGH>;
@@ -296,8 +239,6 @@
                                  <&clock CLK_MOUT_CAM1>;
                assigned-clock-parents = <&clock CLK_XUSBXTI>,
                                         <&clock CLK_XUSBXTI>;
-
-
        };
 
        wlan_pwrseq: sdhci3-pwrseq {
@@ -454,36 +395,7 @@
        samsung,burst-clock-frequency = <500000000>;
        samsung,esc-clock-frequency = <20000000>;
        samsung,pll-clock-frequency = <24000000>;
-       status = "okay";
-
-       panel@0 {
-               compatible = "samsung,s6e8aa0";
-               reg = <0>;
-               vdd3-supply = <&lcd_vdd3_reg>;
-               vci-supply = <&ldo25_reg>;
-               reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
-               power-on-delay= <50>;
-               reset-delay = <100>;
-               init-delay = <100>;
-               flip-horizontal;
-               flip-vertical;
-               panel-width-mm = <58>;
-               panel-height-mm = <103>;
-
-               display-timings {
-                       timing-0 {
-                               clock-frequency = <57153600>;
-                               hactive = <720>;
-                               vactive = <1280>;

arch/arm/boot/dts/exynos4412-midas.dtsi line 398

Quoted 10 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -9
-                               hfront-porch = <5>;
-                               hback-porch = <5>;
-                               hsync-len = <5>;
-                               vfront-porch = <13>;
-                               vback-porch = <1>;
-                               vsync-len = <2>;
-                       };
-               };
-       };
+       status = "disabled";

It is already disabled by exynos4.dtsi, no need to duplicate properties.

Quoted 2 lines
(quoted diff) +0 -0
 };
 
Quoted 10 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 518

Quoted 7 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
 &exynos_usbphy {
@@ -603,7 +515,7 @@
        samsung,i2c-max-bus-freq = <400000>;
        pinctrl-0 = <&i2c0_bus>;
        pinctrl-names = "default";
-       status = "okay";
+       status = "disabled";

I do not get this node. It sits in midas.dtsi and s3.dtsi just enables it. Why not enabling it here?

Quoted 3 lines

Initially, I thought that T0 had some extra regulator that needed to be enabled, but in reality it's just a different vdda supply - so vdda should be moved down to galaxy-s3

Yes, please and then only for s5c73m3@3c. The i2c node should stay enabled, I think.

Quoted 56 lines
Quoted 33 lines
Quoted 25 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -12
        s5c73m3@3c {
                compatible = "samsung,s5c73m3";
@@ -635,18 +547,7 @@
        samsung,i2c-max-bus-freq = <400000>;
        pinctrl-0 = <&i2c3_bus>;
        pinctrl-names = "default";
-       status = "okay";
-
-       mms114-touchscreen@48 {
-               compatible = "melfas,mms114";
-               reg = <0x48>;
-               interrupt-parent = <&gpm2>;
-               interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
-               x-size = <720>;
-               y-size = <1280>;
-               avdd-supply = <&ldo23_reg>;
-               vdd-supply = <&ldo24_reg>;
-       };
+       status = "disabled";
 };
 
 &i2c_4 {

arch/arm/boot/dts/exynos4412-midas.dtsi line 731

Quoted 4 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -0
@@ -827,6 +728,7 @@
                                regulator-name = "CAM_SENSOR_CORE_1.2V";
                                regulator-min-microvolt = <1200000>;
                                regulator-max-microvolt = <1200000>;
+                               status = "okay";

Regulator should not be disabled or enabled. It is not a device. I do not get the logic behind...

Quoted 6 lines

The ''status = disabled" usually is added in DTSI files to nodes which are not fully configured at this point, e.g. they require external resources (clocks, regulators). These external resources will be provided when extending in DTS (or further DTSI) while enabling it. However regulator has always all necessary resources.

Ack. This one shouldn't be here.

Quoted 6 lines
Quoted 6 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +0 -0
                        };
 
                        ldo18_reg: LDO18 {
@@ -874,9 +776,7 @@
                        };
 
Quoted 7 lines

arch/arm/boot/dts/exynos4412-midas.dtsi line 779

Quoted 5 lines
arch/arm/boot/dts/exynos4412-midas.dtsi renamed from arch/arm/boot/dts/exynos4412-trats2.dts +1 -3
                        ldo25_reg: LDO25 {
-                               regulator-name = "LCD_VCC_3.3V";
-                               regulator-min-microvolt = <2800000>;
-                               regulator-max-microvolt = <2800000>;
+                               status = "disabled";

Ditto.

Quoted 5 lines

In this case, s3 and t0 have different regulator voltages/names (3.0V vs 2.8V), but it doesn't really seem to make sense to me to leave ldo25 out of the common dts altogether, since it's there on all boards. If you would prefer, I can remove ldo25 and leave it completely in the t0/s3 config files

So leave empty ldo25, like:

ldo25_reg: LDO25 {
    regulator-name = "LDO25";
};

Something like buck8_reg in arch/arm/boot/dts/exynos4412-odroid-common.dtsi. The point is to provide entire description of max77686 regulators in basic DTSI. The driver anyway knows the constraints (min/max voltages) so in case of missing entries in DTS, default will be applied. Then in child-DTS you can customize the voltage and/or name to necessary value.

Best regards,
Krzysztof

A message that is not in the archive (sent off-list or not yet received): CAJKOXPdzAvsaAOo6P+UA8VWYd7YjmtSqtkyKtNaz7jNdUXUH4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#17 lore raw

Re: [PATCH v3 2/4] ARM: dts: split trats2 DTS in preparation for midas boards

Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi        |  145 ++
 ...exynos4412-trats2.dts => exynos4412-midas.dtsi} |  117 +-
 arch/arm/boot/dts/exynos4412-trats2.dts            | 1446 +-------------------
 3 files changed, 184 insertions(+), 1524 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 copy arch/arm/boot/dts/{exynos4412-trats2.dts => exynos4412-midas.dtsi} (92%)

rewrite arch/arm/boot/dts/exynos4412-trats2.dts (97%)

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +7 -0
new file mode 100644
index 000000000000..2806236484a6
@@ -0,0 +1,145 @@
+/*
+ * Samsung's Exynos4412 based Galaxy S3 board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * Device tree source file for Samsung's Galaxy S3 boards which are based on
Quoted 8 lines

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi line 13

Quoted 6 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +6 -0
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */

One new line to make it consistent with others.

If you're going to change it, use an SPDX tag.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#18 lore raw

Re: [PATCH v3 2/4] ARM: dts: split trats2 DTS in preparation for midas boards

Hi Rob,

Quoted 37 lines · Rob Herring
Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi        |  145 ++
 ...exynos4412-trats2.dts => exynos4412-midas.dtsi} |  117 +-
 arch/arm/boot/dts/exynos4412-trats2.dts            | 1446 +-------------------
 3 files changed, 184 insertions(+), 1524 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 copy arch/arm/boot/dts/{exynos4412-trats2.dts => exynos4412-midas.dtsi} (92%)

rewrite arch/arm/boot/dts/exynos4412-trats2.dts (97%)

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +7 -0
new file mode 100644
index 000000000000..2806236484a6
@@ -0,0 +1,145 @@
+/*
+ * Samsung's Exynos4412 based Galaxy S3 board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * Device tree source file for Samsung's Galaxy S3 boards which are based on
Quoted 8 lines

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi line 13

Quoted 6 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +6 -0
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */

One new line to make it consistent with others.

Quoted 2 lines

If you're going to change it, use an SPDX tag.

I initially did this in v2[1], but Krzysztof said to keep the trats2 copyright header, since the galaxy-s3 dts is a subset of the old trats2 DTS. Is adding the SPDX tag and keeping the Samsung copyright stanza the preferred approach here?

[1]: https://patchwork.kernel.org/patch/10111971/

Quoted 1 line

Rob

Cheers,
Simon

#19 lore raw

Re: [PATCH v3 2/4] ARM: dts: split trats2 DTS in preparation for midas boards

Quoted 43 lines · Simon Shields

Hi Rob,

Quoted 37 lines · Rob Herring
Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi        |  145 ++
 ...exynos4412-trats2.dts => exynos4412-midas.dtsi} |  117 +-
 arch/arm/boot/dts/exynos4412-trats2.dts            | 1446 +-------------------
 3 files changed, 184 insertions(+), 1524 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 copy arch/arm/boot/dts/{exynos4412-trats2.dts => exynos4412-midas.dtsi} (92%)

rewrite arch/arm/boot/dts/exynos4412-trats2.dts (97%)

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +7 -0
new file mode 100644
index 000000000000..2806236484a6
@@ -0,0 +1,145 @@
+/*
+ * Samsung's Exynos4412 based Galaxy S3 board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * Device tree source file for Samsung's Galaxy S3 boards which are based on
Quoted 8 lines

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi line 13

Quoted 6 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +6 -0
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */

One new line to make it consistent with others.

Quoted 2 lines

If you're going to change it, use an SPDX tag.

Quoted 8 lines

I initially did this in v2[1], but Krzysztof said to keep the trats2 copyright header, since the galaxy-s3 dts is a subset of the old trats2 DTS. Is adding the SPDX tag and keeping the Samsung copyright stanza the preferred approach here?

[1]: https://patchwork.kernel.org/patch/10111971/

Quoted 1 line

Rob

Yes, but I was referring only to copyright header. The SPDX tag replaces the license, not the copyright.

Best regards,
Krzysztof

#20 lore raw

PATCH v3 4/4 ARM: exynos: extend cpuidle support to midas boards

In reply to Simon Shields

Exynos4412 can only use cpuidle when running under a compatible bootloader/firmware. The midas family of boards, including trats2, have such a firmware, so allow them to use cpuidle.

Leave the trats2 check there in order to preserve the ABI.

---
 arch/arm/mach-exynos/exynos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-exynos/exynos.c +2 -1
index 9a9caac1125a..4ee60e31ea48 100644
@@ -196,7 +196,8 @@ static void __init exynos_dt_machine_init(void)
 #endif
 	if (of_machine_is_compatible("samsung,exynos4210") ||
 	    (of_machine_is_compatible("samsung,exynos4412") &&
-	     of_machine_is_compatible("samsung,trats2")) ||
+	     (of_machine_is_compatible("samsung,trats2") ||
+		  of_machine_is_compatible("samsung,midas"))) ||
 	    of_machine_is_compatible("samsung,exynos3250") ||
 	    of_machine_is_compatible("samsung,exynos5250"))
 		platform_device_register(&exynos_cpuidle);
Signature · 1 line
2.15.1