Skip to contentSkip to conversation

uboot: add option customizing the name of environment image

PATCH New Evgeniy Didin 3 participants 3 messages Dec 18, 2017 – Apr 1, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uboot: add option customizing the name of environment image

Historically, in buildroot the name of binary environment image file is "uboot-env.bin". But in upstream u-boot default name for this file is "uboot.env":

http://git.denx.de/?p=u-boot.git;a=blob;f=env/Kconfig#l394

For some boards U-Boot environment is stored in FAT partition, not as a raw blob on SD-card, so the name of environment file must be correct. For customizing name of envimage file option BR2_TARGET_UBOOT_ENVIMAGE_FILENAME has been added. For backward compatibility by default value of this option is set to "uboot-env.bin".

Cc Alexey Brodkin <[email protected]>
Cc arc-buildroot at synopsys.com
Cc Thomas Petazzoni <[email protected]>
---
 boot/uboot/Config.in | 8 ++++++++
 boot/uboot/uboot.mk  | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
boot/uboot/Config.in +8 -0
index 2829d2ca5e..e05ae15238 100644
@@ -430,6 +430,14 @@ config BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT
 	  Buildroot is compatible with the "redundant environment"
 	  mechanism of U-Boot.
 
+config BR2_TARGET_UBOOT_ENVIMAGE_FILENAME
+	string "Custom filename for environment image"
+	default "uboot-env.bin"
+	help
+	  Some platforms require setting custom name for U-Boot
+	  environment image. For backward compatibility
+	  default filename is "uboot-env.bin".
+
 endif # BR2_TARGET_UBOOT_ENVIMAGE
 
 config BR2_TARGET_UBOOT_BOOT_SCRIPT
boot/uboot/uboot.mk +1 -1
index d2f241cd8b..5ebd1df89d 100644
@@ -250,7 +250,7 @@ define UBOOT_GENERATE_ENV_IMAGE
 	$(HOST_DIR)/bin/mkenvimage -s $(BR2_TARGET_UBOOT_ENVIMAGE_SIZE) \
 		$(if $(BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT),-r) \
 		$(if $(filter BIG,$(BR2_ENDIAN)),-b) \
-		-o $(BINARIES_DIR)/uboot-env.bin \
+		-o $(BINARIES_DIR)/$(BR2_TARGET_UBOOT_ENVIMAGE_FILENAME) \
 		$(@D)/buildroot-env.txt
 endef
 endif
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 uboot: add option customizing the name of environment image

Evgeniy,

Quoted 6 lines · Evgeniy Didin

Historically, in buildroot the name of binary environment image file is "uboot-env.bin". But in upstream u-boot default name for this file is "uboot.env":

http://git.denx.de/?p=u-boot.git;a=blob;f=env/Kconfig#l394

Quoted 7 lines

For some boards U-Boot environment is stored in FAT partition, not as a raw blob on SD-card, so the name of environment file must be correct. For customizing name of envimage file option BR2_TARGET_UBOOT_ENVIMAGE_FILENAME has been added. For backward compatibility by default value of this option is set to "uboot-env.bin".

Signature · 7 lines
Bryce Ferguson
Software Engineer
Airborne Information Solutions \ RC Linux Platform

400 Collins Rd NE Cedar Rapids, Iowa 52498

Bryce.Ferguson at rockwellcollins.com
#2 lore raw

PATCH 1/1 uboot: add option customizing the name of environment image

In reply to Evgeniy Didin

Hello,

Quoted 12 lines · Evgeniy Didin

Historically, in buildroot the name of binary environment image file is "uboot-env.bin". But in upstream u-boot default name for this file is "uboot.env":

http://git.denx.de/?p=u-boot.git;a=blob;f=env/Kconfig#l394

For some boards U-Boot environment is stored in FAT partition, not as a raw blob on SD-card, so the name of environment file must be correct. For customizing name of envimage file option BR2_TARGET_UBOOT_ENVIMAGE_FILENAME has been added. For backward compatibility by default value of this option is set to "uboot-env.bin".

Quoted 8 lines
Cc Alexey Brodkin <[email protected]>
Cc arc-buildroot at synopsys.com
Cc Thomas Petazzoni <[email protected]>
---
 boot/uboot/Config.in | 8 ++++++++
 boot/uboot/uboot.mk  | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

In the mean time, we merged the ARC HS Development Kit development kit, and the rename of the u-boot environment image is done directly by genimage:

+image boot.vfat {
+ vfat {
+ files = {
+ "uImage"
+ }
+ file uboot.env {
+ image = "uboot-env.bin"
+ }
+ }
+ size = 100M
+}

This makes this patch no longer useful, so I've marked it as Rejected in our patch tracking system. Let me know if you disagree for some reason. Thanks!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com