Skip to contentSkip to conversation

utils/scanpypi: increase error message verbosity

PATCH New Alexey Roslyakov 3 participants 5 messages Dec 18, 2017

lore
Share & tools
lore

Alexey Roslyakov

author
#0 lore raw

PATCH 1/1 utils/scanpypi: increase error message verbosity

When package installation fails it is good to know what happened.

Signed-off-by Alexey Roslyakov <[email protected]>
---
 utils/scanpypi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
utils/scanpypi +3 -3
index 02384f2569..939c26a187 100755
@@ -608,9 +608,9 @@ def main():
                 else:
                     raise
                 continue
-            except AttributeError:
-                print('Error: Could not install package {pkg}'.format(
-                    pkg=package.real_name))
+            except AttributeError as error:
+                print('Error: Could not install package {pkg}: {error}'.format(
+                    pkg=package.real_name, error=error))
                 continue
 
             # Package requirement are an argument of the setup function
Signature · 1 line
2.13.6
#1 lore raw

PATCH 1/1 utils/scanpypi: increase error message verbosity

Hi Alexey,

Quoted 3 lines · Alexey Roslyakov

When package installation fails it is good to know what happened.

Signed-off-by Alexey Roslyakov <[email protected]>

Nice catch.

Reviewed-by Yegor Yefremov <[email protected]>

Yegor

Quoted 24 lines
---
 utils/scanpypi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
utils/scanpypi +3 -4
index 02384f2569..939c26a187 100755
@@ -608,9 +608,9 @@ def main():
                 else:
                     raise
                 continue
-            except AttributeError:
-                print('Error: Could not install package {pkg}'.format(
-                    pkg=package.real_name))
+            except AttributeError as error:
+                print('Error: Could not install package {pkg}: {error}'.format(
+                    pkg=package.real_name, error=error))
                 continue
 
             # Package requirement are an argument of the setup function
--

2.13.6

Applied
#2 lore raw

PATCH 1/1 utils/scanpypi: increase error message verbosity

In reply to Alexey Roslyakov

Hello,

Quoted 6 lines · Alexey Roslyakov

When package installation fails it is good to know what happened.

Signed-off-by Alexey Roslyakov <[email protected]>
---
 utils/scanpypi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 utils/scanpypi: increase error message verbosity

Quoted 11 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · Alexey Roslyakov

When package installation fails it is good to know what happened.

Signed-off-by Alexey Roslyakov <[email protected]>
---
 utils/scanpypi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

@Alexey do you have more scanpypi patches in the queue? I've reworked the license type detection [1]. I'd also like to add licence file checksum to the *.hash file creation.

[1] http://patchwork.ozlabs.org/patch/837807/

Yegor

author
#4 lore raw

PATCH 1/1 utils/scanpypi: increase error message verbosity

Yegor,
no, I don't have anything at the moment.

All best.

Quoted 22 lines · Yegor Yefremov
Quoted 11 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · Alexey Roslyakov

When package installation fails it is good to know what happened.

Signed-off-by Alexey Roslyakov <[email protected]>
---
 utils/scanpypi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

@Alexey do you have more scanpypi patches in the queue? I've reworked the license type detection [1]. I'd also like to add licence file checksum to the *.hash file creation.

[1] http://patchwork.ozlabs.org/patch/837807/

Yegor

Signature · 6 lines
With best regards,
  Alexey Roslyakov
Email: alexey.roslyakov at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171219/6bb1d959/attachment.html>