package/brltty: disable features and add optional dependencies
PATCH 1/1 package/brltty: disable features and add optional dependencies
* --without-midi-package should fix a number of autobuild failures.
* Disable a number of speech drivers to avoid build failures if they are installed on the host.
* Optional dependency on espeak and flite fixes builds where espeak or flite are installed on the host.
--- package/brltty/brltty.mk | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)
package/brltty/brltty.mk +18 -1
@@ -18,7 +18,10 @@ BRLTTY_CONF_OPTS = \ --disable-lisp-bindings \ --disable-ocaml-bindings \ --disable-python-bindings \ - --disable-tcl-bindings + --disable-tcl-bindings \ + --without-midi-package \ + --without-mikropuhe --without-speechd --without-swift \ + --without-theta --without-viavoice ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y) BRLTTY_DEPENDENCIES += bluez5_utils
@@ -27,6 +30,20 @@ else BRLTTY_CONF_OPTS += --without-bluetooth-package endif +ifeq ($(BR2_PACKAGE_ESPEAK),y) +BRLTTY_DEPENDENCIES += espeak +BRLTTY_CONF_OPTS += --with-espeak=$(TARGET_DIR)/usr +else +BRLTTY_CONF_OPTS += --without-espeak +endif + +ifeq ($(BR2_PACKAGE_FLITE),y) +BRLTTY_DEPENDENCIES += flite +BRLTTY_CONF_OPTS += --with-flite=$(STAGING_DIR)/usr +else +BRLTTY_CONF_OPTS += --without-flite +endif + ifeq ($(BR2_PACKAGE_ICU),y) BRLTTY_DEPENDENCIES += icu BRLTTY_CONF_OPTS += --enable-icu
Signature · 1 line
2.15.0
PATCH 1/1 package/brltty: disable features and add optional dependencies
Hello,
Thanks for this fixup patch. A few comments/questions below.
Quoted 1 line · Mario Lang
* --without-midi-package should fix a number of autobuild failures.
Which ones? We like to have references to autobuilder failures.
Quoted 4 lines
* Disable a number of speech drivers to avoid build failures if they are installed on the host.
* Optional dependency on espeak and flite fixes builds where espeak or flite are installed on the host.
Autobuilder failure references ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 package/brltty: disable features and add optional dependencies
Quoted 4 lines · Thomas Petazzoni
Quoted 1 line · Mario Lang
* --without-midi-package should fix a number of autobuild failures.
Which ones? We like to have references to autobuilder failures.
At least these two:
http://autobuild.buildroot.net/results/0c4f557c2ad276b1ed065119532af37c0af5f014
http://autobuild.buildroot.net/results/ea82b7c7732821368746ddddb5d529e97c9b6c16
Quoted 6 lines
Quoted 4 lines
* Disable a number of speech drivers to avoid build failures if they are installed on the host.
* Optional dependency on espeak and flite fixes builds where espeak or flite are installed on the host.Autobuilder failure references ?
These failures didn't show up on any autobuilder, as autobuilders typically don't have commercial speech synthesizers or espeak/flite installed on the host. But these build failures showed up during builds of BRLTTY users. In particular, espeak, flite and speechd were accidentally picked up from the host during configure.
Signature · 6 lines
CYa, ????? | Blog: <https://blind.guru/> GitHub: <https://github.com/mlang/> .''`. | Twitter: @blindbird23 FaceBook: disyled : :' : | SoundCloud: <soundcloud.com/mario-lang> `. `' | YouTube: <youtube.com/user/mlang23> `-
PATCH 1/1 package/brltty: disable features and add optional dependencies
In reply to Mario LangHello,
Quoted 10 lines · Mario Lang
* --without-midi-package should fix a number of autobuild failures.
* Disable a number of speech drivers to avoid build failures if they are installed on the host.
* Optional dependency on espeak and flite fixes builds where espeak or flite are installed on the host.Signed-off-by Mario Lang <[email protected]>--- package/brltty/brltty.mk | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)
Applied to master after adding the references to the autobuilder failures.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com