perf: Don't make sourced script executable

PATCH New Laura Abbott 1 participant 1 message Dec 19, 2017 perf events

lore

Share & tools

lore

Laura Abbott

author

2017-12-19 19:57 UTC #0 lore raw

PATCH 2/2 perf: Don't make sourced script executable

rpm lint flagged this:

perf.x86_64: E: executable-sourced-script /etc/bash_completion.d/perf 755

Make this not be executable

Signed-off-by Laura Abbott <[email protected]>

---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/perf/Makefile.perf +1 -1

index 68cf1360a3f3..a072790f5fad 100644
@@ -789,7 +789,7 @@ ifndef NO_LIBPYTHON
 endif
 	$(call QUIET_INSTALL, perf_completion-script) \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \
-		$(INSTALL) perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
+		$(INSTALL) -m 644 perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
 	$(call QUIET_INSTALL, perf-tip) \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(tip_instdir_SQ)'; \
 		$(INSTALL) Documentation/tips.txt -t '$(DESTDIR_SQ)$(tip_instdir_SQ)'

Signature · 1 line

2.14.3