Skip to contentSkip to conversation

runltp: skipfile: skipped test cases should be visible as TCONF in results

PATCH New Naresh Kamboju 2 participants 2 messages Dec 20, 2017

lore
Share & tools
lore

Naresh Kamboju

author
#0 lore raw

PATCH 1/1 runltp: skipfile: skipped test cases should be visible as TCONF in results

When we skip tests in LTP by using "./runltp -S SKIPFILE", they get removed from the test list completely, leaving no trace in the results.

This patch will add SKIPFILE listed test cases names to results as TCONF. when testcase_name listed in SKIPFILE the main alltests will get that testcase_name followed by exit 32;

Example:
SKIPFILE the user defined content

  $ cat SKIPFILE
  testcase_name
  $ ./runltp -f syscalls -S SKIPFILE

The runtime generated alltests file gets as

  $ cat alltests
  testcase_name exit 32;

The final results file shows as

  $ cat results
  testcase_name TCONF

The good practise with SKIPFILE is,
tests listed in a SKIPFILE should be a single testcase_name per line. However, test script takes only first column by using awk {print $1}

We can add comments inside SKIPFILE starting with # The script will ignore line starting with #

Signed-off-by Naresh Kamboju <[email protected]>
---
 runltp        | 8 ++++----
 runltplite.sh | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)
runltp +4 -4
index 8e40d67..302c4a7 100755
@@ -692,10 +692,10 @@ main()
     fi
 
     # Blacklist or skip tests if a SKIPFILE was specified with -S
-    if [ -n "$SKIPFILE" ]
-    then
-        for file in $( cat $SKIPFILE ); do
-            sed -i "/^$file[ \t]/d" ${TMP}/alltests
+    if [ -n "${SKIPFILE}" ]; then
+        for test_name in $(awk '{print $1}' "${SKIPFILE}"); do
+            case "${test_name}" in \#*) continue;; esac
+            sed -i "/\<${test_name}\>/c\\${test_name} exit 32;" alltests
         done
     fi
runltplite.sh +4 -4
index 9313649..17be009 100755
@@ -316,10 +316,10 @@ main()
     }
 
     # Blacklist or skip tests if a SKIPFILE was specified with -S
-    if [ -n "$SKIPFILE" ]
-    then
-        for file in $( cat $SKIPFILE ); do
-            sed -i "/^$file[ \t]/d" ${TMP}/alltests
+    if [ -n "${SKIPFILE}" ]; then
+        for test_name in $(awk '{print $1}' "${SKIPFILE}"); do
+            case "${test_name}" in \#*) continue;; esac
+            sed -i "/\<${test_name}\>/c\\${test_name} exit 32;" alltests
         done
     fi
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 runltp: skipfile: skipped test cases should be visible as TCONF in results

Hi!
Pushed, thanks.

Signature · 2 lines
Cyril Hrubis
[email protected]