ia64: agp: Replace empty define with do while
PATCH 1/1 ia64: agp: Replace empty define with do while
It's dangerous to use empty code define.
Furthermore it lead to the following warning:drivers/char/agp/generic.c: In function « agp_generic_destroy_page »:drivers/char/agp/generic.c:1266:28: attention : suggest braces around empty body in an « if » statement [-Wempty-body]
So let's replace emptyness by "do {} while(0)"
Signed-off-by Corentin Labbe <[email protected]>
--- arch/ia64/include/asm/agp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/ia64/include/asm/agp.h +2 -2
@@ -14,8 +14,8 @@* in coherent mode, which lets us map the AGP memory as normal (write-back) memory * (unlike x86, where it gets mapped "write-coalescing"). */ -#define map_page_into_agp (page)/* nothing */ -#define unmap_page_from_agp (page)/* nothing */ +#define map_page_into_agp (page) do { } while (0) +#define unmap_page_from_agp (page) do { } while (0)#define flush_agp_cache () mb()/* GATT allocation. Returns/accepts GATT kernel virtual address. */
Signature · 1 line
2.13.6
Quoted 8 lines · Corentin Labbe
It's dangerous to use empty code define.
Furthermore it lead to the following warning:drivers/char/agp/generic.c: In function « agp_generic_destroy_page »:drivers/char/agp/generic.c:1266:28: attention : suggest braces around empty body in an « if » statement [-Wempty-body]So let's replace emptyness by "do {} while(0)"
Signed-off-by Corentin Labbe <[email protected]>
Hello
Gentle ping
Regards
Quoted 22 lines
--- arch/ia64/include/asm/agp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/ia64/include/asm/agp.h +2
-2@@ -14,8 +14,8 @@* in coherent mode, which lets us map the AGP memory as normal (write-back) memory * (unlike x86, where it gets mapped "write-coalescing"). */ -#define map_page_into_agp (page)/* nothing */ -#define unmap_page_from_agp (page)/* nothing */ +#define map_page_into_agp (page) do { } while (0) +#define unmap_page_from_agp (page) do { } while (0)#define flush_agp_cache () mb()/* GATT allocation. Returns/accepts GATT kernel virtual address. */ Signature · 1 line
2.13.6