Skip to contentSkip to conversation

arm64: dts: exynos: Use lower case hex addresses in node unit addresses

PATCH In review Krzysztof Kozlowski 2 participants 4 messages Dec 20, 2017 – Dec 21, 2017

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/2 arm64: dts: exynos: Use lower case hex addresses in node unit addresses

Convert all hex addresses in node unit addresses to lower case to
fix warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2e.dtb: Warning (simple_bus_reg):
Node /soc/video-scaler at 13C00000 simple-bus unit address format error, expected "13c00000"

Conversion was done using sed:

    $ sed -e 's/@\([a-zA-Z0-9_-]*\) {/@\L\1 {/' -i arch/arm64/boot/dts/exynos/*.dts*
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 8 ++++----
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +4 -4
index 1962b8074349..0ba5df825eff 100644
@@ -994,7 +994,7 @@
 			reg = <0x145f0000 0x1038>;
 		};
 
-		gsc_0: video-scaler at 13C00000 {
+		gsc_0: video-scaler at 13c00000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c00000 0x1000>;
 			interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
@@ -1008,7 +1008,7 @@
 			power-domains = <&pd_gscl>;
 		};
 
-		gsc_1: video-scaler at 13C10000 {
+		gsc_1: video-scaler at 13c10000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c10000 0x1000>;
 			interrupts = <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>;
@@ -1022,7 +1022,7 @@
 			power-domains = <&pd_gscl>;
 		};
 
-		gsc_2: video-scaler at 13C20000 {
+		gsc_2: video-scaler at 13c20000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c20000 0x1000>;
 			interrupts = <GIC_SPI 299 IRQ_TYPE_LEVEL_HIGH>;
@@ -1049,7 +1049,7 @@
 			power-domains = <&pd_mscl>;
 		};
 
-		mfc: codec at 152E0000 {
+		mfc: codec at 152e0000 {
 			compatible = "samsung,exynos5433-mfc";
 			reg = <0x152E0000 0x10000>;
 			interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
arch/arm64/boot/dts/exynos/exynos7.dtsi +2 -2
index 9a3fbed1765a..3504837b1d43 100644
@@ -103,7 +103,7 @@
 			#size-cells = <1>;
 			ranges;
 
-			pdma0: pdma at 10E10000 {
+			pdma0: pdma at 10e10000 {
 				compatible = "arm,pl330", "arm,primecell";
 				reg = <0x10E10000 0x1000>;
 				interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
@@ -114,7 +114,7 @@
 				#dma-requests = <32>;
 			};
 
-			pdma1: pdma at 10EB0000 {
+			pdma1: pdma at 10eb0000 {
 				compatible = "arm,pl330", "arm,primecell";
 				reg = <0x10EB0000 0x1000>;
 				interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.11.0
author maintainer
#1 lore raw

PATCH 2/2 arm64: dts: exynos: Fix typo in MSCL clock controller unit address

Fix typo in unit address of MSCL clock controller (the reg entry is correct).

---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -1
index 0ba5df825eff..3e8311c60d1b 100644
@@ -468,7 +468,7 @@
 			clocks = <&xxti>, <&cmu_mif CLK_SCLK_BUS_PLL_ATLAS>;
 		};
 
-		cmu_mscl: clock-controller at 105d0000 {
+		cmu_mscl: clock-controller at 150d0000 {
 			compatible = "samsung,exynos5433-cmu-mscl";
 			reg = <0x150d0000 0x1000>;
 			#clock-cells = <1>;
Signature · 1 line
2.11.0
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: exynos: Fix typo in MSCL clock controller unit address

Quoted 14 lines · Krzysztof Kozlowski

Fix typo in unit address of MSCL clock controller (the reg entry is correct).

---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +0 -0
index 0ba5df825eff..3e8311c60d1b 100644

arch/arm64/boot/dts/exynos/exynos5433.dtsi line 474

Quoted 8 lines
arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -1
@@ -468,7 +468,7 @@
 			clocks = <&xxti>, <&cmu_mif CLK_SCLK_BUS_PLL_ATLAS>;
 		};
 
-		cmu_mscl: clock-controller at 105d0000 {
+		cmu_mscl: clock-controller at 150d0000 {
 			compatible = "samsung,exynos5433-cmu-mscl";
 			reg = <0x150d0000 0x1000>;
 			#clock-cells = <1>;

Looks good to me.

Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics
Reviewed-by on v1 1/2
#3 lore raw
In reply to Krzysztof Kozlowski

Dear Krzysztof,

Quoted 69 lines · Krzysztof Kozlowski

Convert all hex addresses in node unit addresses to lower case to
fix warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2e.dtb: Warning (simple_bus_reg):
Node /soc/video-scaler at 13C00000 simple-bus unit address format error, expected "13c00000"

Conversion was done using sed:

    $ sed -e 's/@\([a-zA-Z0-9_-]*\) {/@\L\1 {/' -i arch/arm64/boot/dts/exynos/*.dts*
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 8 ++++----
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +4 -4
index 1962b8074349..0ba5df825eff 100644
@@ -994,7 +994,7 @@
 			reg = <0x145f0000 0x1038>;
 		};
 
-		gsc_0: video-scaler at 13C00000 {
+		gsc_0: video-scaler at 13c00000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c00000 0x1000>;
 			interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
@@ -1008,7 +1008,7 @@
 			power-domains = <&pd_gscl>;
 		};
 
-		gsc_1: video-scaler at 13C10000 {
+		gsc_1: video-scaler at 13c10000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c10000 0x1000>;
 			interrupts = <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>;
@@ -1022,7 +1022,7 @@
 			power-domains = <&pd_gscl>;
 		};
 
-		gsc_2: video-scaler at 13C20000 {
+		gsc_2: video-scaler at 13c20000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c20000 0x1000>;
 			interrupts = <GIC_SPI 299 IRQ_TYPE_LEVEL_HIGH>;
@@ -1049,7 +1049,7 @@
 			power-domains = <&pd_mscl>;
 		};
 
-		mfc: codec at 152E0000 {
+		mfc: codec at 152e0000 {
 			compatible = "samsung,exynos5433-mfc";
 			reg = <0x152E0000 0x10000>;
 			interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
arch/arm64/boot/dts/exynos/exynos7.dtsi +1 -1
index 9a3fbed1765a..3504837b1d43 100644
@@ -103,7 +103,7 @@
 			#size-cells = <1>;
 			ranges;
 
-			pdma0: pdma at 10E10000 {
+			pdma0: pdma at 10e10000 {
 				compatible = "arm,pl330", "arm,primecell";
 				reg = <0x10E10000 0x1000>;
 				interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/exynos/exynos7.dtsi line 120

Quoted 8 lines
arch/arm64/boot/dts/exynos/exynos7.dtsi +1 -1
@@ -114,7 +114,7 @@
 				#dma-requests = <32>;
 			};
 
-			pdma1: pdma at 10EB0000 {
+			pdma1: pdma at 10eb0000 {
 				compatible = "arm,pl330", "arm,primecell";
 				reg = <0x10EB0000 0x1000>;
 				interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;

Looks good to me.

Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics