Skip to contentSkip to conversation

regmap: debugfs: emit a debug message when locking is disabled

PATCH RESEND New Bartosz Golaszewski 1 participant 1 message Dec 21, 2017

Subsystems (2)
Driver core Register map abstraction
lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH RESEND 1/1 regmap: debugfs: emit a debug message when locking is disabled

We currently silently omit creating the debugfs entries when regmap locking is disabled. Users may not be aware of the reason for which regmap files don't show up in debugfs. Add a dev_dbg() message explaining that.

Signed-off-by Bartosz Golaszewski <[email protected]>

---
As discussed in private: this patch seems to have been lost, so resending.

 drivers/base/regmap/regmap-debugfs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/base/regmap/regmap-debugfs.c +3 -1
index c8ecefd75d6f..ae962b756863 100644
@@ -529,8 +529,10 @@ void regmap_debugfs_init(struct regmap *map, const char *name)
 	struct regmap_range_node *range_node;
 	const char *devname = "dummy";
 
-	if (map->debugfs_disable)
+	if (map->debugfs_disable) {
+		dev_dbg(map->dev, "regmap locking disabled - not creating debugfs entries\n");
 		return;
+	}
 
 	/* If we don't have the debugfs root yet, postpone init */
 	if (!regmap_debugfs_root) {
Signature · 1 line
2.15.1