drm: Add DPCD definitions for DP 1.4 FEC feature
Subsystems (2)
PATCH 1/1 drm: Add DPCD definitions for DP 1.4 FEC feature
Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions.
v2: Add dri-devel to the CC list
--- include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
include/drm/drm_dp_helper.h +29 -0
@@ -284,6 +284,35 @@# define DP_DSC_BITS_PER_PIXEL_1_2 0x3# define DP_DSC_BITS_PER_PIXEL_1 0x4 +/* DP Forward error Correction Registers */ +#define DP_FEC_CAPABILITY 0x090 +# define DP_FEC_CAPABLE (1 << 0) +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1) +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2) +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3) + +#define DP_FEC_CONFIGURATION 0x120 +# define DP_FEC_READY (1 << 0) +# define DP_FEC_ERR_COUNT_DIS (0 << 1) +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1) +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1) +# define DP_FEC_BIT_ERROR_COUNT (3 << 1) +# define DP_FEC_LANE_0_SELECT (0 << 4) +# define DP_FEC_LANE_1_SELECT (1 << 4) +# define DP_FEC_LANE_2_SELECT (2 << 4) +# define DP_FEC_LANE_3_SELECT (3 << 4) + +#define DP_FEC_STATUS 0x280 +# define DP_FEC_EN_DETECTED (1 << 0) +# define DP_FEC_DEC_DETECTED (1 << 1) + +#define DP_FEC_ERROR_COUNT_1 0x0281 +# define DP_FEC_ERR_COUNT_7_0 (err_count) (err_count << 0) + +#define DP_FEC_ERROR_COUNT_2 0x0282 +# define DP_FEC_ERR_COUNT_14_8 (err_count) (err_count << 0) +# define DP_FEC_ERR_COUNT_VALID (1 << 7) +#define DP_PSR_SUPPORT 0x070/* XXX 1.2? */ # define DP_PSR_IS_SUPPORTED 1# define DP_PSR2_IS_SUPPORTED 2/* eDP 1.4 */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 FEC feature (rev2)
== Series Details ==
== Series Details ==
Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev2)
URL : https://patchwork.freedesktop.org/series/34259/
State : success
== Summary ==
Series 34259v2 drm: Add DPCD definitions for DP 1.4 FEC feature
https://patchwork.freedesktop.org/api/1.0/series/34259/revisions/2/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:441s fi-bdw-gvtdvm total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:493s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:383s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:536s fi-bwr-2160 total:289 pass:182 dwarn:1 dfail:0 fail:0 skip:106 time:320s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:504s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:509s fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:493s fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:487s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:431s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:266s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:544s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:487s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:458s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:488s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:532s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:474s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:532s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:586s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:456s fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:545s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:567s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:515s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:510s fi-skl-gvtdvm total:289 pass:265 dwarn:1 dfail:0 fail:0 skip:23 time:499s fi-snb-2520m total:246 pass:212 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:416s Blacklisted hosts: fi-cfl-s2 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:606s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:553s fi-glk-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:496s
b0da98fe7a3895168a534d8481fbba595e7ae0cf drm-tip: 2017y-11m-27d-21h-48m-50s UTC integration manifest 9b3ed5ee5432 drm: Add DPCD definitions for DP 1.4 FEC feature
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7318/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm: Add DPCD definitions for DP 1.4 FEC feature (rev2)
In reply to Anusha Srivatsa== Series Details ==
== Series Details ==
Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev2)
URL : https://patchwork.freedesktop.org/series/34259/
State : failure
== Summary ==
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623 +1
Test gem_exec_suspend:
Subgroup basic-s4:
fail -> DMESG-FAIL (shard-snb) fdo#103375 +1
Test perf_pmu:
Subgroup all-busy-check-all:
dmesg-warn -> PASS (shard-hsw)
Subgroup busy-check-all-bcs0:
pass -> DMESG-WARN (shard-hsw)
Test pm_rpm:
Subgroup system-suspend:
pass -> DMESG-WARN (shard-hsw)
Test kms_flip:
Subgroup modeset-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw) fdo#103060
Test gem_tiled_swapping:
Subgroup non-threaded:
pass -> INCOMPLETE (shard-hsw) fdo#103525
Test kms_atomic:
Subgroup plane_cursor_legacy:
pass -> INCOMPLETE (shard-snb)
Test kms_cursor_crc:
Subgroup cursor-256x256-suspend:
pass -> DMESG-WARN (shard-snb) fdo#102365
dmesg-warn -> PASS (shard-hsw)
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test kms_plane:
Subgroup plane-panning-bottom-right-suspend-pipe-a-planes:
dmesg-warn -> PASS (shard-snb) fdo#103667 +1
Test drv_module_reload:
Subgroup basic-reload-inject:
pass -> DMESG-WARN (shard-snb) fdo#102707 +1
Subgroup basic-reload:
pass -> DMESG-WARN (shard-snb) fdo#102848
Test gem_exec_faulting_reloc:
Subgroup no-prefault:
pass -> DMESG-WARN (shard-snb)
Test prime_self_import:
Subgroup reimport-vs-gem_close-race:
pass -> DMESG-WARN (shard-snb)
Subgroup basic-llseek-size:
pass -> INCOMPLETE (shard-snb)
Test gem_sync:
Subgroup basic-all:
pass -> DMESG-FAIL (shard-snb)fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103525 https://bugs.freedesktop.org/show_bug.cgi?id=103525
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103667 https://bugs.freedesktop.org/show_bug.cgi?id=103667
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#102848 https://bugs.freedesktop.org/show_bug.cgi?id=102848
shard-hsw total:2617 pass:1505 dwarn:9 dfail:0 fail:9 skip:1093 time:9169s shard-snb total:2520 pass:1217 dwarn:16 dfail:6 fail:4 skip:1272 time:6916s Blacklisted hosts: shard-apl total:2506 pass:1560 dwarn:13 dfail:15 fail:15 skip:896 time:11017s shard-kbl total:2477 pass:1640 dwarn:22 dfail:14 fail:14 skip:780 time:9532s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7318/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 25 lines · Anusha Srivatsa
Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions.
v2: Add dri-devel to the CC list
Cc Ville Syrjala <[email protected]>Cc Jani Nikula <[email protected]>Cc Manasi Navare <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>--- include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)include/drm/drm_dp_helper.h +3
-0@@ -284,6 +284,35 @@# define DP_DSC_BITS_PER_PIXEL_1_2 0x3# define DP_DSC_BITS_PER_PIXEL_1 0x4 +/* DP Forward error Correction Registers */ +#define DP_FEC_CAPABILITY 0x090 +# define DP_FEC_CAPABLE (1 << 0)
include/drm/drm_dp_helper.h line 299
Quoted 10 lines
include/drm/drm_dp_helper.h +10
-0+# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1) +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2) +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3) + +#define DP_FEC_CONFIGURATION 0x120 +# define DP_FEC_READY (1 << 0) +# define DP_FEC_ERR_COUNT_DIS (0 << 1) +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1) +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1) +# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
These above values indicate the value of FEC_ERROR_COUNT_SEL.
I think we would need a mask for FEC_ERROR_COUNT_SEL field so that
we can read this field as drm_dpcd_read(DP_FEC_CONFIGURATION) & FEC_ERROR_COUNT_SEL_MASK and then compare this to each of the values for that field.
So we would need an extra #define for the MASK
include/drm/drm_dp_helper.h line 306
Quoted 7 lines
include/drm/drm_dp_helper.h +7
-0+# define DP_FEC_LANE_0_SELECT (0 << 4) +# define DP_FEC_LANE_1_SELECT (1 << 4) +# define DP_FEC_LANE_2_SELECT (2 << 4) +# define DP_FEC_LANE_3_SELECT (3 << 4) + +#define DP_FEC_STATUS 0x280 +# define DP_FEC_EN_DETECTED (1 << 0)
I think better name would be DP_FEC_DECODE_EN_DETECTED since this refers to FEC_DECODE_EN link symbol sequence
include/drm/drm_dp_helper.h line 307
Quoted 1 line
include/drm/drm_dp_helper.h +1
-0+# define DP_FEC_DEC_DETECTED (1 << 1)
And this should be DP_FEC_DECODE_DIS_DETECTED since this refers to FEC_DECODE_DIS link symbol sequence
include/drm/drm_dp_helper.h line 310
Quoted 3 lines
include/drm/drm_dp_helper.h +3
-0+ +#define DP_FEC_ERROR_COUNT_1 0x0281 +# define DP_FEC_ERR_COUNT_7_0 (err_count) (err_count << 0)
So this is a RO register and so we wont be writing the err_count by passing it as an argument as above.
And this is the entire reister that indicates the LSB of ERR_COUNT you can just rename the register as DP_FEC_ERR_COUNT_LSB
So while reading you just pass this register address and get LSB into a variable.
include/drm/drm_dp_helper.h line 313
Quoted 3 lines
include/drm/drm_dp_helper.h +3
-0+ +#define DP_FEC_ERROR_COUNT_2 0x0282 +# define DP_FEC_ERR_COUNT_14_8 (err_count) (err_count << 0)
This could be DP_FEC_ERR_COUNT_MSB_MASK and SHIFT should be 8 since you want to put this value at the 8th bit of a 16 bit value.
include/drm/drm_dp_helper.h line 314
Quoted 1 line
include/drm/drm_dp_helper.h +1
-0+# define DP_FEC_ERR_COUNT_VALID (1 << 7)
Everything else looks good.
Manasi
Quoted 7 lines
include/drm/drm_dp_helper.h +1
-0+#define DP_PSR_SUPPORT 0x070/* XXX 1.2? */ # define DP_PSR_IS_SUPPORTED 1# define DP_PSR2_IS_SUPPORTED 2/* eDP 1.4 */ Signature · 1 line
2.7.4
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 45 lines
-----Original Message-----
From: Navare, Manasi D
Sent: Thursday, December 21, 2017 12:36 PM
To: Srivatsa, Anusha <[email protected]>
Cc: [email protected]; [email protected]; Ville Syrjala <[email protected]>; Jani Nikula <[email protected]>
Subject: Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC featureQuoted 34 lines · Anusha Srivatsa
Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions.
v2: Add dri-devel to the CC list
Cc Ville Syrjala <[email protected]>Cc Jani Nikula <[email protected]>Cc Manasi Navare <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>--- include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)include/drm/drm_dp_helper.h +12
-0@@ -284,6 +284,35 @@# define DP_DSC_BITS_PER_PIXEL_1_2 0x3# define DP_DSC_BITS_PER_PIXEL_1 0x4 +/* DP Forward error Correction Registers */ +#define DP_FEC_CAPABILITY 0x090 +# define DP_FEC_CAPABLE (1 << 0) +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1) +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2) +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3) + +#define DP_FEC_CONFIGURATION 0x120 +# define DP_FEC_READY (1 << 0) +# define DP_FEC_ERR_COUNT_DIS (0 << 1) +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1) +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
Quoted 8 lines
include/drm/drm_dp_helper.h line 299
Quoted 1 line
include/drm/drm_dp_helper.h +1
-0+# define DP_FEC_BIT_ERROR_COUNT (3 << 1)These above values indicate the value of
FEC_ERROR_COUNT_SEL. I think we would need a mask forFEC_ERROR_COUNT_SELfield so that we can read this field asdrm_dpcd_read(DP_FEC_CONFIGURATION)&FEC_ERROR_COUNT_SEL_MASKand then compare this to each of the values for that field.
So we would need an extra #define for the MASK
Sounds good....
Quoted 10 lines
include/drm/drm_dp_helper.h line 306
Quoted 7 lines
include/drm/drm_dp_helper.h +7
-0+# define DP_FEC_LANE_0_SELECT (0 << 4) +# define DP_FEC_LANE_1_SELECT (1 << 4) +# define DP_FEC_LANE_2_SELECT (2 << 4) +# define DP_FEC_LANE_3_SELECT (3 << 4) + +#define DP_FEC_STATUS 0x280 +# define DP_FEC_EN_DETECTED (1 << 0)I think better name would be
DP_FEC_DECODE_EN_DETECTEDsince this refers toFEC_DECODE_ENlink symbol sequence
Now that you mentioned, I noticed that's the name used in spec too. I wonder why I went ahead with the above name. Shall change it. Thanks.
Quoted 5 lines
include/drm/drm_dp_helper.h line 307
Quoted 1 line
include/drm/drm_dp_helper.h +1
-0+# define DP_FEC_DEC_DETECTED (1 << 1)And this should be
DP_FEC_DECODE_DIS_DETECTEDsince this refers toFEC_DECODE_DISlink symbol sequence
Quoted 9 lines
include/drm/drm_dp_helper.h line 310
Quoted 3 lines
include/drm/drm_dp_helper.h +3
-0+ +#define DP_FEC_ERROR_COUNT_1 0x0281 +# define DP_FEC_ERR_COUNT_7_0 (err_count) (err_count << 0)So this is a RO register and so we wont be writing the
err_countby passing it as an argument as above.
And this is the entire reister that indicates the LSB ofERR_COUNTyou can just rename the register asDP_FEC_ERR_COUNT_LSBSo while reading you just pass this register address and get LSB into a variable.
Yes, good point.
Quoted 7 lines
include/drm/drm_dp_helper.h line 313
Quoted 4 lines
include/drm/drm_dp_helper.h +3
-0+ +#define DP_FEC_ERROR_COUNT_2 0x0282 +# define DP_FEC_ERR_COUNT_14_8 (err_count) (err_count << 0)This could be
DP_FEC_ERR_COUNT_MSB_MASKand SHIFT should be 8 since you want to put this value at the 8th bit of a 16 bit value.
This helps.... thanks!
Quoted 3 lines
include/drm/drm_dp_helper.h line 314
Quoted 1 line
include/drm/drm_dp_helper.h +1
-0+# define DP_FEC_ERR_COUNT_VALID (1 << 7)Everything else looks good.
Thanks Manasi. I will incorporate these changes in the next revision.
Anusha
Quoted 9 lines
Manasi
Quoted 7 lines
include/drm/drm_dp_helper.h +1
-1+#define DP_PSR_SUPPORT 0x070/* XXX 1.2? */ # define DP_PSR_IS_SUPPORTED 1# define DP_PSR2_IS_SUPPORTED 2/* eDP 1.4 */ --2.7.4
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel