Skip to contentSkip to conversation

Fix const confusion in intel-mid x86 platform drivers

PATCH In review Andi Kleen 3 participants 3 messages Dec 22, 2017 – Dec 28, 2017

Subsystems (3)
lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Fix const confusion in intel-mid x86 platform drivers

From: Andi Kleen <[email protected]>

const must be marked __initconst, not __initdata

---
 arch/x86/platform/intel-mid/device_libs/platform_bt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/platform/intel-mid/device_libs/platform_bt.c +1 -1
index dc036e511f48..2b5d86ce24c2 100644
@@ -60,7 +60,7 @@ static int __init tng_bt_sfi_setup(struct bt_sfi_data *ddata)
 	return 0;
 }
 
-static const struct bt_sfi_data tng_bt_sfi_data __initdata = {
+static const struct bt_sfi_data tng_bt_sfi_data __initconst = {
 	.setup	= tng_bt_sfi_setup,
 };
 
Signature · 1 line
2.15.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andi Kleen

From: Andi Kleen <[email protected]>

const must be marked __initconst, not __initdata

Thanks Andi,

This file should go through the x86 maintainers per the current MAINTAINERS file. So to avoid risk of duplication, added Thomas et al. to Cc.

Thomas, we discussed moving more of arch/x86/platform to drivers/platform/x86. We have migrated pmc_atom already, but a lot remains. Do you want to pull patches like this in the interim, or should we move arch/x86/platform under our entry in MAINTAINERS now?

Quoted 22 lines
---
 arch/x86/platform/intel-mid/device_libs/platform_bt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/platform/intel-mid/device_libs/platform_bt.c +1 -1
index dc036e511f48..2b5d86ce24c2 100644
@@ -60,7 +60,7 @@ static int __init tng_bt_sfi_setup(struct bt_sfi_data *ddata)
 	return 0;
 }
 
-static const struct bt_sfi_data tng_bt_sfi_data __initdata = {
+static const struct bt_sfi_data tng_bt_sfi_data __initconst = {
 	.setup	= tng_bt_sfi_setup,
 };
 
Signature · 1 line
2.15.0
Signature · 2 lines
Darren Hart
VMware Open Source Technology Center
#2 lore raw
Quoted 11 lines · Darren Hart
Quoted 4 lines · Andi Kleen

From: Andi Kleen <[email protected]>

const must be marked __initconst, not __initdata

Thanks Andi,

This file should go through the x86 maintainers per the current MAINTAINERS file. So to avoid risk of duplication, added Thomas et al. to Cc.

Quoted 6 lines

Thomas, we discussed moving more of arch/x86/platform to drivers/platform/x86. We have migrated pmc_atom already, but a lot remains. Do you want to pull patches like this in the interim, or should we move arch/x86/platform under our entry in MAINTAINERS now?

I'm sorry, but the patch which brings const there have made already a regression [1].

So, NAK for this either.

Unbelievable that the other patch had been send w/o me in Cc list and blindly applied.

[1]: https://github.com/andy-shev/linux/issues/20

Signature · 2 lines
With Best Regards,
Andy Shevchenko