virtio_remoteproc: correct put_device virtio_device.dev
Subsystems (2)
PATCH v5 4/4 virtio_remoteproc: correct put_device virtio_device.dev
rproc_virtio_dev_release will be called iff virtio_device.dev's reference count drops to 0. Here we just put vdev.dev, and then rproc->dev's cleanup will be done in rproc_virtio_dev_release.
Signed-off-by weiping zhang <[email protected]>
--- drivers/remoteproc/remoteproc_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/remoteproc/remoteproc_virtio.c +1 -1
@@ -327,7 +327,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) ret =register_virtio_device (vdev);if (ret) { -put_device (&rproc->dev); +put_device (&vdev->dev);dev_err (dev,"failed to register vdev: %d\n" , ret); goto out; }
Signature · 1 line
2.9.4
Quoted 8 lines · On Thu, 21 Dec 2017 20:40:58 +0800 weiping zhang…
rproc_virtio_dev_releasewill be called iff virtio_device.dev's reference count drops to 0. Here we just put vdev.dev, and then rproc->dev's cleanup will be done inrproc_virtio_dev_release.Signed-off-by weiping zhang <[email protected]>--- drivers/remoteproc/remoteproc_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Cornelia Huck <[email protected]>
Quoted 5 lines · weiping zhang
rproc_virtio_dev_releasewill be called iff virtio_device.dev's reference count drops to 0. Here we just put vdev.dev, and then rproc->dev's cleanup will be done inrproc_virtio_dev_release.Signed-off-by weiping zhang <[email protected]>
Thanks weiping and Cornelia, applied.
Regards,
Bjorn
Quoted 20 lines
--- drivers/remoteproc/remoteproc_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/remoteproc/remoteproc_virtio.c +1
-1@@ -327,7 +327,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) ret =register_virtio_device (vdev);if (ret) { -put_device (&rproc->dev); +put_device (&vdev->dev);dev_err (dev,"failed to register vdev: %d\n" , ret); goto out; }Signature · 1 line
2.9.4