Skip to contentSkip to conversation

meson: Bump required version to 0.44.0

PATCH In review Rhys Kidd 4 participants 5 messages Dec 24, 2017 – Jan 4, 2018 Arm/Amlogic Meson SoC support

lore
Share & tools
lore

Rhys Kidd

author
#0 lore raw

PATCH 1/1 meson: Bump required version to 0.44.0

warning() needs that, which was introduced in a 865a47ca failure path.

Otherwise we get error messages on that failure path like:
...
Program leg found: NO

Meson encountered an error in file overlay/meson.build, line 62, column 1:
Unknown function "warning".
FAILED: build.ninja
...

Fixes 865a47ca ("overlay: parse tracepoints from sysfs to figure out fields' location")
Signed-off-by Rhys Kidd <[email protected]>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meson.build +1 -1
index 0950d3c7..20064ae1 100644
@@ -5,7 +5,7 @@ project('IGT gpu tests', 'c',
           'c_std=gnu99',
         ],
 	license : 'MIT',
-	meson_version : '>0.40.0')
+	meson_version : '>=0.44.0')
 
 cc = meson.get_compiler('c')
Signature · 6 lines
2.14.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
CI
#1 lore raw

✓ Fi.CI.BAT: success for meson: Bump required version to 0.44.0

== Series Details ==

== Series Details ==

Series: meson: Bump required version to 0.44.0
URL : https://patchwork.freedesktop.org/series/35766/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 6d27acafa3a2d80b6330e2380a3548bc98dcc3e5 igt/gem_exec_await: Flush the WCB before attempting to queue more work

with latest DRM-Tip kernel build CI_DRM_3580
03944fd7a7f9 drm-tip: 2017y-12m-24d-14h-15m-52s UTC integration manifest

No testlist changes.

Test debugfs_test:

        Subgroup read_all_entries:
                dmesg-warn -> PASS       (fi-elk-e7500) fdo#103989 +1
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172 +1
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                pass       -> DMESG-WARN (fi-skl-6700hq) fdo#101144

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:438s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:446s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:388s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:499s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:278s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:496s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:502s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:486s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:465s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:261s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:536s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:412s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:414s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:431s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:477s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:436s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:482s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:527s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:467s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:524s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:597s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:443s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:538s
fi-skl-6700hq    total:288  pass:261  dwarn:1   dfail:0   fail:0   skip:26  time:565s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:505s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:485s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:445s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:552s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:409s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:582s
fi-cnl-y         total:219  pass:198  dwarn:0   dfail:0   fail:0   skip:20 
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:482s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_732/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#2 lore raw

✓ Fi.CI.IGT: success for meson: Bump required version to 0.44.0

In reply to Rhys Kidd
== Series Details ==

== Series Details ==

Series: meson: Bump required version to 0.44.0
URL : https://patchwork.freedesktop.org/series/35766/
State : success

== Summary ==

Test drv_suspend:

        Subgroup debugfs-reader:
                skip       -> PASS       (shard-hsw)
Test gem_eio:
        Subgroup in-flight-contexts:
                dmesg-warn -> PASS       (shard-snb) fdo#104058
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                fail       -> PASS       (shard-snb) fdo#101623 +1
Test kms_flip:
        Subgroup plain-flip-ts-check:
                pass       -> FAIL       (shard-snb) fdo#100368

fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368

shard-hsw        total:2637 pass:1492 dwarn:1   dfail:0   fail:9   skip:1135 time:8993s
shard-snb        total:2713 pass:1309 dwarn:1   dfail:0   fail:12  skip:1391 time:8046s
Blacklisted hosts:
shard-apl        total:2713 pass:1688 dwarn:1   dfail:0   fail:23  skip:1001 time:13790s
shard-kbl        total:2713 pass:1803 dwarn:1   dfail:0   fail:28  skip:881 time:11144s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_732/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Rhys Kidd
Quoted 6 lines · Rhys Kidd

warning() needs that, which was introduced in a 865a47ca failure path.

Otherwise we get error messages on that failure path like:
...
Program leg found: NO

Quoted 7 lines

Meson encountered an error in file overlay/meson.build, line 62, column 1:
Unknown function "warning".
FAILED: build.ninja
...

Fixes 865a47ca ("overlay: parse tracepoints from sysfs to figure out fields' location")
Signed-off-by Rhys Kidd <[email protected]>

I just had this error and prepared a patch to do the other way around:
use message() rather than warning().
I think we could delay raising the dependency to the latest meson version.... on Fedora 27 for example we have
meson 0.43 available, not 0.44 (although we could install 0.44 from pypi).

I'm not sure which one is best.

Lucas De Marchi

Quoted 24 lines
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meson.build +1 -2
index 0950d3c7..20064ae1 100644
@@ -5,7 +5,7 @@ project('IGT gpu tests', 'c',
           'c_std=gnu99',
         ],
        license : 'MIT',
-       meson_version : '>0.40.0')
+       meson_version : '>=0.44.0')
 
 cc = meson.get_compiler('c')
 
--

2.14.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 16 lines · Lucas De Marchi
Quoted 6 lines · Rhys Kidd

warning() needs that, which was introduced in a 865a47ca failure path.

Otherwise we get error messages on that failure path like:
...
Program leg found: NO

Quoted 7 lines

Meson encountered an error in file overlay/meson.build, line 62, column 1:
Unknown function "warning".
FAILED: build.ninja
...

Fixes 865a47ca ("overlay: parse tracepoints from sysfs to figure out fields' location")
Signed-off-by Rhys Kidd <[email protected]>
Quoted 7 lines

I just had this error and prepared a patch to do the other way around:
use message() rather than warning().
I think we could delay raising the dependency to the latest meson version.... on Fedora 27 for example we have
meson 0.43 available, not 0.44 (although we could install 0.44 from pypi).

I'm not sure which one is best.

Meson version dependency shouldn't be bumped if we can avoid it. Debian stable is already out of reach, but stable-backports has 0.42.

Please send your patch for using message() instead.

Signature · 5 lines
Petri Latvala
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx