Skip to contentSkip to conversation

ARM: dts: imx6sx-sdb: Disable PCI support

PATCH New Fabio Estevam 2 participants 4 messages Dec 14, 2017 – Dec 26, 2017

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 ARM: dts: imx6sx-sdb: Disable PCI support

From: Fabio Estevam <[email protected]>

When I added PCI support for this board I was testing with mainline U-Boot, which has PCI support and enables the i.mx6sx PCI power domain.

When running on a U-Boot without PCI support, such as the one provided by NXP a kernel hang is observed.

Better to disable the pci node for now, until the i.MX6SX PCI power domain is properly implemented in the kernel.

---
 arch/arm/boot/dts/imx6sx-sdb.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx6sx-sdb.dtsi +2 -1
index d57a41c..bb0fe35 100644
@@ -215,7 +215,8 @@
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio2 0 GPIO_ACTIVE_LOW>;
 	vpcie-supply = <&reg_pcie_gpio>;
-	status = "okay";
+	/* Keep it disable until mx6sx pci domain is supported */
+	status = "disabled";
 };
 
 &lcdif1 {
Signature · 1 line
2.7.4
author reviewer
#1 lore raw

PATCH 1/2 ARM: dts: imx6sx-sdb: Disable PCI support

Hi Shawn,

Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When I added PCI support for this board I was testing with mainline U-Boot, which has PCI support and enables the i.mx6sx PCI power domain.

When running on a U-Boot without PCI support, such as the one provided by NXP a kernel hang is observed.

Better to disable the pci node for now, until the i.MX6SX PCI power domain is properly implemented in the kernel.

Just sent two patches that add i.MX6SX PCI power domain support.

If they are accepted then this one can be discarded.

Patch 2/2 of this series should still be applied though.

Thanks

author reviewer
#2 lore raw

PATCH 2/2 ARM: dts: imx6sx: Fix PCI non-prefetchable memory range

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

The third cell of the PCI non-prefetchable memory range should be 0x08000000, so change it accordingly.

---
 arch/arm/boot/dts/imx6sx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6sx.dtsi +1 -1
index 40c6738c..f41e389 100644
@@ -1313,7 +1313,7 @@
 			device_type = "pci";
 			bus-range = <0x00 0xff>;
 			ranges = <0x81000000 0 0          0x08f80000 0 0x00010000 /* downstream I/O */
-				  0x82000000 0 0x01000000 0x08000000 0 0x00f00000>; /* non-prefetchable memory */
+				  0x82000000 0 0x08000000 0x08000000 0 0x00f00000>; /* non-prefetchable memory */
 			num-lanes = <1>;
 			interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "msi";
Signature · 1 line
2.7.4
Applied
#3 lore raw

PATCH 2/2 ARM: dts: imx6sx: Fix PCI non-prefetchable memory range

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The third cell of the PCI non-prefetchable memory range should be 0x08000000, so change it accordingly.

Applied this one, thanks.