Skip to contentSkip to conversation

ARM: dts: ls1021a-qds: Remove extra clock cell

PATCH New Fabio Estevam 2 participants 3 messages Dec 19, 2017 – Dec 26, 2017 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: ls1021a-qds: Remove extra clock cell

There is an extraneous '1' cell in the clock phandle, which causes the following build warning:

arch/arm/boot/dts/ls1021a-qds.dtb: Warning (clocks_property): Property 'clocks', cell 1 is not a phandle reference in /soc/i2c at 2180000/mux at 77/i2c at 4/sgtl5000 at 2a arch/arm/boot/dts/ls1021a-qds.dtb: Warning (clocks_property): Missing property '#clock-cells' in node /soc/interrupt-controller at 1400000 or bad phandle (referred from /soc/i2c at 2180000/mux at 77/i2c at 4/sgtl5000 at 2a:clocks[1])

Remove the unneeded extra cell.

---
 arch/arm/boot/dts/ls1021a-qds.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/ls1021a-qds.dts +1 -1
index 4f211e3..7bb402d 100644
@@ -215,7 +215,7 @@
 				reg = <0x2a>;
 				VDDA-supply = <&reg_3p3v>;
 				VDDIO-supply = <&reg_3p3v>;
-				clocks = <&sys_mclk 1>;
+				clocks = <&sys_mclk>;
 			};
 		};
 	};
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 ARM: dts: ls1021a-twr: Remove extra clock cell

There is an extraneous '1' cell in the clock phandle, which causes the following build warning:

arch/arm/boot/dts/ls1021a-twr.dtb: Warning (clocks_property): Property 'clocks', cell 1 is not a phandle reference in /soc/i2c at 2190000/sgtl5000 at a arch/arm/boot/dts/ls1021a-twr.dtb: Warning (clocks_property): Missing property '#clock-cells' in node /soc/interrupt-controller at 1400000 or bad phandle (referred from /soc/i2c at 2190000/sgtl5000 at a:clocks[1])

Remove the unneeded extra cell.

---
 arch/arm/boot/dts/ls1021a-twr.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/ls1021a-twr.dts +1 -1
index 3adf793..f0c949d 100644
@@ -187,7 +187,7 @@
 		reg = <0x0a>;
 		VDDA-supply = <&reg_3p3v>;
 		VDDIO-supply = <&reg_3p3v>;
-		clocks = <&sys_mclk 1>;
+		clocks = <&sys_mclk>;
 	};
 };
 
Signature · 1 line
2.7.4
Applied
#2 lore raw

PATCH 1/2 ARM: dts: ls1021a-qds: Remove extra clock cell

In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

There is an extraneous '1' cell in the clock phandle, which causes the following build warning:

arch/arm/boot/dts/ls1021a-qds.dtb: Warning (clocks_property): Property 'clocks', cell 1 is not a phandle reference in /soc/i2c at 2180000/mux at 77/i2c at 4/sgtl5000 at 2a arch/arm/boot/dts/ls1021a-qds.dtb: Warning (clocks_property): Missing property '#clock-cells' in node /soc/interrupt-controller at 1400000 or bad phandle (referred from /soc/i2c at 2180000/mux at 77/i2c at 4/sgtl5000 at 2a:clocks[1])

Remove the unneeded extra cell.

Applied both, thanks.