Skip to contentSkip to conversation

powerpc/xive: Properly use static keyword for inline function

PATCH Applied Mathieu Malaterre 3 participants 3 messages Dec 26, 2017 – Jan 22, 2018 PowerPC

lore
Share & tools
lore

Mathieu Malaterre

author
#0 lore raw

PATCH 1/1 powerpc/xive: Properly use static keyword for inline function

Fix fatal warning during compilation:

In file included from arch/powerpc/xmon/xmon.c:54:0:
./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }

                    ^
Signed-off-by Mathieu Malaterre <[email protected]>
---
 arch/powerpc/include/asm/xive.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/include/asm/xive.h +1 -1
index 371fbebf1ec9..83dc2cc320a3 100644
@@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; }
 static inline bool xive_spapr_init(void) { return false; }
 static inline bool xive_native_init(void) { return false; }
 static inline void xive_smp_probe(void) { }
-extern inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
+static inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
 static inline void xive_smp_setup_cpu(void) { }
 static inline void xive_smp_disable_cpu(void) { }
 static inline void xive_kexec_teardown_cpu(int secondary) { }
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Mathieu Malaterre

Fix fatal warning during compilation:

In file included from arch/powerpc/xmon/xmon.c:54:0:
./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }

                    ^
Signed-off-by Mathieu Malaterre <[email protected]>
Reviewed-by Cédric Le Goater <[email protected]>

Thanks,

C.

Quoted 18 lines
---
 arch/powerpc/include/asm/xive.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/include/asm/xive.h +1 -1
index 371fbebf1ec9..83dc2cc320a3 100644
@@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; }
 static inline bool xive_spapr_init(void) { return false; }
 static inline bool xive_native_init(void) { return false; }
 static inline void xive_smp_probe(void) { }
-extern inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
+static inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
 static inline void xive_smp_setup_cpu(void) { }
 static inline void xive_smp_disable_cpu(void) { }
 static inline void xive_kexec_teardown_cpu(int secondary) { }
Applied
#2 lore raw
In reply to Mathieu Malaterre
Quoted 9 lines · Mathieu Malaterre

Fix fatal warning during compilation:

In file included from arch/powerpc/xmon/xmon.c:54:0:
./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }

                    ^
Signed-off-by Mathieu Malaterre <[email protected]>
Reviewed-by Cédric Le Goater <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/38833faa112c10dd6e3d888f8b53de

cheers