Skip to contentSkip to conversation

drivers/clk/clk-si5351.c:906:6: sparse: symbol '_si5351_clkout_reset_pll' was not declared. Should it be static?

PATCH New kbuild test robot 2 participants 3 messages Dec 27, 2017 – Dec 28, 2017 Common clk

lore
Share & tools
lore

kbuild test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
head:   cf12ed59508b49c2baaccd7cff68d550c5042b58
commit: b26ff127c52c005ac4eb99ebff7bd17c240c2e89 [136/143] clk: si5351: Apply PLL soft reset before enabling the outputs
reproduce:
        # apt-get install sparse
        git checkout b26ff127c52c005ac4eb99ebff7bd17c240c2e89
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__

sparse warnings: (new ones prefixed by >>)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

author build bot
#1 lore raw

[RFC PATCH clk] clk: si5351: _si5351_clkout_reset_pll() can be static

Fixes: b26ff127c52c ("clk: si5351: Apply PLL soft reset before enabling the outputs")
Fixes b26ff127c52c ("clk: si5351: Apply PLL soft reset before enabling the outputs")
Signed-off-by Fengguang Wu <[email protected]>
---
 clk-si5351.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-si5351.c +1 -1
index 79b770f..fedaeb1 100644
@@ -903,7 +903,7 @@ static int _si5351_clkout_set_disable_state(
 	return 0;
 }
 
-void _si5351_clkout_reset_pll(struct si5351_driver_data *drvdata, int num)
+static void _si5351_clkout_reset_pll(struct si5351_driver_data *drvdata, int num)
 {
 	u8 val = si5351_reg_read(drvdata, SI5351_CLK0_CTRL + num);
Applied
#2 lore raw

RFC PATCH 1/1 clk: si5351: _si5351_clkout_reset_pll() can be static

Quoted 4 lines · kbuild test robot
Fixes b26ff127c52c ("clk: si5351: Apply PLL soft reset before enabling the outputs")
Signed-off-by Fengguang Wu <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project