Skip to contentSkip to conversation

package/nut: don't build in parallel

PATCH New Yann E. MORIN 3 participants 4 messages Dec 28, 2017 – Dec 30, 2017

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH v2 1/1 package/nut: don't build in parallel

The conditions are not trivial to reproduce, but it can happen that the headers are not fully regenerated by the time they are included.

This only happens when a python and/or perl interpreter are available, with a high number of jobs and a high load.

Fixes:

    http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
    http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Peter Korsgaard <[email protected]>

---
Changes v1 -> v2:
- drop non-upstreamable patch, but just do not build in parallel (Peter)

---
 package/nut/nut.mk | 3 +++
 1 file changed, 3 insertions(+)
package/nut/nut.mk +3 -0
index 332ccf9071..4ea9947128 100644
@@ -14,6 +14,9 @@ NUT_DEPENDENCIES = host-pkgconf
 # Our patch changes m4 macros, so we need to autoreconf
 NUT_AUTORECONF = YES
 
+# Race condition in tools generation
+NUT_MAKE = $(MAKE1)
+
 # Put the PID files in a read-write place (/var/run is a tmpfs)
 # since the default location (/var/state/ups) maybe readonly.
 NUT_CONF_OPTS = \
Signature · 1 line
2.11.0
Applied
#1 lore raw

PATCH v2 1/1 package/nut: don't build in parallel

Hello,

Quoted 13 lines · Yann E. MORIN

The conditions are not trivial to reproduce, but it can happen that the headers are not fully regenerated by the time they are included.

This only happens when a python and/or perl interpreter are available, with a high number of jobs and a high load.

Fixes:

    http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
    http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Peter Korsgaard <[email protected]>
Quoted 6 lines

---
Changes v1 -> v2:
- drop non-upstreamable patch, but just do not build in parallel (Peter)

---
 package/nut/nut.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 package/nut: don't build in parallel

In reply to Yann E. MORIN
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

The conditions are not trivial to reproduce, but it can happen that the headers are not fully regenerated by the time they are included.

This only happens when a python and/or perl interpreter are available, with a high number of jobs and a high load.

Fixes:

    http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
    http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/
Quoted 6 lines
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Peter Korsgaard <[email protected]>

---
Changes v1 -> v2:
- drop non-upstreamable patch, but just do not build in parallel (Peter)

Committed to 2017.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/1 package/nut: don't build in parallel

In reply to Yann E. MORIN
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

The conditions are not trivial to reproduce, but it can happen that the headers are not fully regenerated by the time they are included.

This only happens when a python and/or perl interpreter are available, with a high number of jobs and a high load.

Fixes:

    http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
    http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/
Quoted 6 lines
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Peter Korsgaard <[email protected]>

---
Changes v1 -> v2:
- drop non-upstreamable patch, but just do not build in parallel (Peter)

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard