Skip to contentSkip to conversation

erlang: remove non-SMP build option

PATCH New Frank Hunleth 3 participants 3 messages Dec 20, 2017 – Dec 28, 2017

lore
Share & tools
lore

Frank Hunleth

author
#0 lore raw

PATCH v3 1/1 erlang: remove non-SMP build option

The non-SMP scheduler was deprecated with the Erlang/OTP 20.0 release and slated for removal with the next major Erlang release. Since the non-SMP scheduler isn't even built anymore, this option no longer has the intended effect of saving space or compile time. The SMP scheduler supports both SMP and non-SMP processors, so removing the option will not break any platforms.

We do not need to add a legacy entry, because the new behavior is the same as with the option previously set (i.e. SMP enabled).

Signed-off-by Frank Hunleth <[email protected]>

---
Changes v2 -> v3:
- Removed text from Config.in.legacy and added info as to why it wasn't needed (thanks to Yann)
Changes v1 -> v2:
- Added text to Config.in.legacy to explain the removal of the option

 package/erlang/Config.in | 10 ----------
 package/erlang/erlang.mk |  4 ----
 2 files changed, 14 deletions(-)
package/erlang/Config.in +0 -10
index 1cd93ca..96af551 100644
@@ -27,16 +27,6 @@ config BR2_PACKAGE_ERLANG
 
 if BR2_PACKAGE_ERLANG
 
-config BR2_PACKAGE_ERLANG_SMP
-	bool "enable SMP support"
-	help
-	  Erlang provides both a UP and an SMP emulator. The UP
-	  emulator is always built, and this option enables
-	  compilation of the SMP emulator. The choice of which
-	  emulator to use is made at runtime. If you do not need SMP
-	  support, turning this option off reduces compile time and
-	  the size of the Erlang installation.
-
 config BR2_PACKAGE_ERLANG_MEGACO
 	bool "install megaco application"
 	help
package/erlang/erlang.mk +0 -4
index 733c1d5..5705b98 100644
@@ -74,10 +74,6 @@ ERLANG_CONF_OPTS += --enable-shared-zlib
 ERLANG_DEPENDENCIES += zlib
 endif
 
-ifeq ($(BR2_PACKAGE_ERLANG_SMP),)
-ERLANG_CONF_OPTS += --disable-smp-support
-endif
-
 # Remove source, example, gs and wx files from staging and target.
 ERLANG_REMOVE_PACKAGES = gs wx
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/1 erlang: remove non-SMP build option

Frank, All,

On 2017-12-20 09:32 -0500, Frank Hunleth spake thusly:

Quoted 11 lines

The non-SMP scheduler was deprecated with the Erlang/OTP 20.0 release and slated for removal with the next major Erlang release. Since the non-SMP scheduler isn't even built anymore, this option no longer has the intended effect of saving space or compile time. The SMP scheduler supports both SMP and non-SMP processors, so removing the option will not break any platforms.

We do not need to add a legacy entry, because the new behavior is the same as with the option previously set (i.e. SMP enabled).

Signed-off-by Frank Hunleth <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 54 lines

---
Changes v2 -> v3:
- Removed text from Config.in.legacy and added info as to why it wasn't needed (thanks to Yann)
Changes v1 -> v2:
- Added text to Config.in.legacy to explain the removal of the option

 package/erlang/Config.in | 10 ----------
 package/erlang/erlang.mk |  4 ----
 2 files changed, 14 deletions(-)
package/erlang/Config.in +0 -10
index 1cd93ca..96af551 100644
@@ -27,16 +27,6 @@ config BR2_PACKAGE_ERLANG
 
 if BR2_PACKAGE_ERLANG
 
-config BR2_PACKAGE_ERLANG_SMP
-	bool "enable SMP support"
-	help
-	  Erlang provides both a UP and an SMP emulator. The UP
-	  emulator is always built, and this option enables
-	  compilation of the SMP emulator. The choice of which
-	  emulator to use is made at runtime. If you do not need SMP
-	  support, turning this option off reduces compile time and
-	  the size of the Erlang installation.
-
 config BR2_PACKAGE_ERLANG_MEGACO
 	bool "install megaco application"
 	help
package/erlang/erlang.mk +0 -4
index 733c1d5..5705b98 100644
@@ -74,10 +74,6 @@ ERLANG_CONF_OPTS += --enable-shared-zlib
 ERLANG_DEPENDENCIES += zlib
 endif
 
-ifeq ($(BR2_PACKAGE_ERLANG_SMP),)
-ERLANG_CONF_OPTS += --disable-smp-support
-endif
-
 # Remove source, example, gs and wx files from staging and target.
 ERLANG_REMOVE_PACKAGES = gs wx
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH v3 1/1 erlang: remove non-SMP build option

In reply to Frank Hunleth

Hello,

Quoted 10 lines · Frank Hunleth

The non-SMP scheduler was deprecated with the Erlang/OTP 20.0 release and slated for removal with the next major Erlang release. Since the non-SMP scheduler isn't even built anymore, this option no longer has the intended effect of saving space or compile time. The SMP scheduler supports both SMP and non-SMP processors, so removing the option will not break any platforms.

We do not need to add a legacy entry, because the new behavior is the same as with the option previously set (i.e. SMP enabled).

Quoted 7 lines
Signed-off-by Frank Hunleth <[email protected]>

---
Changes v2 -> v3:
- Removed text from Config.in.legacy and added info as to why it wasn't needed (thanks to Yann)
Changes v1 -> v2:
- Added text to Config.in.legacy to explain the removal of the option

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com