Skip to contentSkip to conversation

ncurses: Install 256 color terminfo files

PATCH New Trent Piepho 2 participants 4 messages Dec 20, 2017 – Jan 7, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ncurses: Install 256 color terminfo files

There are three 256 color terminfo files that buildroot only installs if ncurses is configured with wide character support, which also enables ext-color. There is a fourth 256 color terminfo file and does not depend on wchar suport and is always installed.

This changes that to always install all four 256 color terminfo files.

When ncurses has ext-colors enabled,it allows 256 fg and bg colors at the same time. Without ext-colors, it is still possible to use the 256 color terminfo files and one can get a combination of fb and bg colors that equals up to 256, e.g. 256 fg colors on one background or 16 fg and 16 bg colors.

In short, the 256 color files work fine without wchar or ext-color support and support more colors than the normal xterm, etc. terminfo files. It's common today for the default terminal to use xterm-256color and it's nice if thinks like vim and top work out of the box.

---
 package/ncurses/ncurses.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/ncurses/ncurses.mk +3 -4
index 94c8c9ade3..e63b6e4aed 100644
@@ -50,6 +50,7 @@ NCURSES_TERMINFO_FILES = \
 	d/dumb \
 	l/linux \
 	p/putty \
+	p/putty-256color \
 	p/putty-vt100 \
 	s/screen \
 	s/screen-256color \
@@ -59,6 +60,8 @@ NCURSES_TERMINFO_FILES = \
 	v/vt200 \
 	v/vt220 \
 	x/xterm \
+	x/xterm+256color \
+	x/xterm-256color \
 	x/xterm-color \
 	x/xterm-xfree86
 
@@ -97,10 +100,6 @@ NCURSES_LINK_STAGING_LIBS = \
 NCURSES_LINK_STAGING_PC = $(call NCURSES_LINK_PC)
 
 NCURSES_CONF_OPTS += --enable-ext-colors
-NCURSES_TERMINFO_FILES += \
-	p/putty-256color \
-	x/xterm+256color \
-	x/xterm-256color
 
 NCURSES_POST_INSTALL_STAGING_HOOKS += NCURSES_LINK_STAGING_LIBS
 NCURSES_POST_INSTALL_STAGING_HOOKS += NCURSES_LINK_STAGING_PC
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 ncurses: Install 256 color terminfo files

Hello,

Quoted 6 lines · Trent Piepho

There are three 256 color terminfo files that buildroot only installs if ncurses is configured with wide character support, which also enables ext-color. There is a fourth 256 color terminfo file and does not depend on wchar suport and is always installed.

This changes that to always install all four 256 color terminfo files.

The patch looks fine, but I'm confused when you say "all four 256 color terminfo files", while the patch only changes the installation of three terminfo files. Could you explain ?

Quoted 6 lines

When ncurses has ext-colors enabled,it allows 256 fg and bg colors at the same time. Without ext-colors, it is still possible to use the 256 color terminfo files and one can get a combination of fb and bg colors that equals up to 256, e.g. 256 fg colors on one background or 16 fg and 16 bg colors.

Quoted 6 lines

In short, the 256 color files work fine without wchar or ext-color support and support more colors than the normal xterm, etc. terminfo files. It's common today for the default terminal to use xterm-256color and it's nice if thinks like vim and top work out of the box.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 ncurses: Install 256 color terminfo files

Quoted 8 lines · Thomas Petazzoni

Hello,

Quoted 5 lines · Trent Piepho

There are three 256 color terminfo files that buildroot only installs if ncurses is configured with wide character support, which also enables ext-color. There is a fourth 256 color terminfo file and does not depend on wchar suport and is always installed.

Quoted 5 lines
Quoted 1 line

This changes that to always install all four 256 color terminfo files.

The patch looks fine, but I'm confused when you say "all four 256 color terminfo files", while the patch only changes the installation of three terminfo files. Could you explain ?

The fourth file is already always installed. I change from 3 wchar dependent plus 1 unconditional to 4 unconditional.

#3 lore raw

PATCH 1/1 ncurses: Install 256 color terminfo files

In reply to Trent Piepho

Hello,

Quoted 18 lines · Trent Piepho

There are three 256 color terminfo files that buildroot only installs if ncurses is configured with wide character support, which also enables ext-color. There is a fourth 256 color terminfo file and does not depend on wchar suport and is always installed.

This changes that to always install all four 256 color terminfo files.

When ncurses has ext-colors enabled,it allows 256 fg and bg colors at the same time. Without ext-colors, it is still possible to use the 256 color terminfo files and one can get a combination of fb and bg colors that equals up to 256, e.g. 256 fg colors on one background or 16 fg and 16 bg colors.

In short, the 256 color files work fine without wchar or ext-color support and support more colors than the normal xterm, etc. terminfo files. It's common today for the default terminal to use xterm-256color and it's nice if thinks like vim and top work out of the box.

Quoted 4 lines
---
 package/ncurses/ncurses.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com