Skip to contentSkip to conversation

i40e: Warn when setting link-down-on-close while in MFP

PATCH New Alice Michael 2 participants 2 messages Dec 29, 2017 – Jan 5, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 7/14 i40e: Warn when setting link-down-on-close while in MFP

From: Pawe? Jab?o?ski <[email protected]>

This patch adds a warning message when the link-down-on-close flag is setting on. The warning is printed only on MFP devices

---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +6 -0
index f829a7a..7267a93 100644
@@ -4479,6 +4479,12 @@ static int i40e_set_priv_flags(struct net_device *dev, u32 flags)
 		}
 	}
 
+	if ((changed_flags & pf->flags &
+	     I40E_FLAG_LINK_DOWN_ON_CLOSE_ENABLED) &&
+	    (pf->flags & I40E_FLAG_MFP_ENABLED))
+		dev_warn(&pf->pdev->dev,
+			 "Turning on link-down-on-close flag may affect other partitions\n");
+
 	if (changed_flags & I40E_FLAG_DISABLE_FW_LLDP) {
 		if (pf->flags & I40E_FLAG_DISABLE_FW_LLDP) {
 			struct i40e_dcbx_config *dcbcfg;
Signature · 1 line
2.9.5
#1 lore raw

PATCH 7/14 i40e: Warn when setting link-down-on-close while in MFP

Quoted 12 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Friday, December 29, 2017 5:50 AM
To: Michael, Alice <[email protected]>; intel-wired- lan at lists.osuosl.org
Cc: Jablonski, Pawel <[email protected]>
Subject: [Intel-wired-lan] [next PATCH S85-V1 07/14] i40e: Warn when setting link-down-on-close while in MFP

From: Pawe? Jab?o?ski <[email protected]>

Quoted 7 lines

This patch adds a warning message when the link-down-on-close flag is setting on. The warning is printed only on MFP devices

---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++++++
 1 file changed, 6 insertions(+)