Skip to contentSkip to conversation

x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT

PATCH In review Eric Biggers 3 participants 3 messages Dec 29, 2017 – Jan 8, 2018 x86

lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT

From: Eric Biggers <[email protected]>

ARCH_HAS_REFCOUNT is no longer marked as broken ('if BROKEN'), so remove the stale comment regarding it being broken.

Signed-off-by Eric Biggers <[email protected]>
---
 arch/x86/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/x86/Kconfig +0 -1
index d4fc98c50378..ff4e9cd99854 100644
@@ -55,7 +55,6 @@ config X86
 	select ARCH_HAS_GCOV_PROFILE_ALL
 	select ARCH_HAS_KCOV			if X86_64
 	select ARCH_HAS_PMEM_API		if X86_64
-	# Causing hangs/crashes, see the commit that added this change for details.
 	select ARCH_HAS_REFCOUNT
 	select ARCH_HAS_UACCESS_FLUSHCACHE	if X86_64
 	select ARCH_HAS_SET_MEMORY
Signature · 1 line
2.15.1
Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines · Eric Biggers

From: Eric Biggers <[email protected]>

ARCH_HAS_REFCOUNT is no longer marked as broken ('if BROKEN'), so remove the stale comment regarding it being broken.

Signed-off-by Eric Biggers <[email protected]>
---
 arch/x86/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/x86/Kconfig +0 -2
index d4fc98c50378..ff4e9cd99854 100644
@@ -55,7 +55,6 @@ config X86
        select ARCH_HAS_GCOV_PROFILE_ALL
        select ARCH_HAS_KCOV                    if X86_64
        select ARCH_HAS_PMEM_API                if X86_64
-       # Causing hangs/crashes, see the commit that added this change for details.
        select ARCH_HAS_REFCOUNT
        select ARCH_HAS_UACCESS_FLUSHCACHE      if X86_64
        select ARCH_HAS_SET_MEMORY
--
Quoted 2 lines

2.15.1

Thanks for the catch!

Acked-by Kees Cook <[email protected]>

-Kees

Signature · 2 lines
Kees Cook
Pixel Security
merge bot
#2 lore raw

[tip:locking/urgent] locking/refcounts: Remove stale comment from the ARCH_HAS_REFCOUNT Kconfig entry

In reply to Eric Biggers
locking/refcounts: Remove stale comment from the ARCH_HAS_REFCOUNT Kconfig entry
Commit-ID:  f328299e54a94998b31baf788d2b33d8122a4acb
Gitweb:     https://git.kernel.org/tip/f328299e54a94998b31baf788d2b33d8122a4acb
Author:     Eric Biggers <[email protected]>
AuthorDate: Fri, 29 Dec 2017 13:53:03 -0600
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 8 Jan 2018 20:05:04 +0100

locking/refcounts: Remove stale comment from the ARCH_HAS_REFCOUNT Kconfig entry

ARCH_HAS_REFCOUNT is no longer marked as broken ('if BROKEN'), so remove the stale comment regarding it being broken.

Signed-off-by Eric Biggers <[email protected]>
Cc Kees Cook <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Ingo Molnar <[email protected]>
---
 arch/x86/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/x86/Kconfig +0 -1
index d4fc98c..ff4e9cd 100644
@@ -55,7 +55,6 @@ config X86
 	select ARCH_HAS_GCOV_PROFILE_ALL
 	select ARCH_HAS_KCOV			if X86_64
 	select ARCH_HAS_PMEM_API		if X86_64
-	# Causing hangs/crashes, see the commit that added this change for details.
 	select ARCH_HAS_REFCOUNT
 	select ARCH_HAS_UACCESS_FLUSHCACHE	if X86_64
 	select ARCH_HAS_SET_MEMORY