Skip to contentSkip to conversation

tools: usb: usbip: fix fd leak in case of 'fread' failure

PATCH In review Elad Wexler 2 participants 2 messages Dec 30, 2017 – Jan 2, 2018

Subsystems (2)
USB USB over IP driver
lore
Share & tools
lore

Elad Wexler

author
#0 lore raw

PATCH 1/1 tools: usb: usbip: fix fd leak in case of 'fread' failure

Fix possible resource leak: fd

Signed-off-by Elad Wexler <[email protected]>
---
 tools/usb/usbip/libsrc/usbip_device_driver.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tools/usb/usbip/libsrc/usbip_device_driver.c +4 -1
index e059b7d..1aa27af 100644
@@ -92,7 +92,7 @@ int read_usb_vudc_device(struct udev_device *sdev, struct usbip_usb_device *dev)
 		return -1;
 	ret = fread((char *) &descr, sizeof(descr), 1, fd);
 	if (ret < 0)
-		return -1;
+		goto err;
 	fclose(fd);
 
 	copy_descr_attr(dev, &descr, bDeviceClass);

@@ -124,6 +124,9 @@ int read_usb_vudc_device(struct udev_device *sdev, struct usbip_usb_device *dev)
 	name = udev_device_get_sysname(plat);
 	strncpy(dev->busid, name, SYSFS_BUS_ID_SIZE);
 	return 0;
+err:
+	fclose(fd);
+	return -1;
 }
 
 static int is_my_device(struct udev_device *dev)