Skip to contentSkip to conversation

eeprog: fix homepage link

PATCH New Baruch Siach 4 participants 9 messages Dec 31, 2017 – Jan 29, 2018

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 eeprog: fix homepage link

The current link leads to a 400 Bad Request error page.

Cc Matt Weber <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/eeprog/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/eeprog/Config.in +1 -1
index ff313bdbae96..73582c70f9d4 100644
@@ -3,4 +3,4 @@ config BR2_PACKAGE_EEPROG
 	help
 	  Simple tool to read/write i2c eeprom chips.
 
-	  http://codesink.org/eeprog.html
+	  http://www.codesink.org/eeprog.html
Signature · 1 line
2.15.1
Applied
#1 lore raw

PATCH 1/1 eeprog: fix homepage link

Hello,

Quoted 7 lines · Baruch Siach

The current link leads to a 400 Bad Request error page.

Cc Matt Weber <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/eeprog/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. However, do we still need this package, now that i2c-tools also builds/installs eeprog ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 eeprog: fix homepage link

Hi Thomas,

Quoted 11 lines · Thomas Petazzoni
Quoted 7 lines · Baruch Siach

The current link leads to a 400 Bad Request error page.

Cc Matt Weber <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/eeprog/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. However, do we still need this package, now that i2c-tools also builds/installs eeprog ?

Probably not. Event worse. When both i2c-tools and eeprog are enabled, the target /usr/bin/eeprog depends on the build order. Has the autobuilder caught this file overwrite?

Are you OK with dropping eeprog? Matt?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#3 lore raw

PATCH 1/1 eeprog: fix homepage link

Hello,

Quoted 4 lines · Baruch Siach
Quoted 2 lines

Applied to master, thanks. However, do we still need this package, now that i2c-tools also builds/installs eeprog ?

Probably not.

Do they provide the same features ?

Quoted 3 lines

Event worse. When both i2c-tools and eeprog are enabled, the target /usr/bin/eeprog depends on the build order. Has the autobuilder caught this file overwrite?

It will, be currently such errors are not errors, but warnings: they don't make the build fail. Yann recently posted a patch that would allow to turn such warnings into errors, but there are so many of such overwrites today that enabling such an option in the autobuilders would turn almost all results to NOK.

Quoted 1 line

Are you OK with dropping eeprog? Matt?

I don't use eeprog, so I don't really care. But if the standalone eeprog and the one on i2c-tools are equivalent, I think it makes sense to keep the one from i2c-tools.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 eeprog: fix homepage link

Hi Thomas,

Quoted 7 lines · Thomas Petazzoni
Quoted 4 lines · Baruch Siach
Quoted 2 lines

Applied to master, thanks. However, do we still need this package, now that i2c-tools also builds/installs eeprog ?

Probably not.

Do they provide the same features ?

They are both based on the same code. It looks like i2c-tools adopted eeprog after the last eeprog release in February 2004.

Quoted 10 lines
Quoted 3 lines

Event worse. When both i2c-tools and eeprog are enabled, the target /usr/bin/eeprog depends on the build order. Has the autobuilder caught this file overwrite?

It will, be currently such errors are not errors, but warnings: they don't make the build fail. Yann recently posted a patch that would allow to turn such warnings into errors, but there are so many of such overwrites today that enabling such an option in the autobuilders would turn almost all results to NOK.

Quoted 5 lines
Quoted 1 line

Are you OK with dropping eeprog? Matt?

I don't use eeprog, so I don't really care. But if the standalone eeprog and the one on i2c-tools are equivalent, I think it makes sense to keep the one from i2c-tools.

OK. Let's give Matt some time to recover from the holidays and respond before I send a patch to remove the eeprog package.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#5 lore raw

PATCH 1/1 eeprog: fix homepage link

Hello,

Quoted 2 lines · Baruch Siach

They are both based on the same code. It looks like i2c-tools adopted eeprog after the last eeprog release in February 2004.

OK.

Quoted 2 lines

OK. Let's give Matt some time to recover from the holidays and respond before I send a patch to remove the eeprog package.

Sounds good. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#6 lore raw

PATCH 1/1 eeprog: fix homepage link

Baruch, Thomas,

Quoted 5 lines · Thomas Petazzoni

Hello,

Quoted 2 lines

OK. Let's give Matt some time to recover from the holidays and respond before I send a patch to remove the eeprog package.

Removal sounds good to me.

Angelo, thanks for bumping i2c-tools! Lots of good stuff with this cleanup and the new tools we now install.

Matt