Skip to contentSkip to conversation

i2c-tools: fix missing runtime library

PATCH New Baruch Siach 2 participants 2 messages Dec 31, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c-tools: fix missing runtime library

When building with dynamic library support, i2c-tools utilities are linked against the libi2c.so library. Current i2c-tools install commands don't take this into account, which leads to the following run-time error:

eeprog: error while loading shared libraries: libi2c.so.0: cannot open shared object file: No such file or directory

Use the native install target to fix that.

Cc Angelo Compagnucci <[email protected]>
Cc Matt Weber <[email protected]>

---

I think we can also get rid of I2C_TOOLS_INSTALL_PYSMBUS now. But let's fix the bug first.

---
 package/i2c-tools/i2c-tools.mk | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
package/i2c-tools/i2c-tools.mk +2 -5
index 0f71fd4fb581..9ddaa7278673 100644
@@ -61,11 +61,8 @@ define I2C_TOOLS_BUILD_CMDS
 endef
 
 define I2C_TOOLS_INSTALL_TARGET_CMDS
-	for i in i2cdump i2cget i2cset i2cdetect i2ctransfer; \
-	do \
-		$(INSTALL) -m 755 -D $(@D)/tools/$$i $(TARGET_DIR)/usr/sbin/$$i; \
-	done
-	$(INSTALL) -m 755 -D $(@D)/eeprog/eeprog $(TARGET_DIR)/usr/bin/eeprog;
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
+		DESTDIR="$(TARGET_DIR)" prefix=/usr -C $(@D) install
 	$(I2C_TOOLS_INSTALL_PYSMBUS)
 endef
 
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/1 i2c-tools: fix missing runtime library

Hello,

Quoted 5 lines · Baruch Siach

When building with dynamic library support, i2c-tools utilities are linked against the libi2c.so library. Current i2c-tools install commands don't take this into account, which leads to the following run-time error:

Quoted 8 lines

eeprog: error while loading shared libraries: libi2c.so.0: cannot open shared object file: No such file or directory

Use the native install target to fix that.

Cc Angelo Compagnucci <[email protected]>
Cc Matt Weber <[email protected]>

---

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com