Skip to contentSkip to conversation

powerpc: Add more Power7 specific definitions

PATCH In review Michael Neuling 3 participants 5 messages Feb 13, 2012 – Feb 14, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Add more Power7 specific definitions

stable-2.6.27.60 added c24cb8e5 which uses PV_POWER7 but it's not defined. Following patch adds these definitions.

From: Benjamin Herrenschmidt <[email protected]>

commit 50fb8ebe7c4ad60d147700d253f78bd1e615a526 upstream

powerpc: Add more Power7 specific definitions

This adds more SPR definitions used on newer processors when running in hypervisor mode. Along with some other P7 specific bits and pieces

---
 arch/powerpc/include/asm/ppc_asm.h |    1 
 arch/powerpc/include/asm/reg.h     |   45 ++++++++++++++++++++++++++++++++++++-
 2 files changed, 45 insertions(+), 1 deletion(-)
arch/powerpc/include/asm/ppc_asm.h +1 -0
Index: clone1/arch/powerpc/include/asm/ppc_asm.h
===================================================================
@@ -166,6 +166,7 @@ END_FTR_SECTION_IFCLR(CPU_FTR_PURR);
 #define HMT_MEDIUM	or	2,2,2
 #define HMT_MEDIUM_HIGH or	5,5,5		# medium high priority
 #define HMT_HIGH	or	3,3,3
+#define HMT_EXTRA_HIGH	or	7,7,7		# power7 only
 
 /* handle instructions that older assemblers may not know */
 #define RFCI		.long 0x4c000066	/* rfci instruction */
arch/powerpc/include/asm/reg.h +44 -1

70 lines not on this page · raw message

#1 lore raw
Quoted 2 lines · Michael Neuling

stable-2.6.27.60 added c24cb8e5 which uses PV_POWER7 but it's not defined. Following patch adds these definitions.

Thank you for the report Michael, I have no PPC toolchain so I have not tested this one. Added now.

Just one question, with this release, no -rc patch was emitted. Do you think you would have built it in time if I had provided a way to retrieve the -rc patch ? I'm asking because it's much more difficult right now to put it somewhere, but for instance it can be emitted with the announcement mail.

Regards,
Willy

#2 lore raw

Willy,

Quoted 5 lines
Quoted 2 lines

stable-2.6.27.60 added c24cb8e5 which uses PV_POWER7 but it's not defined. Following patch adds these definitions.

Thank you for the report Michael, I have no PPC toolchain so I have not tested this one. Added now.

No problem.

Quoted 5 lines

Just one question, with this release, no -rc patch was emitted. Do you think you would have built it in time if I had provided a way to retrieve the -rc patch ? I'm asking because it's much more difficult right now to put it somewhere, but for instance it can be emitted with the announcement mail.

I would test it but to fit with my work flow I'd really like the rc in a git tree. I've asked gregkh to do this in the past, but he's not been able to. Hence I only test the final releases.

Thanks,
Mikey

#4 lore raw

Hi Tony,

Quoted 10 lines · Tony Breeds
Quoted 6 lines · Willy Tarreau
Quoted 2 lines · Michael Neuling

stable-2.6.27.60 added c24cb8e5 which uses PV_POWER7 but it's not defined. Following patch adds these definitions.

Thank you for the report Michael, I have no PPC toolchain so I have not tested this one. Added now.

Just pimping the cross toolchains I build:
http://kernel.org/pub/tools/crosstool/files/bin/

Thanks for this pointer, it can indeed be quite useful from time to time, especially to check gcc-related regressions.

That said, I'd rather not install a number of toolchains for systems I can't test. I regularly build for i386/x86_64/arm with real configs that I can boot a machine on when I have a doubt. Building random configs do not always test all source code, especially on architectures which support a wide variety of embedded platforms.

But I'm keeping the URL, Thanks :-)
Willy