Skip to contentSkip to conversation

Improve compatibility with other platforms

PATCH In review [email protected] 4 participants 13 messages Jan 1, 2018 – Jan 4, 2018 11 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Improve compatibility with other platforms

This doesn't make things work out of the box necessarily, but it gets us a step closer.

- alloca(3) on FreeBSD and OpenBSD, at least, is provided as part of
<stdlib.h>. I make the change here for FreeBSD only, though, as I cannot test it on OpenBSD.

- stat -c %s's equivalent on FreeBSD is stat -f %Uz; these differ enough, allow
STATSZ in the environment to specify local replacement for a stat that outputs size in bytes of an argument.

This greatly reduces, but not eliminates, the magnitude of patch needed to run the test suite successfully on other platforms. It also helps denote where changes may be required.

---
 fdtoverlay.c       |  3 +++
 tests/run_tests.sh | 13 +++++++++----
 2 files changed, 12 insertions(+), 4 deletions(-)
fdtoverlay.c +3 -0
index 7f124fc..7d60021 100644
@@ -26,7 +26,10 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+/* alloc(3) is provided by stdlib.h on some platforms */
+#ifndef __FreeBSD__
 #include <alloca.h>
+#endif
 #include <inttypes.h>
 
 #include <libfdt.h>
tests/run_tests.sh +9 -4
index d36dffb..13c9f1c 100755
@@ -6,6 +6,11 @@ if [ -z "$CC" ]; then
     CC=gcc
 fi
 
+# stat differs between platforms
+if [ -z "$STATSZ" ]; then
+	STATSZ="stat -c %s"
+fi
+
 export QUIET_TEST=1
 STOP_ON_FAIL=0
 
@@ -114,7 +119,7 @@ run_wrap_error_test () {
 # $2: align base
 check_align () {
     shorten_echo "check_align $@:	"
-    local size=$(stat -c %s "$1")
+    local size=$($STATSZ "$1")
     local align="$2"
     (
 	if [ $(($size % $align)) -eq 0 ] ;then
@@ -714,7 +719,7 @@ fdtput_tests () {
     text=lorem.txt
 
     # Allow just enough space for $text
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $($STATSZ $text) -o $dtb $dts
 
     # run_fdtput_test <expected-result> <file> <node> <property> <flags> <value>
     run_fdtput_test "a_model" $dtb / model -ts "a_model"
@@ -733,7 +738,7 @@ fdtput_tests () {
     run_fdtput_test "$(cat $text $text)" $dtb /randomnode blob -ts "$(cat $text $text)"
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $($STATSZ $text) -o $dtb $dts
 
     # Node creation
     run_wrap_error_test $DTPUT $dtb -c /baldrick sod
@@ -761,7 +766,7 @@ fdtput_tests () {
     run_wrap_test $DTPUT $dtb -cp /chosen/son
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $($STATSZ $text) -o $dtb $dts
 
     # Node delete
     run_wrap_test $DTPUT $dtb -c /chosen/node1 /chosen/node2 /chosen/node3
Signature · 1 line
2.15.1

A message that is not in the archive (sent off-list or not yet received): 20180101041518.23806-1-kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org

#2 lore raw
Quoted 6 lines · On Sun, Dec 31, 2017 at 10:15:18PM -0600…

This doesn't make things work out of the box necessarily, but it gets us a step closer.

- alloca(3) on FreeBSD and OpenBSD, at least, is provided as part of
<stdlib.h>. I make the change here for FreeBSD only, though, as I cannot test it on OpenBSD.

TBH, rather than dicking around with #ifdefs and headers, I'd rather use use malloc() instead of alloca().

Quoted 3 lines

- stat -c %s's equivalent on FreeBSD is stat -f %Uz; these differ enough, allow
STATSZ in the environment to specify local replacement for a stat that outputs size in bytes of an argument.

Can you split this change out into a separate patch, please.

Quoted 80 lines

This greatly reduces, but not eliminates, the magnitude of patch needed to run the test suite successfully on other platforms. It also helps denote where changes may be required.

---
 fdtoverlay.c       |  3 +++
 tests/run_tests.sh | 13 +++++++++----
 2 files changed, 12 insertions(+), 4 deletions(-)
fdtoverlay.c +3 -0
index 7f124fc..7d60021 100644
@@ -26,7 +26,10 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+/* alloc(3) is provided by stdlib.h on some platforms */
+#ifndef __FreeBSD__
 #include <alloca.h>
+#endif
 #include <inttypes.h>
 
 #include <libfdt.h>
tests/run_tests.sh +9 -4
index d36dffb..13c9f1c 100755
@@ -6,6 +6,11 @@ if [ -z "$CC" ]; then
     CC=gcc
 fi
 
+# stat differs between platforms
+if [ -z "$STATSZ" ]; then
+	STATSZ="stat -c %s"
+fi
+
 export QUIET_TEST=1
 STOP_ON_FAIL=0
 
@@ -114,7 +119,7 @@ run_wrap_error_test () {
 # $2: align base
 check_align () {
     shorten_echo "check_align $@:	"
-    local size=$(stat -c %s "$1")
+    local size=$($STATSZ "$1")
     local align="$2"
     (
 	if [ $(($size % $align)) -eq 0 ] ;then
@@ -714,7 +719,7 @@ fdtput_tests () {
     text=lorem.txt
 
     # Allow just enough space for $text
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $($STATSZ $text) -o $dtb $dts
 
     # run_fdtput_test <expected-result> <file> <node> <property> <flags> <value>
     run_fdtput_test "a_model" $dtb / model -ts "a_model"
@@ -733,7 +738,7 @@ fdtput_tests () {
     run_fdtput_test "$(cat $text $text)" $dtb /randomnode blob -ts "$(cat $text $text)"
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $($STATSZ $text) -o $dtb $dts
 
     # Node creation
     run_wrap_error_test $DTPUT $dtb -c /baldrick sod
@@ -761,7 +766,7 @@ fdtput_tests () {
     run_wrap_test $DTPUT $dtb -cp /chosen/son
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $($STATSZ $text) -o $dtb $dts
 
     # Node delete
     run_wrap_test $DTPUT $dtb -c /chosen/node1 /chosen/node2 /chosen/node3
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 10 lines · David Gibson
Quoted 6 lines · On Sun, Dec 31, 2017 at 10:15:18PM -0600…

This doesn't make things work out of the box necessarily, but it gets us a step closer.

- alloca(3) on FreeBSD and OpenBSD, at least, is provided as part of
<stdlib.h>. I make the change here for FreeBSD only, though, as I cannot test it on OpenBSD.

TBH, rather than dicking around with #ifdefs and headers, I'd rather use use malloc() instead of alloca().

Alrighty- I'll prepare a patch for this, knowing that's a direction you're comfortable heading in.

Quoted 5 lines
Quoted 3 lines

- stat -c %s's equivalent on FreeBSD is stat -f %Uz; these differ enough, allow
STATSZ in the environment to specify local replacement for a stat that outputs size in bytes of an argument.

Can you split this change out into a separate patch, please.

Will do.

A message that is not in the archive (sent off-list or not yet received): CACNAnaEpF9sK6dNbPG4_f_tyrp3yq1nyG+SS40VUgBCkLqYJdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#6 lore raw
Quoted 16 lines · Kyle Evans
Quoted 10 lines · David Gibson
Quoted 6 lines · On Sun, Dec 31, 2017 at 10:15:18PM -0600…

This doesn't make things work out of the box necessarily, but it gets us a step closer.

- alloca(3) on FreeBSD and OpenBSD, at least, is provided as part of
<stdlib.h>. I make the change here for FreeBSD only, though, as I cannot test it on OpenBSD.

TBH, rather than dicking around with #ifdefs and headers, I'd rather use use malloc() instead of alloca().

Alrighty- I'll prepare a patch for this, knowing that's a direction you're comfortable heading in.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

- stat -c %s's equivalent on FreeBSD is stat -f %Uz; these differ enough, allow
STATSZ in the environment to specify local replacement for a stat that outputs size in bytes of an argument.

Can you split this change out into a separate patch, please.

Will do.

Fwiw, some years ago I did a bunch of work to get dtc to compile and pass the tests on FreeBSD. Working out of the box on *BSD is something I'd like it to have. Unfortunately, because I can't easily test on a BSD machine, the BSD support tends to bitrot rather rapidly.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw
Quoted 4 lines · David Gibson

Fwiw, some years ago I did a bunch of work to get dtc to compile and pass the tests on FreeBSD. Working out of the box on *BSD is something I'd like it to have. Unfortunately, because I can't easily test on a BSD machine, the BSD support tends to bitrot rather rapidly.

Happy to hear this. =) You're not too far off, fortunately. This, the alloca header situation, and an -ldl in tests/Makefile.tests are the only obstacles to being able to do a simple "gmake && gmake check" here. I've submitted patches for the first two, and as of r320872 [1] we provide a libdl on -HEAD.

I will likely submit a patch in the near future to use stat -f %Uz automatically if stat --version exits with a non-zero exit code or indicates that it's GNU stat(1). This should cover the *BSDs, to include MacOS.

[1] https://svnweb.freebsd.org/base?view=revision&revision=320872

A message that is not in the archive (sent off-list or not yet received): CACNAnaFntyUbpiVVwFfiL_0EtX894Uidsdca3_jdBcNOVM4f0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#10 lore raw
Quoted 9 lines · Kyle Evans
Quoted 4 lines · David Gibson

Fwiw, some years ago I did a bunch of work to get dtc to compile and pass the tests on FreeBSD. Working out of the box on *BSD is something I'd like it to have. Unfortunately, because I can't easily test on a BSD machine, the BSD support tends to bitrot rather rapidly.

Happy to hear this. =) You're not too far off, fortunately.

Good to hear.

Quoted 5 lines

This, the
alloca header situation, and an -ldl in tests/Makefile.tests are the only obstacles to being able to do a simple "gmake && gmake check" here. I've submitted patches for the first two, and as of r320872 [1] we provide a libdl on -HEAD.

Ok sounds good. I had a look at the tests using -ldl and it looks like they couldn't easily be adapted to avoid it. However, I'd be ok with logic to skip those tests if libdl isn't available, if you want to broaden support to older releases.

At the moment dtc seems to be just teetering on the edge of being complex enough to need some sort of configuration system (whether it be hand-rolled scripts, autoconf or whatever). So far I've been avoiding adding such a thing, because that introduces a bunch of problems of its own: hand rolled scripts are a pain to maintain, autoconf is ugly as sin, pretty much anything else is nonstandard and liable to introduce a bunch of extra dependencies. But, I might have to bite the bullet at some point.

Quoted 4 lines

I will likely submit a patch in the near future to use stat -f %Uz automatically if stat --version exits with a non-zero exit code or indicates that it's GNU stat(1). This should cover the *BSDs, to include MacOS.

Great. MacOS support is interesting in particular, because unlike FreeBSD, I can set up a Travis build to test it there, which means I'm much more likely to catch regressions. In fact, looks like I have a stale branch here that added an OSX build to the travis.yml - I think some of the errors you've found and didn't have time to debug them (debugging when your only host is indirect through Travis is pretty painful).

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): [email protected]

#12 lore raw

[Resending with a proper mail client, because my initial response didn't go to the lists]

Quoted 4 lines · David Gibson

Ok sounds good. I had a look at the tests using -ldl and it looks like they couldn't easily be adapted to avoid it. However, I'd be ok with logic to skip those tests if libdl isn't available, if you want to broaden support to older releases.

The hard part is that libdl doesn't need to be available. With FreeBSD (and generally, all BSDs if I understood right), the symbols expected of libdl are available in libc.

If I have my terminology right, our libdl is in fact just a filter on libc to isolate these symbols/functions for all of the software that expected libdl. We'd spent enough time patching out -ldl that it seemed a good idea, but these binaries *do* compile without it.

Quoted 8 lines

At the moment dtc seems to be just teetering on the edge of being complex enough to need some sort of configuration system (whether it be hand-rolled scripts, autoconf or whatever). So far I've been avoiding adding such a thing, because that introduces a bunch of problems of its own: hand rolled scripts are a pain to maintain, autoconf is ugly as sin, pretty much anything else is nonstandard and liable to introduce a bunch of extra dependencies. But, I might have to bite the bullet at some point.

Ugh, build systems. =P

Quoted 7 lines

Great. MacOS support is interesting in particular, because unlike FreeBSD, I can set up a Travis build to test it there, which means I'm much more likely to catch regressions. In fact, looks like I have a stale branch here that added an OSX build to the travis.yml - I think some of the errors you've found and didn't have time to debug them (debugging when your only host is indirect through Travis is pretty painful).

It'd be interesting to see those results as of recent. Their userland should be similar enough in the ways you care about for the results to likely be relevant to us, I would think.

A message that is not in the archive (sent off-list or not yet received): CACNAnaGwpwRO27d2trLBqZjtiZYP1HBP=ck6GJ2N8VrTNehnFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#14 lore raw
Quoted 10 lines · Kyle Evans

[Resending with a proper mail client, because my initial response didn't go to the lists]

Quoted 4 lines · David Gibson

Ok sounds good. I had a look at the tests using -ldl and it looks like they couldn't easily be adapted to avoid it. However, I'd be ok with logic to skip those tests if libdl isn't available, if you want to broaden support to older releases.

Quoted 8 lines

The hard part is that libdl doesn't need to be available. With FreeBSD (and generally, all BSDs if I understood right), the symbols expected of libdl are available in libc.

If I have my terminology right, our libdl is in fact just a filter on libc to isolate these symbols/functions for all of the software that expected libdl. We'd spent enough time patching out -ldl that it seemed a good idea, but these binaries *do* compile without it.

Ah, right.

I that case, I think the approach to take is to make a new LIBDL make variable with the "-ldl" in it, so that it can be overridden on *BSD to be empty.

Quoted 11 lines
Quoted 9 lines

At the moment dtc seems to be just teetering on the edge of being complex enough to need some sort of configuration system (whether it be hand-rolled scripts, autoconf or whatever). So far I've been avoiding adding such a thing, because that introduces a bunch of problems of its own: hand rolled scripts are a pain to maintain, autoconf is ugly as sin, pretty much anything else is nonstandard and liable to introduce a bunch of extra dependencies. But, I might have to bite the bullet at some point.

Ugh, build systems. =P

I know, right.

Quoted 11 lines
Quoted 7 lines

Great. MacOS support is interesting in particular, because unlike FreeBSD, I can set up a Travis build to test it there, which means I'm much more likely to catch regressions. In fact, looks like I have a stale branch here that added an OSX build to the travis.yml - I think some of the errors you've found and didn't have time to debug them (debugging when your only host is indirect through Travis is pretty painful).

It'd be interesting to see those results as of recent. Their userland should be similar enough in the ways you care about for the results to likely be relevant to us, I would think.

I rebased and tried it again:

    https://travis-ci.org/dgibson/dtc/jobs/324587391

Looks like we're getting problems with the interesting way I (ab)use the assembler to produce a test blob. I've hit a number of problems with that over time, so I'd really like to replace it with something else. Unfortunately, I haven't yet thought of a replacement that wouldn't be a pain in the arse.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): [email protected]

#16 lore raw
Quoted 16 lines · David Gibson
Quoted 11 lines · Kyle Evans
Quoted 8 lines · David Gibson

[... snip ...]
Great. MacOS support is interesting in particular, because unlike FreeBSD, I can set up a Travis build to test it there, which means I'm much more likely to catch regressions. In fact, looks like I have a stale branch here that added an OSX build to the travis.yml - I think some of the errors you've found and didn't have time to debug them (debugging when your only host is indirect through Travis is pretty painful).

Quoted 3 lines

It'd be interesting to see those results as of recent. Their userland should be similar enough in the ways you care about for the results to likely be relevant to us, I would think.

Quoted 8 lines

I rebased and tried it again:

    https://travis-ci.org/dgibson/dtc/jobs/324587391

Looks like we're getting problems with the interesting way I (ab)use the assembler to produce a test blob. I've hit a number of problems with that over time, so I'd really like to replace it with something else. Unfortunately, I haven't yet thought of a replacement that wouldn't be a pain in the arse.

That's interesting- I wonder what version of LLVM this maps to? Or are they so far gone that it doesn't matter? We've got an effort over here going to replace our system linker with LLD; the version of LLD that we're optionally using on -HEAD right now has no problem with this:

$ ld.lld --version
LLD 5.0.1 (FreeBSD 320880) (compatible with GNU linkers)

A message that is not in the archive (sent off-list or not yet received): CACNAnaGEV=YDFsLbGBN+O68dJnDXeRwd0YaXWb2u3x1rSdkF8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#18 lore raw
Quoted 27 lines · Kyle Evans
Quoted 16 lines · David Gibson
Quoted 11 lines · Kyle Evans
Quoted 8 lines · David Gibson

[... snip ...]
Great. MacOS support is interesting in particular, because unlike FreeBSD, I can set up a Travis build to test it there, which means I'm much more likely to catch regressions. In fact, looks like I have a stale branch here that added an OSX build to the travis.yml - I think some of the errors you've found and didn't have time to debug them (debugging when your only host is indirect through Travis is pretty painful).

Quoted 3 lines

It'd be interesting to see those results as of recent. Their userland should be similar enough in the ways you care about for the results to likely be relevant to us, I would think.

Quoted 8 lines

I rebased and tried it again:

    https://travis-ci.org/dgibson/dtc/jobs/324587391

Looks like we're getting problems with the interesting way I (ab)use the assembler to produce a test blob. I've hit a number of problems with that over time, so I'd really like to replace it with something else. Unfortunately, I haven't yet thought of a replacement that wouldn't be a pain in the arse.

Quoted 7 lines

That's interesting- I wonder what version of LLVM this maps to? Or are they so far gone that it doesn't matter? We've got an effort over here going to replace our system linker with LLD; the version of LLD that we're optionally using on -HEAD right now has no problem with this:

$ ld.lld --version
LLD 5.0.1 (FreeBSD 320880) (compatible with GNU linkers)

I think the problem is at the asm level, rather than the linker level. Specifically I think it's failing to realize that expressions of the form (sym2 - sym1) where sym2 and sym1 are both local labels are actually assemble time constant and don't need relocation, even if the symbols themselves do.

If they actually did need relocation, I don't think they're in a form I'd expect any linker to be able to cope with (or even the ELF format itself).

I suppose it's possible there's something in the OSX ABI which means these things really can't be assemble time evaluated, in which case we'd be pretty stuck.

According to the Travis logs it's using:

$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I'm assuming it will be using the same LLVM version for assembling as compiling. Given how out of date the Linux images often are on Travis, it wouldn't suprise me of the OSX ones are as well.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
#19 lore raw
In reply to a message not in the archive
Quoted 24 lines · David Gibson
Quoted 9 lines · Kyle Evans
Quoted 4 lines · David Gibson

Fwiw, some years ago I did a bunch of work to get dtc to compile and pass the tests on FreeBSD. Working out of the box on *BSD is something I'd like it to have. Unfortunately, because I can't easily test on a BSD machine, the BSD support tends to bitrot rather rapidly.

Happy to hear this. =) You're not too far off, fortunately.

Good to hear.

Quoted 5 lines

This, the
alloca header situation, and an -ldl in tests/Makefile.tests are the only obstacles to being able to do a simple "gmake && gmake check" here. I've submitted patches for the first two, and as of r320872 [1] we provide a libdl on -HEAD.

Ok sounds good. I had a look at the tests using -ldl and it looks like they couldn't easily be adapted to avoid it. However, I'd be ok with logic to skip those tests if libdl isn't available, if you want to broaden support to older releases.

Quoted 8 lines

At the moment dtc seems to be just teetering on the edge of being complex enough to need some sort of configuration system (whether it be hand-rolled scripts, autoconf or whatever). So far I've been avoiding adding such a thing, because that introduces a bunch of problems of its own: hand rolled scripts are a pain to maintain, autoconf is ugly as sin, pretty much anything else is nonstandard and liable to introduce a bunch of extra dependencies. But, I might have to bite the bullet at some point.

What about meson? All the cool kids are using it now.

Rob

A message that is not in the archive (sent off-list or not yet received): CAL_JsqK+ySbuCC27sSQ+VJg78n0m_QOTHQ90ur5pwahyBoU0Dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#21 lore raw
Quoted 35 lines · Rob Herring
Quoted 24 lines · David Gibson
Quoted 9 lines · Kyle Evans
Quoted 4 lines · David Gibson

Fwiw, some years ago I did a bunch of work to get dtc to compile and pass the tests on FreeBSD. Working out of the box on *BSD is something I'd like it to have. Unfortunately, because I can't easily test on a BSD machine, the BSD support tends to bitrot rather rapidly.

Happy to hear this. =) You're not too far off, fortunately.

Good to hear.

Quoted 5 lines

This, the
alloca header situation, and an -ldl in tests/Makefile.tests are the only obstacles to being able to do a simple "gmake && gmake check" here. I've submitted patches for the first two, and as of r320872 [1] we provide a libdl on -HEAD.

Ok sounds good. I had a look at the tests using -ldl and it looks like they couldn't easily be adapted to avoid it. However, I'd be ok with logic to skip those tests if libdl isn't available, if you want to broaden support to older releases.

Quoted 8 lines

At the moment dtc seems to be just teetering on the edge of being complex enough to need some sort of configuration system (whether it be hand-rolled scripts, autoconf or whatever). So far I've been avoiding adding such a thing, because that introduces a bunch of problems of its own: hand rolled scripts are a pain to maintain, autoconf is ugly as sin, pretty much anything else is nonstandard and liable to introduce a bunch of extra dependencies. But, I might have to bite the bullet at some point.

Quoted 1 line

What about meson? All the cool kids are using it now.

Heh, hadn't heard of that one. Too busy maintaining vital infrastructure to follow what the cool kids are doing.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): [email protected]

#23 lore raw
Quoted 36 lines · David Gibson
Quoted 35 lines · Rob Herring
Quoted 32 lines · David Gibson
Quoted 9 lines · Kyle Evans
Quoted 4 lines · David Gibson

Fwiw, some years ago I did a bunch of work to get dtc to compile and pass the tests on FreeBSD. Working out of the box on *BSD is something I'd like it to have. Unfortunately, because I can't easily test on a BSD machine, the BSD support tends to bitrot rather rapidly.

Happy to hear this. =) You're not too far off, fortunately.

Good to hear.

Quoted 5 lines

This, the
alloca header situation, and an -ldl in tests/Makefile.tests are the only obstacles to being able to do a simple "gmake && gmake check" here. I've submitted patches for the first two, and as of r320872 [1] we provide a libdl on -HEAD.

Ok sounds good. I had a look at the tests using -ldl and it looks like they couldn't easily be adapted to avoid it. However, I'd be ok with logic to skip those tests if libdl isn't available, if you want to broaden support to older releases.

At the moment dtc seems to be just teetering on the edge of being complex enough to need some sort of configuration system (whether it be hand-rolled scripts, autoconf or whatever). So far I've been avoiding adding such a thing, because that introduces a bunch of problems of its own: hand rolled scripts are a pain to maintain, autoconf is ugly as sin, pretty much anything else is nonstandard and liable to introduce a bunch of extra dependencies. But, I might have to bite the bullet at some point.

Quoted 4 lines
Quoted 1 line

What about meson? All the cool kids are using it now.

Heh, hadn't heard of that one. Too busy maintaining vital infrastructure to follow what the cool kids are doing.

Wait, no, I went to a talk about that once, and it did look pretty nice. Never had time or headspace to really do anything with it, though. Plus it would introduce Python as a build dep. Not really a problem for dtc per se, but given that libfdt is supposed to be embeddable in weird limited firmware environments, I really want to keep the build deps to a minimum.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson