Skip to contentSkip to conversation

Remove the obsolete libibcm library

PATCH In review Leon Romanovsky 3 participants 8 messages Dec 25, 2017 – Jan 2, 2018 6 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove the obsolete libibcm library

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

The libibcm library was marked as obsolete long time ago, the following patch is first step before removing ucm from the kernel.

---
PR: https://github.com/linux-rdma/rdma-core/pull/279

---
 CMakeLists.txt                  |    2 -
 Documentation/CMakeLists.txt    |    1 -
 Documentation/libibcm.md        |   16 -
 MAINTAINERS                     |    6 -
 README.md                       |    1 -
 debian/control                  |   39 --
 debian/copyright                |    6 -
 debian/libibcm-dev.install      |    3 -
 debian/libibcm1.install         |    2 -
 debian/libibcm1.symbols         |   23 -
 debian/rules                    |    1 -
 libibcm/CMakeLists.txt          |   11 -
 libibcm/cm.c                    | 1025 ---------------------------------------
 libibcm/cm.h                    |  587 ----------------------
 libibcm/cm_abi.h                |   73 ---
 libibcm/examples/CMakeLists.txt |    2 -
 libibcm/examples/cmpost.c       |  774 -----------------------------
 libibcm/libibcm.map             |   26 -
 redhat/rdma-core.spec           |   20 -
 suse/rdma-core.spec             |   22 -
 20 files changed, 2640 deletions(-)
 delete mode 100644 Documentation/libibcm.md
 delete mode 100644 debian/libibcm-dev.install
 delete mode 100644 debian/libibcm1.install
 delete mode 100644 debian/libibcm1.symbols
 delete mode 100644 libibcm/CMakeLists.txt
 delete mode 100644 libibcm/cm.c
 delete mode 100644 libibcm/cm.h
 delete mode 100644 libibcm/cm_abi.h
 delete mode 100644 libibcm/examples/CMakeLists.txt
 delete mode 100644 libibcm/examples/cmpost.c
 delete mode 100644 libibcm/libibcm.map
CMakeLists.txt +0 -2
index b1467317..f11bcb73 100644
@@ -429,7 +429,6 @@ add_subdirectory(libibverbs)
 add_subdirectory(libibverbs/man)
 add_subdirectory(librdmacm)
 add_subdirectory(librdmacm/man)
-add_subdirectory(libibcm)
 
 # Providers
 if (HAVE_COHERENT_DMA)
@@ -459,7 +458,6 @@ add_subdirectory(ibacm) # NO SPARSE
 if (NOT NL_KIND EQUAL 0)
   add_subdirectory(iwpmd)
 endif()
-add_subdirectory(libibcm/examples)
 add_subdirectory(libibumad/tests)
 add_subdirectory(libibverbs/examples)
 add_subdirectory(librdmacm/examples)
Documentation/CMakeLists.txt +0 -1
index 4b9e07f2..bda16fa3 100644
@@ -1,7 +1,6 @@
 install(FILES
   ibacm.md
   ibsrpdm.md
-  libibcm.md
   libibverbs.md
   librdmacm.md
   rxe.md
Documentation/libibcm.md deleted +0 -16
deleted file mode 100644
index 663e7736..00000000
@@ -1,16 +0,0 @@
-# Device files
-
-The userspace CM uses a device file per adapter present.
-
-To create the appropriate character device file automatically with
-udev, a rule like
-
-    KERNEL="ucm*", NAME="infiniband/%k", MODE="0666"
-
-can be used.  This will create the device node named
-
-    /dev/infiniband/ucm0
-
-for the first HCA in the system, or you can create it manually
-
-  mknod /dev/infiniband/ucm0 c 231 224
MAINTAINERS +0 -6
index e6f13950..f64e13a0 100644
@@ -99,12 +99,6 @@ H:	Robert Sharp <[email protected]>
 S:	Supported
 F:	iwpmd/
 
-LIBIBCM USERSPACE LIBRARY FOR IB CONNECTION MANAGEMENT (/dev/infiniband/ucmX)
-M:	Sean Hefty <[email protected]>
-H:	Libor Michalek <[email protected]>
-S:	Obsolete
-F:	libibcm/
-
 LIBIBUMAD USERSPACE LIBRARY FOR SMP AND GMP MAD PROCESSING (/dev/infiniband/umadX)
 M:	Hal Rosenstock <[email protected]>
 H:	Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/[email protected]>
README.md +0 -1
index b7928ab5..4d7e949b 100644
@@ -9,7 +9,6 @@ following device nodes:
  - /dev/infiniband/uverbsX (libibverbs)
  - /dev/infiniband/rdma_cm (librdmacm)
  - /dev/infiniband/umadX (libibumad)
- - /dev/infiniband/ucmX (libibcm, deprecated)
 
 The userspace component of the libibverbs RDMA kernel drivers are included
 under the providers/ directory. Support for the following Kernel RDMA drivers
debian/control +0 -39
index 451b379f..ef7e3cc2 100644
@@ -172,45 +172,6 @@ Description: Debug symbols for the libibverbs library
  libibverbs1. They will automatically be used by gdb for debugging
  libibverbs-related issues.
 
-Package: libibcm-dev
-Section: libdevel
-Architecture: linux-any
-Multi-Arch: same
-Depends: libibcm1 (= ${binary:Version}), libibverbs-dev, ${misc:Depends}
-Description: Development files for the libibcm library
- libibcm provides a userspace implementation of an InfiniBand
- Communication Manager (CM). The CM handles both connection
- establishment as well as service ID resolution.
- .
- This package is needed to compile programs against libibcm1.
- It contains the header files and static libraries (optionally)
- needed for compiling.
-
-Package: libibcm1
-Architecture: linux-any
-Multi-Arch: same
-Section: libs
-Depends: ${misc:Depends}, ${shlibs:Depends}
-Description: InfiniBand Communication Manager (CM) library
- libibcm provides a userspace implementation of an InfiniBand
- Communication Manager (CM). The CM handles both connection
- establishment as well as service ID resolution.
- .
- This package contains the shared library.
-
-Package: libibcm1-dbg
-Section: debug
-Architecture: linux-any
-Depends: libibcm1 (= ${binary:Version}), ${misc:Depends}
-Description: Debug symbols for the libibcm1 library
- libibcm provides a userspace implementation of an InfiniBand
- Communication Manager (CM). The CM handles both connection
- establishment as well as service ID resolution.
- .
- This package contains the debug symbols associated with
- libibcm1. They will automatically be used by gdb for debugging
- libibcm-related issues.
-
 Package: libibumad-dev
 Section: libdevel
 Architecture: linux-any
debian/copyright +0 -6
index 5546882b..dccd34a0 100644
@@ -77,12 +77,6 @@ Files: iwpmd/*
 Copyright: 2013-2016, Intel Corporation.
 License: BSD-MIT or GPL-2
 
-Files: libibcm/*
-Copyright: 2004-2006, Intel Corporation.
-           2004-2005, Topspin Communications.
-           2004, Voltaire Corporation.
-License: BSD-MIT or GPL-2
-
 Files: libibumad/*
 Copyright: 2004-2017, Mellanox Technologies Ltd.
            2004, Infinicon Corporation.
debian/libibcm-dev.install deleted +0 -3
deleted file mode 100644
index 36e1e5fe..00000000
@@ -1,3 +0,0 @@
-usr/include/infiniband/cm.h
-usr/include/infiniband/cm_abi.h
-usr/lib/*/libibcm*.so
debian/libibcm1.install deleted +0 -2
deleted file mode 100644
index a0ace6eb..00000000
@@ -1,2 +0,0 @@
-usr/lib/*/libibcm*.so.*
-usr/share/doc/rdma-core/libibcm.md usr/share/doc/libibcm1/
debian/libibcm1.symbols deleted +0 -23
deleted file mode 100644
index a7b0ef43..00000000
@@ -1,23 +0,0 @@
-libibcm.so.1 libibcm1 #MINVER#
- IBCM_1.0@IBCM_1.0 12
- ib_cm_ack_event@IBCM_1.0 12
- ib_cm_attr_id@IBCM_1.0 12
- ib_cm_close_device@IBCM_1.0 12
- ib_cm_create_id@IBCM_1.0 12
- ib_cm_destroy_id@IBCM_1.0 12
- ib_cm_get_event@IBCM_1.0 12
- ib_cm_init_qp_attr@IBCM_1.0 12
- ib_cm_listen@IBCM_1.0 12
- ib_cm_notify@IBCM_1.0 12
- ib_cm_open_device@IBCM_1.0 12
- ib_cm_send_apr@IBCM_1.0 12
- ib_cm_send_drep@IBCM_1.0 12
- ib_cm_send_dreq@IBCM_1.0 12
- ib_cm_send_lap@IBCM_1.0 12
- ib_cm_send_mra@IBCM_1.0 12
- ib_cm_send_rej@IBCM_1.0 12
- ib_cm_send_rep@IBCM_1.0 12
- ib_cm_send_req@IBCM_1.0 12
- ib_cm_send_rtu@IBCM_1.0 12
- ib_cm_send_sidr_rep@IBCM_1.0 12
- ib_cm_send_sidr_req@IBCM_1.0 12
debian/rules +0 -1
index be1781ad..87d02104 100755
@@ -74,7 +74,6 @@ override_dh_makeshlibs:
 	dh_makeshlibs $(SHLIBS_EXCLUDE)
 
 override_dh_strip:
-	dh_strip -plibibcm1 --dbg-package=libibcm1-dbg
 	dh_strip -plibibumad3 --dbg-package=libibumad3-dbg
 	dh_strip -plibibverbs1 --dbg-package=libibverbs1-dbg
 	dh_strip -plibrdmacm1 --dbg-package=librdmacm1-dbg
libibcm/CMakeLists.txt deleted +0 -11
deleted file mode 100644
index 7087859e..00000000
@@ -1,11 +0,0 @@
-publish_headers(infiniband
-  cm.h
-  cm_abi.h
-  )
-
-rdma_library(ibcm libibcm.map
-  # See Documentation/versioning.md
-  1 1.0.${PACKAGE_VERSION}
-  cm.c
-  )
-target_link_libraries(ibcm LINK_PUBLIC ibverbs)
libibcm/cm.c deleted +0 -1025

1,025 lines not on this page · raw message

libibcm/cm.h deleted +0 -587

587 lines not on this page · raw message

libibcm/cm_abi.h deleted +0 -73

73 lines not on this page · raw message

libibcm/examples/CMakeLists.txt deleted +0 -2
deleted file mode 100644
index ef30a6e1..00000000
@@ -1,2 +0,0 @@
-rdma_test_executable(cmpost cmpost.c)
-target_link_libraries(cmpost LINK_PRIVATE ibcm rdmacm)
libibcm/examples/cmpost.c deleted +0 -774

774 lines not on this page · raw message

libibcm/libibcm.map deleted +0 -26
deleted file mode 100644
index c94e420a..00000000
@@ -1,26 +0,0 @@
-/* Do not change this file without reading Documentation/versioning.md */
-IBCM_1.0 {
-	global:
-		ib_cm_open_device;
-		ib_cm_close_device;
-		ib_cm_get_event;
-		ib_cm_ack_event;
-		ib_cm_create_id;
-		ib_cm_destroy_id;
-		ib_cm_attr_id;
-		ib_cm_listen;
-		ib_cm_send_req;
-		ib_cm_send_rep;
-		ib_cm_send_rtu;
-		ib_cm_send_dreq;
-		ib_cm_send_drep;
-		ib_cm_notify;
-		ib_cm_send_rej;
-		ib_cm_send_mra;
-		ib_cm_send_lap;
-		ib_cm_send_apr;
-		ib_cm_send_sidr_req;
-		ib_cm_send_sidr_rep;
-		ib_cm_init_qp_attr;
-	local: *;
-};
redhat/rdma-core.spec +0 -20
index 4fc2e289..434d5679 100644
@@ -56,9 +56,6 @@ Requires: %{name}%{?_isa} = %{version}-%{release}
 Requires: libibverbs = %{version}-%{release}
 Provides: libibverbs-devel = %{version}-%{release}
 Obsoletes: libibverbs-devel < %{version}-%{release}
-Requires: libibcm = %{version}-%{release}
-Provides: libibcm-devel = %{version}-%{release}
-Obsoletes: libibcm-devel < %{version}-%{release}
 Requires: libibumad = %{version}-%{release}
 Provides: libibumad-devel = %{version}-%{release}
 Obsoletes: libibumad-devel < %{version}-%{release}
@@ -160,15 +157,6 @@ Requires: %{name}%{?_isa} = %{version}-%{release}
 iwpmd provides a userspace service for iWarp drivers to claim
 tcp ports through the standard socket interface.
 
-%package -n libibcm
-Summary: Userspace InfiniBand Connection Manager
-ExcludeArch: s390 s390x
-Requires: %{name}%{?_isa} = %{version}-%{release}
-
-%description -n libibcm
-libibcm provides a userspace library that handles the majority of the low
-level work required to open an RDMA connection between two machines.
-
 %package -n libibumad
 Summary: OpenFabrics Alliance InfiniBand umad (userspace management datagram) library
 Requires: %{name}%{?_isa} = %{version}-%{release}
@@ -276,10 +264,6 @@ rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
 %post -n libibverbs -p /sbin/ldconfig
 %postun -n libibverbs -p /sbin/ldconfig
 
-# libibcm
-%post -n libibcm -p /sbin/ldconfig
-%postun -n libibcm -p /sbin/ldconfig
-
 # libibumad
 %post -n libibumad -p /sbin/ldconfig
 %postun -n libibumad -p /sbin/ldconfig
@@ -409,10 +393,6 @@ rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
 %{_mandir}/man8/iwpmd.*
 %{_mandir}/man5/iwpmd.*
 
-%files -n libibcm
-%{_libdir}/libibcm*.so.*
-%doc %{_docdir}/%{name}-%{version}/libibcm.md
-
 %files -n libibumad
 %{_libdir}/libibumad*.so.*
 
suse/rdma-core.spec +0 -22
index df1c571c..cb6ffb36 100644
@@ -26,14 +26,12 @@ License:        GPL-2.0 or BSD-2-Clause
 Group:          Productivity/Networking/Other
 
 %define verbs_so_major  1
-%define ibcm_so_major   1
 %define rdmacm_so_major 1
 %define umad_so_major   3
 %define mlx4_so_major   1
 %define mlx5_so_major   1
 
 %define  verbs_lname  libibverbs%{verbs_so_major}
-%define  ibcm_lname   libibcm%{ibcm_so_major}
 %define  rdmacm_lname librdmacm%{rdmacm_so_major}
 %define  umad_lname   libibumad%{umad_so_major}
 %define  mlx4_lname   libmlx4-%{mlx4_so_major}
@@ -123,7 +121,6 @@ Summary:        RDMA core development libraries and headers
 Group:          Development/Libraries/C and C++
 Requires:       %{name}%{?_isa} = %{version}-%{release}
 
-Requires:       %{ibcm_lname} = %{version}-%{release}
 Requires:       %{rdmacm_lname} = %{version}-%{release}
 Requires:       %{umad_lname} = %{version}-%{release}
 Requires:       %{verbs_lname} = %{version}-%{release}
@@ -136,9 +133,6 @@ Requires:       rsocket = %{version}-%{release}
 Provides:       libibverbs-devel = %{version}-%{release}
 Obsoletes:      libibverbs-devel < %{version}-%{release}
 
-Provides:       libibcm-devel = %{version}-%{release}
-Obsoletes:      libibcm-devel < %{version}-%{release}
-
 Provides:       libibumad-devel = %{version}-%{release}
 Obsoletes:      libibumad-devel < %{version}-%{release}
 Provides:       librdmacm-devel = %{version}-%{release}
@@ -256,14 +250,6 @@ Requires:       %{name}%{?_isa} = %{version}
 iwpmd provides a userspace service for iWarp drivers to claim
 tcp ports through the standard socket interface.
 
-%package -n %ibcm_lname
-Summary:        Userspace InfiniBand Connection Manager
-Group:          System/Libraries
-
-%description -n %ibcm_lname
-libibcm provides a userspace library that handles the majority of the low
-level work required to open an RDMA connection between two machines.
-
 %package -n %umad_lname
 Summary:        OpenFabrics Alliance InfiniBand Userspace Management Datagram library
 Group:          System/Libraries
@@ -408,9 +394,6 @@ rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
 %postun -n %mlx5_lname -p /sbin/ldconfig
 %endif
 
-%post -n %ibcm_lname -p /sbin/ldconfig
-%postun -n %ibcm_lname -p /sbin/ldconfig
-
 %post -n %umad_lname -p /sbin/ldconfig
 %postun -n %umad_lname -p /sbin/ldconfig
 
@@ -610,11 +593,6 @@ rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
 %{_mandir}/man8/iwpmd.*
 %{_mandir}/man5/iwpmd.*
 
-%files -n %ibcm_lname
-%defattr(-,root,root)
-%{_libdir}/libibcm*.so.*
-%doc %{_docdir}/%{name}-%{version}/libibcm.md
-
 %files -n %umad_lname
 %defattr(-,root,root)
 %{_libdir}/libibumad*.so.*

--
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20171225123132.6063-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

#2 lore raw
Quoted 5 lines · Leon Romanovsky

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

The libibcm library was marked as obsolete long time ago, the following patch is first step before removing ucm from the kernel.

I understand the distros will not want to loose libibcm in their stable releases.

It might make more sense instead to just not build libibcm by default with a cmake option but still keep the sources..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20171227201945.GG25436-uk2M96/[email protected]

#4 lore raw
Quoted 7 lines · Jason Gunthorpe
Quoted 5 lines · Leon Romanovsky

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

The libibcm library was marked as obsolete long time ago, the following patch is first step before removing ucm from the kernel.

Quoted 5 lines

I understand the distros will not want to loose libibcm in their stable releases.

It might make more sense instead to just not build libibcm by default with a cmake option but still keep the sources..

We are not removing it from the stable branches, so if they want to keep it till last person who used this library dies, they are free to do it.

The disabled build doesn't give much benefit at all. It will be dead code exactly as now, but without any alert that it is broken. Most possible, it will be broken till some distro will notice it.

Exactly as some distros have EOL, this libibcm library came to its EOL.

Thanks

Quoted 2 lines

Jason

A message that is not in the archive (sent off-list or not yet received): 20171228053029.GO3494-U/[email protected]

#6 lore raw
Quoted 14 lines · Leon Romanovsky
Quoted 7 lines · Jason Gunthorpe
Quoted 5 lines · Leon Romanovsky

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

The libibcm library was marked as obsolete long time ago, the following patch is first step before removing ucm from the kernel.

Quoted 5 lines

I understand the distros will not want to loose libibcm in their stable releases.

It might make more sense instead to just not build libibcm by default with a cmake option but still keep the sources..

Quoted 6 lines

We are not removing it from the stable branches, so if they want to keep it till last person who used this library dies, they are free to do it.

The disabled build doesn't give much benefit at all. It will be dead code exactly as now, but without any alert that it is broken. Most possible, it will be broken till some distro will notice it.

Since when has it been brken and how is it broken ? Last I knew it worked but was not used by anything in tree.

-- Hal

Quoted 6 lines

Exactly as some distros have EOL, this libibcm library came to its EOL.

Thanks

Quoted 2 lines

Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): ea55cca5-1bf9-dd54-9be1-6450ca9002ef-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#8 lore raw
Quoted 18 lines · Hal Rosenstock
Quoted 17 lines · Leon Romanovsky
Quoted 7 lines · Jason Gunthorpe
Quoted 5 lines · Leon Romanovsky

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

The libibcm library was marked as obsolete long time ago, the following patch is first step before removing ucm from the kernel.

Quoted 5 lines

I understand the distros will not want to loose libibcm in their stable releases.

It might make more sense instead to just not build libibcm by default with a cmake option but still keep the sources..

We are not removing it from the stable branches, so if they want to keep it till last person who used this library dies, they are free to do it.

Quoted 6 lines
Quoted 3 lines

The disabled build doesn't give much benefit at all. It will be dead code exactly as now, but without any alert that it is broken. Most possible, it will be broken till some distro will notice it.

Since when has it been brken and how is it broken ? Last I knew it worked but was not used by anything in tree.

Hal,

Where did you see me saying that it is broken?

I said that it WILL be broken if we don't compile it by default.

Thanks

Quoted 9 lines

-- Hal

Quoted 6 lines

Exactly as some distros have EOL, this libibcm library came to its EOL.

Thanks

Quoted 2 lines

Jason

A message that is not in the archive (sent off-list or not yet received): 20180102142658.GF10145-U/[email protected]

#10 lore raw
Quoted 23 lines · Leon Romanovsky
Quoted 22 lines · Hal Rosenstock
Quoted 20 lines · Leon Romanovsky
Quoted 7 lines · Jason Gunthorpe
Quoted 5 lines · Leon Romanovsky

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

The libibcm library was marked as obsolete long time ago, the following patch is first step before removing ucm from the kernel.

Quoted 5 lines

I understand the distros will not want to loose libibcm in their stable releases.

It might make more sense instead to just not build libibcm by default with a cmake option but still keep the sources..

We are not removing it from the stable branches, so if they want to keep it till last person who used this library dies, they are free to do it.

The disabled build doesn't give much benefit at all. It will be dead code exactly as now, but without any alert that it is broken. Most possible, it will be broken till some distro will notice it.

Quoted 8 lines
Quoted 2 lines

Since when has it been broken and how is it broken ? Last I knew it worked but was not used by anything in tree.

Hal,

Where did you see me saying that it is broken?

I said that it WILL be broken if we don't compile it by default.

OK but that's not how I interpreted what you wrote:
"It will be dead code exactly as now, but without any alert that it is broken."

Anyhow, if distro still wants to include this, wouldn't they build and test it ?

-- Hal

Quoted 11 lines

Thanks

Quoted 9 lines

-- Hal

Quoted 6 lines

Exactly as some distros have EOL, this libibcm library came to its EOL.

Thanks

Quoted 2 lines

Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 3146d449-0d75-9954-8c0b-bb122aaaa102-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#12 lore raw
Quoted 31 lines · Hal Rosenstock
Quoted 30 lines · Leon Romanovsky
Quoted 18 lines · Hal Rosenstock
Quoted 17 lines · Leon Romanovsky
Quoted 7 lines · Jason Gunthorpe
Quoted 5 lines · Leon Romanovsky

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

The libibcm library was marked as obsolete long time ago, the following patch is first step before removing ucm from the kernel.

Quoted 5 lines

I understand the distros will not want to loose libibcm in their stable releases.

It might make more sense instead to just not build libibcm by default with a cmake option but still keep the sources..

We are not removing it from the stable branches, so if they want to keep it till last person who used this library dies, they are free to do it.

Quoted 6 lines
Quoted 3 lines

The disabled build doesn't give much benefit at all. It will be dead code exactly as now, but without any alert that it is broken. Most possible, it will be broken till some distro will notice it.

Since when has it been broken and how is it broken ? Last I knew it worked but was not used by anything in tree.

Hal,

Where did you see me saying that it is broken?

Quoted 8 lines
Quoted 1 line

I said that it WILL be broken if we don't compile it by default.

OK but that's not how I interpreted what you wrote:
"It will be dead code exactly as now, but without any alert that it is broken."

Anyhow, if distro still wants to include this, wouldn't they build and test it ?

It depends on them, not all distribution are going to support it. I see no difference between this library (libibcm) and any other abandoned library.

Thanks

Quoted 14 lines

-- Hal

Quoted 11 lines

Thanks

Quoted 9 lines

-- Hal

Quoted 6 lines

Exactly as some distros have EOL, this libibcm library came to its EOL.

Thanks

Quoted 2 lines

Jason

#13 lore raw
In reply to a message not in the archive
Quoted 6 lines · Hal Rosenstock
Quoted 3 lines

The disabled build doesn't give much benefit at all. It will be dead code exactly as now, but without any alert that it is broken. Most possible, it will be broken till some distro will notice it.

Since when has it been brken and how is it broken ? Last I knew it worked but was not used by anything in tree.

Last time I used it I remember thinking it had an unfixable race of some sort.. Long time ago

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html