Skip to contentSkip to conversation

nilfs-utils: needs threads support

PATCH New Baruch Siach 3 participants 3 messages Jan 2, 2018 – Jan 3, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nilfs-utils: needs threads support

nilfs-utils uses the sem_* family of functions from the realtime extension. Technically this is not part of pthreads. But in uClibc enabling threads enables also UCLIBC_HAS_REALTIME.

Fixes:
http://autobuild.buildroot.net/results/c5d/c5d93b6ab5b260fe5db46298b956a9ae765c828a/
http://autobuild.buildroot.net/results/9d6/9d6a248f9acbb58b6c2893de58978c6013332415/

Cc Kurt Van Dijck <[email protected]>
---
 package/nilfs-utils/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/nilfs-utils/Config.in +4 -0
index 2763af54fd24..0c6b7a0ce861 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_NILFS_UTILS
 	bool "nilfs-utils"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
 	depends on BR2_USE_MMU # util-linux libmount, libblkid
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
@@ -9,3 +10,6 @@ config BR2_PACKAGE_NILFS_UTILS
 	  Tools for creating and managing NILFS2 filesystems.
 
 	  https://github.com/nilfs-dev/nilfs-utils
+
+comment "nilfs-utils needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/1 nilfs-utils: needs threads support

Hello,

Quoted 8 lines · Baruch Siach

nilfs-utils uses the sem_* family of functions from the realtime extension. Technically this is not part of pthreads. But in uClibc enabling threads enables also UCLIBC_HAS_REALTIME.

Fixes:
http://autobuild.buildroot.net/results/c5d/c5d93b6ab5b260fe5db46298b956a9ae765c828a/
http://autobuild.buildroot.net/results/9d6/9d6a248f9acbb58b6c2893de58978c6013332415/

Quoted 5 lines
Cc Kurt Van Dijck <[email protected]>
---
 package/nilfs-utils/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 nilfs-utils: needs threads support

In reply to Baruch Siach
Quoted 3 lines

nilfs-utils uses the sem_* family of functions from the realtime extension. Technically this is not part of pthreads. But in uClibc enabling threads enables also UCLIBC_HAS_REALTIME.

I got to testing nilfs-utils on different compilers, and got a similar
conclusion: uclibc without threads has no semaphores.

you can add:

Quoted 32 lines

Fixes:
http://autobuild.buildroot.net/results/c5d/c5d93b6ab5b260fe5db46298b956a9ae765c828a/
http://autobuild.buildroot.net/results/9d6/9d6a248f9acbb58b6c2893de58978c6013332415/

Cc Kurt Van Dijck <[email protected]>
---
 package/nilfs-utils/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/nilfs-utils/Config.in +4 -0
index 2763af54fd24..0c6b7a0ce861 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_NILFS_UTILS
 	bool "nilfs-utils"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
 	depends on BR2_USE_MMU # util-linux libmount, libblkid
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
@@ -9,3 +10,6 @@ config BR2_PACKAGE_NILFS_UTILS
 	  Tools for creating and managing NILFS2 filesystems.
 
 	  https://github.com/nilfs-dev/nilfs-utils
+
+comment "nilfs-utils needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.15.1