Skip to contentSkip to conversation

xfs/015: enlarge the initial fs size

PATCH In review Eryu Guan 2 participants 5 messages Jan 4, 2018 – Feb 15, 2018

lore
Share & tools
lore

Eryu Guan

author
#0 lore raw

PATCH 1/1 xfs/015: enlarge the initial fs size

Kernel commit f59cf5c29919 ("xfs: remove "no-allocation" reservations for file creations") is known to cause earlier ENOSPC conditions, and xfs/015 is affected in the way that no new file/dir can be created in a newly created 16M XFS with both reflink and rmapbt enabled, thus xfs/015 fails due to the missing test dirs.

So enlarge the initial fs size to 32M that we're able to create new dir/file before growing the filesystem size.

---
 tests/xfs/015 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/xfs/015 +3 -3
index 2c57f7882308..4939bb92f6fc 100755
@@ -66,15 +66,15 @@ _supported_os Linux
 
 _require_scratch
 
-# need 64M space, don't make any assumption
+# need 128M space, don't make any assumption
 _scratch_mkfs >/dev/null 2>&1
 _scratch_mount
-_require_fs_space $SCRATCH_MNT 65536
+_require_fs_space $SCRATCH_MNT 131072
 _scratch_unmount
 
 rm -f $seqres.full
 
-_scratch_mkfs_sized $((16 * 1024 * 1024)) > $tmp.mkfs.raw
+_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw
 cat $tmp.mkfs.raw | _filter_mkfs >$seqres.full 2>$tmp.mkfs
 # get original data blocks number and agcount
 . $tmp.mkfs
Signature · 1 line
2.14.3
author
#1 lore raw
Quoted 10 lines · Eryu Guan

Kernel commit f59cf5c29919 ("xfs: remove "no-allocation" reservations for file creations") is known to cause earlier ENOSPC conditions, and xfs/015 is affected in the way that no new file/dir can be created in a newly created 16M XFS with both reflink and rmapbt enabled, thus xfs/015 fails due to the missing test dirs.

So enlarge the initial fs size to 32M that we're able to create new dir/file before growing the filesystem size.

ping on this patch.

Eryu

Quoted 30 lines
---
 tests/xfs/015 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/xfs/015 +3 -3
index 2c57f7882308..4939bb92f6fc 100755
@@ -66,15 +66,15 @@ _supported_os Linux
 
 _require_scratch
 
-# need 64M space, don't make any assumption
+# need 128M space, don't make any assumption
 _scratch_mkfs >/dev/null 2>&1
 _scratch_mount
-_require_fs_space $SCRATCH_MNT 65536
+_require_fs_space $SCRATCH_MNT 131072
 _scratch_unmount
 
 rm -f $seqres.full
 
-_scratch_mkfs_sized $((16 * 1024 * 1024)) > $tmp.mkfs.raw
+_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw
 cat $tmp.mkfs.raw | _filter_mkfs >$seqres.full 2>$tmp.mkfs
 # get original data blocks number and agcount
 . $tmp.mkfs
Signature · 1 line
2.14.3
#2 lore raw
Quoted 8 lines · Eryu Guan
Quoted 7 lines · Eryu Guan

Kernel commit f59cf5c29919 ("xfs: remove "no-allocation" reservations for file creations") is known to cause earlier ENOSPC conditions, and xfs/015 is affected in the way that no new file/dir can be created in a newly created 16M XFS with both reflink and rmapbt enabled, thus xfs/015 fails due to the missing test dirs.

So enlarge the initial fs size to 32M that we're able to create new

32M? I thought this was a 64M -> 128M expansion?

Quoted 3 lines
Quoted 3 lines

dir/file before growing the filesystem size.

I don't think this hurts anything, but otoh I couldn't reproduce the failure you're seeing on my setup.

--D

Quoted 39 lines

ping on this patch.

Eryu

Quoted 30 lines
---
 tests/xfs/015 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/xfs/015 +3 -3
index 2c57f7882308..4939bb92f6fc 100755
@@ -66,15 +66,15 @@ _supported_os Linux
 
 _require_scratch
 
-# need 64M space, don't make any assumption
+# need 128M space, don't make any assumption
 _scratch_mkfs >/dev/null 2>&1
 _scratch_mount
-_require_fs_space $SCRATCH_MNT 65536
+_require_fs_space $SCRATCH_MNT 131072
 _scratch_unmount
 
 rm -f $seqres.full
 
-_scratch_mkfs_sized $((16 * 1024 * 1024)) > $tmp.mkfs.raw
+_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw
 cat $tmp.mkfs.raw | _filter_mkfs >$seqres.full 2>$tmp.mkfs
 # get original data blocks number and agcount
 . $tmp.mkfs
Signature · 1 line
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#3 lore raw
Quoted 11 lines · Darrick J. Wong
Quoted 8 lines · Eryu Guan
Quoted 7 lines · Eryu Guan

Kernel commit f59cf5c29919 ("xfs: remove "no-allocation" reservations for file creations") is known to cause earlier ENOSPC conditions, and xfs/015 is affected in the way that no new file/dir can be created in a newly created 16M XFS with both reflink and rmapbt enabled, thus xfs/015 fails due to the missing test dirs.

So enlarge the initial fs size to 32M that we're able to create new

32M? I thought this was a 64M -> 128M expansion?

The final fs size (after growfs) is expanded from 64M to 128M, but we need the initial fs size (prior to growfs) to be 32M instead of 16M.

Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

dir/file before growing the filesystem size.

I don't think this hurts anything, but otoh I couldn't reproduce the failure you're seeing on my setup.

You need "both reflink and rmapbt enabled", I can still reproduce it with v4.16-rc1 kernel with MKFS_OPTIONS="-m reflink=1,rmapbt=1".

Thanks for reviewing!

Eryu

Quoted 42 lines

--D

Quoted 39 lines

ping on this patch.

Eryu

Quoted 30 lines
---
 tests/xfs/015 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/xfs/015 +3 -3
index 2c57f7882308..4939bb92f6fc 100755
@@ -66,15 +66,15 @@ _supported_os Linux
 
 _require_scratch
 
-# need 64M space, don't make any assumption
+# need 128M space, don't make any assumption
 _scratch_mkfs >/dev/null 2>&1
 _scratch_mount
-_require_fs_space $SCRATCH_MNT 65536
+_require_fs_space $SCRATCH_MNT 131072
 _scratch_unmount
 
 rm -f $seqres.full
 
-_scratch_mkfs_sized $((16 * 1024 * 1024)) > $tmp.mkfs.raw
+_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw
 cat $tmp.mkfs.raw | _filter_mkfs >$seqres.full 2>$tmp.mkfs
 # get original data blocks number and agcount
 . $tmp.mkfs
Signature · 1 line
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Reviewed-by
#4 lore raw
Quoted 9 lines · Eryu Guan
Quoted 8 lines · Darrick J. Wong
Quoted 7 lines · Eryu Guan
Quoted 6 lines · Eryu Guan

Kernel commit f59cf5c29919 ("xfs: remove "no-allocation" reservations for file creations") is known to cause earlier ENOSPC conditions, and xfs/015 is affected in the way that no new file/dir can be created in a newly created 16M XFS with both reflink and rmapbt enabled, thus xfs/015 fails due to the missing test dirs.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line

So enlarge the initial fs size to 32M that we're able to create new

32M? I thought this was a 64M -> 128M expansion?

The final fs size (after growfs) is expanded from 64M to 128M, but we need the initial fs size (prior to growfs) to be 32M instead of 16M.

Ahh, ok. The initial size is doubled (and the test still grows the fs 4x), so we need to double the _require_space.

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines

dir/file before growing the filesystem size.

Quoted 7 lines
Quoted 2 lines

I don't think this hurts anything, but otoh I couldn't reproduce the failure you're seeing on my setup.

You need "both reflink and rmapbt enabled", I can still reproduce it with v4.16-rc1 kernel with MKFS_OPTIONS="-m reflink=1,rmapbt=1".

Thanks for reviewing!

Looks ok,

--D