Skip to contentSkip to conversation

mfd: lpc_ich: Do not touch SPI-NOR write protection bit on Apollo Lake

PATCH Applied Mika Westerberg 2 participants 2 messages Jan 4, 2018 – Jan 8, 2018

Subsystems (2)
Multifunction devices (MFD) Ich lpc and GPIO driver
lore
Share & tools
lore

Mika Westerberg

author
#0 lore raw

PATCH 1/1 mfd: lpc_ich: Do not touch SPI-NOR write protection bit on Apollo Lake

Just to be on the safe side, don't touch the bit. If write access to the flash chip is needed, the BIOS needs to enable it explicitly.

Signed-off-by Mika Westerberg <[email protected]>
---
 drivers/mfd/lpc_ich.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/mfd/lpc_ich.c +0 -5
index cf1120abbf52..53dc1a43472c 100644
@@ -1143,11 +1143,6 @@ static int lpc_ich_init_spi(struct pci_dev *dev)
 			res->end = res->start + SPIBASE_APL_SZ - 1;
 
 			pci_bus_read_config_dword(bus, spi, BCR, &bcr);
-			if (!(bcr & BCR_WPD)) {
-				bcr |= BCR_WPD;
-				pci_bus_write_config_dword(bus, spi, BCR, bcr);
-				pci_bus_read_config_dword(bus, spi, BCR, &bcr);
-			}
 			info->writeable = !!(bcr & BCR_WPD);
 		}
Signature · 1 line
2.15.1
Applied
#1 lore raw
Quoted 7 lines · Mika Westerberg

Just to be on the safe side, don't touch the bit. If write access to the flash chip is needed, the BIOS needs to enable it explicitly.

Signed-off-by Mika Westerberg <[email protected]>
---
 drivers/mfd/lpc_ich.c | 5 -----
 1 file changed, 5 deletions(-)

Applied, thanks.

Signature · 4 lines
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog