nvme: Modify the debug level for setting shutdown timeout
PATCH 1/1 nvme: Modify the debug level for setting shutdown timeout
When an NVMe controller reports RTD3 Entry Latency larger than the value of shutdown_timeout module parameter, we update the shutdown_timeout accordingly to honor RTD3 Entry Latency. Use an Informational debug level instead of a Warning level for it.
--- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
@@ -2253,7 +2253,7 @@ int nvme_init_identify(struct nvme_ctrl *ctrl) shutdown_timeout, 60);if (ctrl->shutdown_timeout != shutdown_timeout) -dev_warn (ctrl->device, +dev_info (ctrl->device,"Shutdown timeout set to %u seconds\n" , ctrl->shutdown_timeout); }else
Signature · 1 line
1.8.3.1
Christoph Hellwig
maintainerPATCH 1/1 nvme: Modify the debug level for setting shutdown timeout
Quoted 6 lines · Max Gurtovoy
When an NVMe controller reports RTD3 Entry Latency larger than the value of
shutdown_timeoutmodule parameter, we update theshutdown_timeoutaccordingly to honor RTD3 Entry Latency. Use an Informational debug level instead of a Warning level for it.Signed-off-by Max Gurtovoy <maxg at mellanox.com>
I'm ok with just info, but in the end it seems like a pretty buggy device..
PATCH 1/1 nvme: Modify the debug level for setting shutdown timeout
Quoted 11 lines · Christoph Hellwig
Quoted 6 lines · Max Gurtovoy
When an NVMe controller reports RTD3 Entry Latency larger than the value of
shutdown_timeoutmodule parameter, we update theshutdown_timeoutaccordingly to honor RTD3 Entry Latency. Use an Informational debug level instead of a Warning level for it.Signed-off-by Max Gurtovoy <maxg at mellanox.com>I'm ok with just info, but in the end it seems like a pretty buggy device..
but shutdown_timeout is a module param that one can set to be 10 secs (for example) and then it might be == transition_time and we won't see the print. Then is it not a buggy device anymore ? :)
PATCH 1/1 nvme: Modify the debug level for setting shutdown timeout
Max,
Quoted 3 lines
but
shutdown_timeoutis a module param that one can set to be 10 secs (for example) and then it might be ==transition_timeand we won't see the print. Then is it not a buggy device anymore ? :)
The intent was to only print when the resulting shutdown_timeout deviated from the default value (whether the driver default or the admin-provided module parameter).
My only concern with info over warning is that info is often dropped. And therefore you have a harder time finding out which value was in effect when you subsequently peak at the logs.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
PATCH 1/1 nvme: Modify the debug level for setting shutdown timeout
Hi Martin,
Quoted 7 lines · Martin K. Petersen
Max,
Quoted 3 lines
but
shutdown_timeoutis a module param that one can set to be 10 secs (for example) and then it might be ==transition_timeand we won't see the print. Then is it not a buggy device anymore ? :)
Quoted 8 lines
The intent was to only print when the resulting
shutdown_timeoutdeviated from the default value (whether the driver default or the admin-provided module parameter).My only concern with info over warning is that info is often dropped. And therefore you have a harder time finding out which value was in effect when you subsequently peak at the logs.
Ok, it just bothered me to see this print every time I probed the device. But I can live with that. You can ignore this patch.
-Max.