netfilter: nf_nat_snmp_basic: use nf_ct_helper_log
Subsystems (2)
PATCH v5 4/5 netfilter: nf_nat_snmp_basic: use nf_ct_helper_log
Use nf_ct_helper_log to write log message.
Signed-off-by Taehee Yoo <[email protected]>
---
V5 :
- fix sparse error
V4 :
- rename nf_nat_snmp_basic.c to nf_nat_snmp_basic_main.c to fix compile error
V3 :
- be separated by previous patch.
V2 :
- Add missing nf_nat_snmp_basic.asn1 file
V1 :
- Initial patch
net/ipv4/netfilter/nf_nat_snmp_basic.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
net/ipv4/netfilter/nf_nat_snmp_basic.c +6 -5
@@ -1109,7 +1109,7 @@ static int snmp_translate(struct nf_conn *ct, int dir, struct sk_buff *skb)if (!snmp_parse_mangle ((unsigned char *)udph +sizeof (struct udphdr ), paylen, &map, &udph->check)) { -net_warn_ratelimited ("bsalg: parser failed\n" ); +nf_ct_helper_log (skb, ct,"parser failed\n" );return NF_DROP ; }return NF_ACCEPT ;
@@ -1143,13 +1143,14 @@ static int help(struct sk_buff *skb, unsigned int protoff,* can mess around with the payload. */ if (ntohs (udph->len) != skb->len - (iph->ihl <<2 )) { -net_warn_ratelimited ("SNMP: dropping malformed packet src=%pI4 dst=%pI4\n" , - &iph->saddr, &iph->daddr); -return NF_DROP ; +nf_ct_helper_log (skb, ct,"dropping malformed packet\n" ); +return NF_DROP ; } -if (!skb_make_writable (skb, skb->len)) +if (!skb_make_writable (skb, skb->len)) { +nf_ct_helper_log (skb, ct,"cannot mangle packet" );return NF_DROP ; + }spin_lock_bh (&snmp_lock); ret =snmp_translate (ct, dir, skb);
Signature · 1 line
2.9.3