Skip to contentSkip to conversation

package/libdrm: PKG_CHECK_MODULES should not fail when libatomic_ops is missing

PATCH New Bernd Kuhls 2 participants 2 messages Jan 7, 2018

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/libdrm: PKG_CHECK_MODULES should not fail when libatomic_ops is missing

According to https://autotools.io/pkgconfig/pkg_check_modules.html
"In contrast with almost all of the original macros, though, the default
action-if-not-found will end the execution with an error for not having found the dependency."

Fixes
http://autobuild.buildroot.net/results/cea/cea777dc997f86c1122c8b818d264215a0e77e5a/

Signed-off-by Bernd Kuhls <[email protected]>
---
 .../0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch   | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch +3 -1
index 20bb0a36d3..0fbe77ef7c 100644
@@ -23,6 +23,8 @@ and we don't link against it.
 
 Signed-off-by: Thomas Petazzoni <[email protected]>
 Signed-off-by: Peter Seiderer <[email protected]>
+[Bernd: PKG_CHECK_MODULES should not fail when libatomic_ops is missing]
+Signed-off-by: Bernd Kuhls <[email protected]>
 ---
  amdgpu/Makefile.am    | 2 +-
  configure.ac          | 2 +-

@@ -57,7 +59,7 @@ index 35378b33..501d0871 100644
  
  	if test "x$drm_cv_atomic_primitives" = "xnone"; then
 -		AC_CHECK_HEADER([atomic_ops.h], drm_cv_atomic_primitives="libatomic-ops")
-+		PKG_CHECK_MODULES(ATOMIC_OPS, [atomic_ops], drm_cv_atomic_primitives="libatomic-ops")
++		PKG_CHECK_MODULES(ATOMIC_OPS, [atomic_ops], drm_cv_atomic_primitives="libatomic-ops", true)
  	fi
  
  	# atomic functions defined in <atomic.h> & libc on Solaris
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/libdrm: PKG_CHECK_MODULES should not fail when libatomic_ops is missing

Hello,

Quoted 9 lines · Bernd Kuhls

According to https://autotools.io/pkgconfig/pkg_check_modules.html
"In contrast with almost all of the original macros, though, the default
action-if-not-found will end the execution with an error for not having found the dependency."

Fixes
http://autobuild.buildroot.net/results/cea/cea777dc997f86c1122c8b818d264215a0e77e5a/

Signed-off-by Bernd Kuhls <[email protected]>

This commit log was a bit light in explanation, so improved it and applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com