Skip to contentSkip to conversation

ntp: does not work with libressl

PATCH New Peter Korsgaard 2 participants 3 messages Jan 7, 2018 – Jan 8, 2018

lore
Share & tools
lore

Peter Korsgaard

author
#0 lore raw

PATCH 1/1 ntp: does not work with libressl

Fixes #10556

The --with-crypto handling in ntp only works with libopenssl, not with libressl, where it ends up with compilation issues like:

ntp_control.c:(.text+0x64): undefined reference to EVP_MD_CTX_new' ntp_control.c:(.text+0x10c): undefined reference to EVP_MD_CTX_free' libntpd.a(ntp_crypto.o): In function `bighash':
ntp_crypto.c:(.text+0x2e8): undefined reference to EVP_MD_CTX_new' ntp_crypto.c:(.text+0x328): undefined reference to EVP_MD_CTX_free' libntpd.a(ntp_crypto.o): In function `crypto_verify':
ntp_crypto.c:(.text+0x6cc): undefined reference to EVP_MD_CTX_new' ntp_crypto.c:(.text+0x710): undefined reference to EVP_MD_CTX_free' ntp_crypto.c:(.text+0x72c): undefined reference to `EVP_MD_CTX_free'

So ensure we only pass --with-crypto when libopenssl is used.

Signed-off-by Peter Korsgaard <[email protected]>
---
 package/ntp/ntp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ntp/ntp.mk +1 -1
index 05619aef7c..74cf546988 100644
@@ -23,7 +23,7 @@ NTP_CONF_OPTS = \
 # 0003-ntpq-fpic.patch
 NTP_AUTORECONF = YES
 
-ifeq ($(BR2_PACKAGE_OPENSSL),y)
+ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
 NTP_CONF_OPTS += --with-crypto
 NTP_DEPENDENCIES += openssl
 else
Signature · 1 line
2.11.0
Applied
#1 lore raw

PATCH 1/1 ntp: does not work with libressl

Hello,

Quoted 15 lines · Peter Korsgaard

Fixes #10556

The --with-crypto handling in ntp only works with libopenssl, not with libressl, where it ends up with compilation issues like:

ntp_control.c:(.text+0x64): undefined reference to EVP_MD_CTX_new' ntp_control.c:(.text+0x10c): undefined reference to EVP_MD_CTX_free' libntpd.a(ntp_crypto.o): In function `bighash':
ntp_crypto.c:(.text+0x2e8): undefined reference to EVP_MD_CTX_new' ntp_crypto.c:(.text+0x328): undefined reference to EVP_MD_CTX_free' libntpd.a(ntp_crypto.o): In function `crypto_verify':
ntp_crypto.c:(.text+0x6cc): undefined reference to EVP_MD_CTX_new' ntp_crypto.c:(.text+0x710): undefined reference to EVP_MD_CTX_free' ntp_crypto.c:(.text+0x72c): undefined reference to `EVP_MD_CTX_free'

Quoted 6 lines

So ensure we only pass --with-crypto when libopenssl is used.

Signed-off-by Peter Korsgaard <[email protected]>
---
 package/ntp/ntp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 ntp: does not work with libressl

In reply to Peter Korsgaard
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes #10556
The --with-crypto handling in ntp only works with libopenssl, not with libressl, where it ends up with compilation issues like:

ntp_control.c:(.text+0x64): undefined reference to EVP_MD_CTX_new' ntp_control.c:(.text+0x10c): undefined reference to EVP_MD_CTX_free' libntpd.a(ntp_crypto.o): In function `bighash':
ntp_crypto.c:(.text+0x2e8): undefined reference to EVP_MD_CTX_new' ntp_crypto.c:(.text+0x328): undefined reference to EVP_MD_CTX_free' libntpd.a(ntp_crypto.o): In function `crypto_verify':
ntp_crypto.c:(.text+0x6cc): undefined reference to EVP_MD_CTX_new' ntp_crypto.c:(.text+0x710): undefined reference to EVP_MD_CTX_free' ntp_crypto.c:(.text+0x72c): undefined reference to `EVP_MD_CTX_free'

Quoted 3 lines

So ensure we only pass --with-crypto when libopenssl is used.

Signed-off-by Peter Korsgaard <[email protected]>

Committed to 2017.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard