Skip to contentSkip to conversation

staging: ccree: ssi_hash: remove unnecessary parentheses

PATCH In review Elad Wexler 2 participants 2 messages Dec 28, 2017 – Jan 8, 2018

Subsystems (2)
Staging Crypto API
lore
Share & tools
lore

Elad Wexler

author
#0 lore raw

PATCH 1/1 staging: ccree: ssi_hash: remove unnecessary parentheses

Fixed a coding style issue

Signed-off-by Elad Wexler <[email protected]>
---
 drivers/staging/ccree/ssi_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ccree/ssi_hash.c +2 -2
index 2035835..8d56fa7 100644
@@ -2280,8 +2280,8 @@ int ssi_hash_alloc(struct ssi_drvdata *drvdata)
 				      &hash_handle->hash_list);
 		}
 
-		if ((hw_mode == DRV_CIPHER_XCBC_MAC) ||
-		    (hw_mode == DRV_CIPHER_CMAC))
+		if (hw_mode == DRV_CIPHER_XCBC_MAC ||
+		    hw_mode == DRV_CIPHER_CMAC)
 			continue;
 
 		/* register hash version */
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 6 lines · Elad Wexler

Fixed a coding style issue

Signed-off-by Elad Wexler <[email protected]>
---
 drivers/staging/ccree/ssi_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Why did you send this twice?

drivers/staging/ccree/ssi_hash.c int ssi_hash_alloc(struct ssi_drvdata *drvdata) · line 2284

Quoted 12 lines
drivers/staging/ccree/ssi_hash.c +2 -2
index 2035835..8d56fa7 100644
@@ -2280,8 +2280,8 @@ int ssi_hash_alloc(struct ssi_drvdata *drvdata)
 				      &hash_handle->hash_list);
 		}
 
-		if ((hw_mode == DRV_CIPHER_XCBC_MAC) ||
-		    (hw_mode == DRV_CIPHER_CMAC))
+		if (hw_mode == DRV_CIPHER_XCBC_MAC ||
+		    hw_mode == DRV_CIPHER_CMAC)

No, now I have to go look up if == or || comes in which order. Ick, just leave it as-is please.

thanks,

greg k-h